michikono / boxfit Goto Github PK

This plugin is exactly what I need! But, I ran across an issue in older Android devices in its native browser. Works fine in these versions of Android in the Chrome browser, but since Android's default browser is its native one, most users will be seeing our content in the native browser and not Chrome.

I am not familiar with JavaScript and jQuery, so excuse if I'm missing something, but it seems to me that the maxFontSize option has not actually been implemented.

Adding the following code into the while loop does what I would the option expect to do:

if (settings.maxFont) {
  if (parseInt(inner_span.css("font-size"), 10) >= parseInt(settings.maxFontSize, 10)) {
    break;
  }
}

This is excellent! Exactly what I am looking for. However, is there angular only solution? If not, I will write one.

This plugin is missing AMD/CJS support and returning itself to avoid loading jquery + boxfit.

I could do a PR if you want.

hi!

I tested on local to change line-height to 150% and it didn't break on my case.
is it possible to add such a settings ?

thanks.