micheh / phpcs-gitlab Goto Github PK

Hi, @micheh.

Refer to Gitlab documentation location.path must be "relative path to the file containing the code quality violation"

But now it is absolute path that generates in widget wrong links to source code.
Example from my project, red line is base checkout path in runner:

That part should be trimmed with $CI_PROJECT_DIR (doc)

Hello!

First of all, thank you for this great piece of code, works beautifully.

What do you think about opening a PR to squizlabs/PHP_CodeSniffer for including the codeclimate spec?

Basically gitlab is using a subset of it, but still, both would benefit the community and didn't want to steal your work 🙂

Cheers!
R

PS: found another really cool solution here:

php -dmemory_limit=-1 vendor/bin/phpcs  --report=json . | jq '[.files | keys[] as $file | .[] | .messages | .[] as $msg |  {type: "issue", check_name: $msg.source, categories: ["PHP", "phpcs"], fingerprint: ("\($file):\($msg.line):\($msg.source)"), description: $msg.message, location: { path: $file, lines: {begin: $msg.line, end: $msg.line }}}]'

Currently noticed, that gitlab reports old code style errors as new. Turns out that if error moved to different line the fingerprint for it changes as well and gitlab treat it as new code style problem. Did some digging and found out that codeclimate computes fingerprint differently. Instead of relaying on line, they read content of that line and strip whitespaces.
Reference to codeclimate fingerpint pr