mgylabs / mkbot Goto Github PK

Description of the new feature/enhancement

A command that allows MK bot to play music in a voice channel using Youtube.

• Music searching method: //music play "thinking out loud"
• Youtube URL request available //music play "www.youtube.com/watchv=ZbZSe6N_BXs&ab_channel=PharrellWilliamsVEVO"
• Able to play Youtube playlist
• Function to play series of music automatically (can specify genre, singer, etc.) : //music play auto "jazz"

//music stop
//music pause
//music skip
//music list
//music delete
....

Proposed technical implementation details (optional)

• Youtube playing: YoutubeDL
• automatic music play: needs ideas

Description of the new feature/enhancement

1. Change command format to subcommands, add configuration settings that allows the user to choose subcommands or not
//play => //music play

2. delete specific song in queue
   //queue delete 3
   deletes 3rd song in queue

3. Youtube playlist playing command
   //play "playlist url"
   plays the whole playlist

4. automatically suggest and play songs
   //play "keyword" auto
   automatically plays songs related to the keyword infinitely
   ex) //play "jazz" auto
   Closed by #261

5. play desired song right away
   //play "keyword" -now

Proposed technical implementation details (optional)

subcommands: https://stackoverflow.com/questions/50548316/subcommands-in-python-bot

Description of the new feature/enhancement

We introduced a new way of automatic update at 863fb80 and 394cb4f, but the update speed has been slightly slower. This is due to performance issues with CopyFiles and RMDir which are NSIS commands.

Proposed technical implementation details (optional)

I think that the file move operation needs to be implemented separately via C# and C++.

Describe the bug

Command raised an exception: AttributeError: 'NoneType' object has no attribute 'title'

Steps to reproduce

type .play [youtube link]

Expected behavior

Screenshots

Environment

• OS: Windows 10
• MK Bot Version 1.4.0.7224f1a

ABRT Logs

Traceback (most recent call last):
  File "discord\ext\commands\core.py", line 85, in wrapped
  File "core\utils\MGCert.py", line 121, in outerfunc
  File "core\music.py", line 197, in play
AttributeError: 'NoneType' object has no attribute 'title'

Version: 1.4.0 Canary
Commit: 7224f1a85fb0539bb7697520a8fcb90985df614c
OS: Windows 10 10.0.19041 SP0

Possible fixes