metormote / edifact-xml Goto Github PK

Hi,

In case you want to revert the generated XML back to Edifact format you might use attached Java program. Please note that changing the order of the XML elements, or adding / removing them, will result in an incorrect Edifact message.

Best regards,
tdijk

EdifactSerializer.java.zip

In the current version, only decimal notation with a dot is allowed. If a comma is specified in the UNA segment, an error occurs. Why was no comma taken into consideration in the code? Is there a reason for this? Because there are EDI data which contain a comma in the UNA segment.

Note:
If I understand it correctly, in the EdifactReader class the constant with DECIMAL is initialised with '.'. And this constant is used to check the decimal notation in the UNA segment.

Hi,

First thanks for this library, it really help me for my actual work.
I'm not 100% sure of my subject here and I don't have access to the ISO-TS 20625-200 norm, so I let you evaluate my remark.

I generated an XML file from an INVOICE 01B and according to me, there is some non-necessary elements.
I'll take the NAD for example.

In my input file:
NAD+SU+1234567890123::9'

With your library:

<S_NAD>
   <D_3035>BY</D_3035>
   <C_C082>
      <D_3039>5400110000030</D_3039>
      <D_1131 />
      <D_3055>9</D_3055>
   </C_C082>
</S_NAD>

According to the EDIFACT norm, the data element D_1131 isn't mandatory but conditional (https://www.truugo.com/edifact/d01b/invoic/)
So according to me, the tag should not be present.
There is a lot of similar cases and if I try to validate your generated file with XSD I found, I've got issues because according to that XSD, this is not a mandatory element.

It will be convenient to have Maven or Gradle build definition to use this library as a dependency.

When calling EdifactParser.parse(InputSource inputSource) with inputSource, which is created not from character stream (byte stream in my case), reader initialization is done correctly but then there is a strange line of code with exception being thrown, which fails parsing process.
I assume it is a typo, that this line of code exists, because there is no execution path in if-else cases above that leads to reader being not initialized.