Git Product home page Git Product logo

Comments (4)

moberegger avatar moberegger commented on June 2, 2024

I think we can also get some easy performance wins here by only loading the configuration file once. Right now, it looks like it will do it multiple times per build. For example, if I have a config like

{
  "includePaths": [
    "{}/node_modules/bootstrap/scss"
  ]
}

it looks like it will try to load the config anytime I try to @import something from bootstrap, which can get quite expensive. Keep in mind that it does this for every nested import, too, so it can add up quickly.

We could probably just load the file once at the root of the plugin, since it is doing it synchronously anyways.

from meteor-scss.

moberegger avatar moberegger commented on June 2, 2024

I have changes locally that fix all of the issues I have mentioned above. I can submit a PR for it soon.

from meteor-scss.

sebakerckhof avatar sebakerckhof commented on June 2, 2024

Yeah, my bad, I merged it into an a wrong/incomplete branch locally.

from meteor-scss.

StorytellerCZ avatar StorytellerCZ commented on June 2, 2024

Fixed in 4.14.2

from meteor-scss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.