Comments (4)
I think we can also get some easy performance wins here by only loading the configuration file once. Right now, it looks like it will do it multiple times per build. For example, if I have a config like
{
"includePaths": [
"{}/node_modules/bootstrap/scss"
]
}
it looks like it will try to load the config anytime I try to @import
something from bootstrap, which can get quite expensive. Keep in mind that it does this for every nested import, too, so it can add up quickly.
We could probably just load the file once at the root of the plugin, since it is doing it synchronously anyways.
from meteor-scss.
I have changes locally that fix all of the issues I have mentioned above. I can submit a PR for it soon.
from meteor-scss.
Yeah, my bad, I merged it into an a wrong/incomplete branch locally.
from meteor-scss.
Fixed in 4.14.2
from meteor-scss.
Related Issues (20)
- Adding package gives error HOT 1
- _includePaths is not iterable in Meteor 1.8 HOT 9
- Can't get source maps working after upgrading to Meteor 1.10 HOT 1
- Error with @charset when importing Bulma HOT 6
- Can't find binary HOT 1
- :not pseudoselectors removed during compilation HOT 2
- Indented/sass format seems to be supported? HOT 4
- Can't build since update HOT 3
- "Uncaught Error: Element type is invalid" if .scss file with same base name exists in importing file's folder HOT 2
- Same SCSS import in few files will be placed to final CSS once, or each time, when I'm importing it?
- Remove prebuilding binaries a dependency for this package HOT 1
- plugin-cache for fourseven:scss gets insanely huge HOT 3
- Node-Sass deprecated; recommendation is to switch to dart-sass HOT 2
- File to import... not found in file: undefined HOT 8
- SASS files from node_modules are not being transpiled HOT 4
- Importing sass from scss throws error HOT 2
- Using the @use rule HOT 2
- Cannot download "darwin-arm64-83_binding.node" HOT 5
- Update git link in package.js HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meteor-scss.