• Add JSFOwner
• Update copyright in LICENSE to JS Foundation (see #50)

I suppose there is a typo in jed.js:

$ egrep -n "fallb?ack" jed.js

227:      var fallack;
236:        fallback = new Jed();
237:        return fallback.dcnpgettext.call( fallback, undefined, undefined, singular_key, plural_key, val );

I'd say that line 227 should read var fallback;

BTW: awesome library, thank you - I'll use it in my next projects.

And another question regarding documentation:

Is there a parser which extracts gettext keys and values from source code and creates .po files?
And if yes, is it working with the Chain-API?
Sorry, if I missed something...

See https://github.com/SlexAxton/Jed/blob/master/jed.js#L97

    if ( options.domain && ! this.options.locale_data[ this.options.domain ] ) {
      throw new Error('Text domain set to non-existent domain: `' + domain + '`');
    }

must be:

    if ( this.options.domain && ! this.options.locale_data[ this.options.domain ] ) {
      throw new Error('Text domain set to non-existent domain: `' + this.options.domain + '`');
    }

Otherwise, the error "domain is undefined" is thrown when Jed attempts to throw a custom error.

Heads up Underscore.js changed how _.extend works.
_.extend will now assign undefined values.

At the top of https://github.com/messageformat/Jed and in https://www.npmjs.com/package/jed, the URL http://slexaxton.github.com/Jed is written instead of http://messageformat.github.io/Jed

In commit 8cc3736, it looks like the expected format of locale_data changed so that the first element of the translated data array is no longer supposed to be a null. That's at odds with what's on the doc site http://slexaxton.github.io/Jed/ and a lot of the examples on the web. po2json, which I was using to parse my po files, doesn't output the right format anymore. Please update the doc and examples.

_{I find JED an excellent improvement to gettext. I can't wait to start using it, but I'm a bit lost.}
^{So I'm asking here, for posterity. Thanks in advance!}

To make things simple, consider this situation:
I want an Express app that returns Hello World! to every request,
translated to the browser's language.

var express = require('express')
  , app = express();

app.use( /** some amazing middleware **/ );
app.use(function(req, res) {
  // the browser's locale is in req.locale
  res.send("Hello World!\n");
}

How would you do this with JED?
How many instances would be needed?
How many domains? ...

po2json outputs the plural forms with a key of Plural-Forms (https://metacpan.org/source/GETTY/Locale-Simple-0.011/bin/po2json#L110) and it looks like Jed wants it under a key of plural_forms

I'm guessing there is no such thing as a spec for PO-as-json so perhaps Jed just needs to look at both keys?

Thoughts? If you are happy with this approach than I'll throw together a quick PR.

Hi,

when I try to visit the Homepage of Jed, I get a 404. Anyone noticing the same issue?

Sincerely,
yduman

I'm using JED but when I call the translate/gettext method on a key, I'm only getting the first character!

So if I have a key like: "Hello" that should get the transalation for german: "Hallo", instead I just get H. See here, which shows the JED object, and then the output for i18n.translate('Hello').fetch():

I am unable to add the callback to the JSON file. I tried

  "missing_key_callback" : function(key) {
    // Do something with the missing key
    // e.g. send key to web service or
    console.error(key)
  },

to no avail

Hi, this has been bugging me for a while

// Note: by convention, the 0-index location of the translations
// is never accessed. It's just a thing, I guess.

what does this mean, convention by whom ? I look at my po files and all of them have all useful data.

They don't have any useless translation that is never accessed, so where is this convention coming from.
For kicks I've been going through the source code and deleting all ' + 1' there and there, and with an ugly

val_list = _.compact(val_list);

It just works, but there's no waste of an empty index in an array. Why would I parse an mo file to generate empty data ?

I wrote a small implementation of the gettext concept recently and wanted to provide two new methods to the community. I was writing these in React Native, as shown below, and would be happy to incorporate the pure JS equivalents into this project for Hacktoberfest! 🎃🎃🎃

In short, the first method pboolgettext returns the plural form if a boolean is true or the singular form if the boolean is false. This is a case when no variables need to be inserted.

The second, pvboolgettext, does the same, but formats the plural message with variables.

/*
    * Returns the singular form of the message if a given boolean condition is true, otherwise the plural form.
    *
    * usage : pgettext(singularMessageId: string, pluralMessageId: string, b: boolean)
    *
    * @param singularMessageId <string> : the message ID to be used if the number of elements specified is zero
    * @param pluralMessageId <string> : the message ID to be sued if the number of elements specified is greater than zero
    * @param b <boolean> : a condition indicating if the singular message form should be displayed or not
     */
    pboolgettext(singularMessageId: string, pluralMessageId: string, b: boolean) {
        if (typeof singularMessageId === "undefined" || typeof singularMessageId === "undefined" || typeof b === "undefined") {
            throw "pboolgettext: Invalid arguments";
        }
        return b ? this.translations[singularMessageId] : this.translations[pluralMessageId];
    }

    /*
    * Returns the singular form of the message if a given boolean condition is true, otherwise the plural form formatted with variables.
    *
    * usage : pgettext(singularMessageId: string, pluralMessageId: string, b: boolean, value: any)
    * usage : pgettext(singularMessageId: string, pluralMessageId: string, b: boolean, values: [any, ... ,any])
    *
    * Note : variables can be mixed string and number.
    *
    * @param singularMessageId <string> : the message ID to be used if the number of elements specified is zero
    * @param pluralMessageId <string> : the message ID to be sued if the number of elements specified is greater than zero
    * @param b <boolean> : a condition indicating if the singular message form should be displayed or not
    * @param v <any> : the variable or variables to insert into the plural string
     */
    pvboolgettext(singularMessageId: string, pluralMessageId: string, b: boolean, ...values) {
        if (typeof singularMessageId === "undefined" || typeof singularMessageId === "undefined" || typeof b === "undefined" || typeof values === "undefined") {
            throw "pvboolgettext: Invalid arguments";
        }
        if (b) {
            return this.translations[singularMessageId];
        }
        return this.vngettext(pluralMessageId, ...values);
    }

is it possible change locale_data dinamically when JED object is already created?

Hi,

just noticed when downloading 0.5.4 that the jed.js header comment still says it is 0.5.0. Would be nice to have that reflecting the actual version (in upcoming versions).

Thanks!

Hi,

I've noticed that Jed currently doesn't have support for notifying a web service when a key is not found like i18next does.

I would like to add a callback to Jed which is called when a key is not found, making it possible to notify a web service or send an email from the callback.

What do you think of this?

Josh

Hi,

I'm trying to get my messages.po from Javascript files using Jed. I'm using xgettext and this command:

  xgettext --keyword=translate --from-code utf-8 -L Perl `find . -iname "*.js"`

It seems to work fine, but the problem comes when xgettext finds plurals like the next ones:

i18n.translate("Pass through %1$s %2$s").fetch(var1, var2);

Because it doesn't recognizes $ as a valid character. Is there any work around using xgettext, or otherwise, any other way to use a different numbering method xgettext-compatible?

Thanks.

Currently, Jed uses sprintf 0.7 which is more than four years old and contains several bugs which are meanwhile fixed (for example huh?).

@SlexAxton do you think, this could be updated? maybe even made a dependency in package.json?

The repository url in the package.json contains a username, which causes problems in some browsers.

By opening this link in firefox the browser attempts to login to github with the SlexAxton username and shows the following error:

You are about to log in to the site “github.com” with the username “SlexAxton”, but the website does not require authentication. This may be an attempt to trick you.

In the documentation I see only one way to load translation - when the init Jed.
ok! what if I use require.js for dynamically loading some Views and with it I want upload additional translations for Jed?
Here example with using "extend" (underscore.js). Can you propose another way?
I mean a legal (native) way with the context of the library.

var i18n = new Jed(options);
 require(['json2', 'text!/test/translation/fr/app.json'], _.bind( function(JSON, appjson) { 
  _.extend(i18n.options.locale_data.messages, JSON.parse(appjson) );
 }, this)  );

Thanks!

Hey Jed folks! A couple of us were having a discussion about the new Jed format downstream at mikeedwards/po2json#32 . We're trying to figure out what the best output for something like this:

msgid "one product"
msgid_plural "%d products"
msgstr[0] "jeden produkt"
msgstr[1] "%d produkty"
msgstr[2] "%d produktów"

We were outputting (correctly or not):

         "one product": [
            "%d products",
            "jeden produkt",
            "%d produkty",
            "%d produktów"
         ],

Would it be like this now that the zeroth element is being lopped off?

         "one product": [
            "jeden produkt"
         ],
         "%d products": [
            "jeden produkt",
            "%d produkty",
            "%d produktów"
         ]

Thanks for Jed!

I'm looking into generating the .po files from my source. I wondered how you do/did that?

I started working on contributions to an existing package (handelbars-xgettext), but there must be something already out there?

Currently one cannot do:

const {gettext} = i18n
gettext('Hello, World.')

As this would return:

TypeError: Cannot read property 'call' of undefined

However it seem fairly important to be able to shorten notations for views/renders with a lot of strings and for clarity of context.

Would it make sense to add a property accessor that would return an object listing those method as bound vs. call? This would also allow destructuring to get the needed methods.

My translations weren't working, and I had to search through the source code of po2json to discover that I needed to use the 'jed1.x' setting rather than just 'jed'. Might be worth noting this in the documentation.

So just to be clear, I needed to run

jedInitJson = po2json.parse(window.PRELOAD.TRANSLATIONS, {format: 'jed1.x'})

instead of

jedInitJson = po2json.parse(window.PRELOAD.TRANSLATIONS, {format: 'jed'})

Thanks for the great library!

Hi,

How does one generate .pot from the source code using Jed? I assume that gettext won't be able to parse the calls to Jed since the syntax is too complex. If that's so, what are the alternatives?

Cheers,
Andrej

It seems to be impossible to load string from different locale.

You might need it, for example, for generating of list of available languages, within which each language should be displayed in it's on language:

* English
* Украинский
* Deutsche

Are there any chances to see such functionality?

Thanks in advance!

I'm trying use jed.js as a solution for i18n in my project.

I'm having trouble understanding the options passed to the Jed constructor.

Docs say that I should pass in a domain and locale_data object. However, in the locale_data, there is another key with the domain value. And again, under that, there is an empty key (i.e. "") which has another domain key and the domain as the value.

Here's an excerpt from the docs:

var i18n = new Jed({
    // You can choose to set the domain at instantiation time
    // If you don't, then "messages" will be used by default
    "domain" : "the_domain",
    // This is the translation data, which is often generated by
    // a po2json converter. You would ideally have one per locale
    // and only pull in the locale_data that you need.
    "locale_data" : {
        // This is the domain key
        "the_domain" : {
            // The empty string key is used as the configuration
            // block for each domain
            "" : {
                // Domain name
                "domain" : "the_domain"
            }
        }
    }
});

1. What is the meaning of the domain, and why is it repeated so many times?
2. Do I need a new Jed instance for every domain?
3. How does the domain relate to the language?

The file contains an obsolete version number (0.5beta) in the top comment:
https://github.com/SlexAxton/Jed/blob/master/jed.js#L2

This should either be removed or kept up to date to prevent confusion.

Hi,

I'm currently using xgettext in Python mode, but there are quite a few edge cases where it doesn't work correctly. How do you extract gettext keys from your JS files?

thanks,
Florian

Is there a way to detect the device language and act accordingly or do you need to tell it which translation data to use based off the language. Or, if I have a spanish domain but not english, it won't throw an error but will default to the id -- return the key or msgid if there is no domain

There are two examples of plural forms on this page

1. "%d key" : [ "%d key", "%d keys" ],
2. "test singular": ["test plural", "test_1 singular", "test_1 plural"],

These appear to be different structures. Using Gettext terminology they look like:

1. msgid: [ msgstr1, msgstr2 ]
2. msgid: [ msgid_plural, msgstr1, msgstr2 ]

Can you please clarify how this structure should be used and whether it has changed at some point?