Description

Handle de-provisioning for system default namespaces.

Namespaces to handle:

• default
• kube-system
• kube-public

On a different note this can also be handled with the type of error returned, basically -
https://pkg.go.dev/k8s.io/apimachinery/pkg/api/errors#IsNotAcceptable

Given that we’re incorporating full images (SVGs) into Meshery Adapter config.go files, we’re going to want to consider changing the lint rules to accommodate. Here is an example failure - https://github.com/meshery/meshery-cilium/pull/104/files#file-build-config-go-L29

Slack Message

Current #State:
See the white background between the man and woman in the image below that needs to be updated to a better version in the README file.

Desired State:
This is the desired image.

Replace with the image below.

Contributor Resources

• Meshery documentation site
• Meshery documentation source
• Instructions for contributing to documentation

Description

These days, we have been released so many update on

• meshkit
• meshsync
• meshery-operator
• others

And the updates does not only includes:

• fixed issues of the code
• bump the version of dependencies
• bump the version of golang
• fixed the cycle of dependencies
• fixed the security issues

So, as a common library of all the adapters. meshery-adapter-library also should be updated. And because of it was imported by the other adapters. We should be careful to do this.

• #116
• #124
• #132
• #133
• #134
• #125
• #140
• #131

Some of them we need to merge them at first and then check the compatibility by manually.

Expected Behavior

Screenshots

Environment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

[Optional] Additional Context

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Current State:

There exists a need for documentation of architecture, purpose and design of the common libraries.

There is little documentation about this now, some of it is in the Meshery Adapters document (drafts, discussions): https://docs.google.com/document/d/1b8JAMzr3Rntu7CudRaYv6r6ccACJONAB5t7ISCaPNuA/edit#heading=h.qgnry4nf3hlv

As of now, two common libraries are worked on: https://github.com/layer5io/meshkit and this one (meshery-adapter-library).

This issue is about meshery-adapter-library.

The use of these libraries by other components than adapter needs to be considered as well.

Desired State:

• Architecture and design document
• Documentation in the code (godoc) of the common libraries
• Where to put new code (and why)
• Dependency hierarchies
• How to use the libraries (and why)
• The documentation should be "just enough", to make it easy for contributors to use and contribute to the libraries

See also

• More clearly roadmap for the project
• Change the name of this repository from gokit to meshkit

Description

Expected Behavior

Screenshots

Environment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

[Optional] Additional Context

Description

Operation responsible for creating the adapter clients uses viper internally which is not thread safe hence concurrently accessing the function results in a go "panic".

Expected Behavior

Creating the adapter clients should be thread safe.

Screenshots

Environment:

• OS: Manjaro Linux

To Reproduce
Steps to reproduce the behavior:

1. Trying to create the adapter clients in a loop, that should be enough to reproduce the issue

Current Behavior

• Currently, there is no target to fix gofmt and goimport warnings from golangci-lint, and to tidy mod
• the target running golangci-lintis called check(similar for clearing its cache)
• Neither is go mod verify executed, and that could be useful too

Desired Behavior

• Target golangci-run called from target check, or rename check to golangci-run
• Target clean, executing go clean and golangci-lint cache clean
• Target verify executing go mod verify
• Target tidy executing go mod tidy, gofmt -w ., goimports -w .

Resources

Makefiles in other Layer5 (adapter) repositories.

Description

According to meshery/meshery#7434, we should remove all the code related to OAM. Meshery server and some of adapters like meshery-linkered see meshery/meshery-linkerd#519

But here we can see OAM still in current repo. We need to remove these no useful code too. Because:

• No features are dependent on these code
• These code does not under maintain
• Some of out of date dependencies of these code are caused security issues to every adapter.

Expected Behavior

Screenshots

Environment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

[Optional] Additional Context

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Description
Under GitHub Actions of this repository "Slack Notify on Star" job is failing for which Slack.yaml is to be Updated.

Expected Behavior

To fix this issue, update the code of slack.yaml

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Current Behavior

Most/all keys for config entries, like "name", are used as string literals.

Desired Behavior

Define keys as constants. Also use them in the common / examples code (package common).

Description

The common library's dependencies are caused the other adapter repo hard to update the dependencies version. And this needs to be fixed.

go mod tidy
go: finding module for package go.opentelemetry.io/otel/semconv/v1.17.0/httpconv
go: finding module for package github.com/layer5io/meshkit/models/meshmodel
go: finding module for package go.opentelemetry.io/otel/attribute
go: finding module for package go.opentelemetry.io/otel/semconv/v1.17.0
go: github.com/layer5io/meshery-kuma imports
        github.com/layer5io/meshery-adapter-library/adapter imports
        github.com/layer5io/meshkit/models/meshmodel: module github.com/layer5io/meshkit@latest found (v0.6.77), but does not contain package github.com/layer5io/meshkit/models/meshmodel
go: github.com/layer5io/meshery-kuma/kuma imports
        github.com/layer5io/meshkit/utils/kubernetes imports
        helm.sh/helm/v3/pkg/action imports
        helm.sh/helm/v3/pkg/registry imports
        oras.land/oras-go/pkg/auth/docker imports
        github.com/containerd/containerd/remotes/docker imports
        github.com/containerd/containerd/tracing imports
        go.opentelemetry.io/otel/attribute: module go.opentelemetry.io/otel@latest found (v1.19.0, replaced by go.opentelemetry.io/[email protected]), but does not contain package go.opentelemetry.io/otel/attribute
go: github.com/layer5io/meshery-kuma/kuma imports
        github.com/layer5io/meshkit/utils/kubernetes imports
        helm.sh/helm/v3/pkg/action imports
        helm.sh/helm/v3/pkg/registry imports
        oras.land/oras-go/pkg/auth/docker imports
        github.com/containerd/containerd/remotes/docker imports
        github.com/containerd/containerd/tracing imports
        go.opentelemetry.io/otel/semconv/v1.17.0: module go.opentelemetry.io/otel@latest found (v1.19.0, replaced by go.opentelemetry.io/[email protected]), but does not contain package go.opentelemetry.io/otel/semconv/v1.17.0
go: github.com/layer5io/meshery-kuma/kuma imports
        github.com/layer5io/meshkit/utils/kubernetes imports
        helm.sh/helm/v3/pkg/action imports
        helm.sh/helm/v3/pkg/registry imports
        oras.land/oras-go/pkg/auth/docker imports
        github.com/containerd/containerd/remotes/docker imports
        github.com/containerd/containerd/tracing imports
        go.opentelemetry.io/otel/semconv/v1.17.0/httpconv: module go.opentelemetry.io/otel@latest found (v1.19.0, replaced by go.opentelemetry.io/[email protected]), but does not contain package go.opentelemetry.io/otel/semconv/v1.17.0/httpconv

Expected Behavior

Screenshots

Environment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

[Optional] Additional Context

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Current Behavior

Currently, wait until ready functionality is not implemented.

Desired Behavior

For more details, see meshery/meshery-linkerd#100

Implementing it here based on the implementation in the Linkerd adapter will make it available for all adapters using this library.

[Optional] Resources

[Optional] Alternatives / Additional Context

Current Behavior
Meshery adapters have their version # hardcoded. See https://github.com/layer5io/meshery-adapter-library/blob/master/common/defaults.go#L34

Desired Behavior
An adapter's version number should be retrieved at buildtime from the CI workflow.

Resources

Alternatives / Additional Context

Will you please add a probable cause and suggested remediation?

Originally posted by @leecalcote in #68 (comment)

Current Behavior

Several adapters (meshery-consul among others) inform the user about the port numbers of main service in a log event.
This method has not yet been implemented in meshery-adapter-library.

Desired Behavior

This method is implemented in meshery-adapter-library, such that it can be used in e.g. the consul adapter.

Resources

Base the code on the code from the consul adapter.

Alternatives / Additional Context

Description
When running an SMI Conformance test against Kuma, the following error happens:

Expected Behavior

1. SMI conformance tests should execute and return results (pass or fail).
2. Errors like this are handled and the user is given a probable cause and suggested remediation.

Current Behaviour
Error codes utility runner workflow is not present.

Desired Behavious
Add the error codes utility runner workflow.

Instructions in meshery/meshery-linkerd#213

Description
Getting config error due to difference in config for GKE cluster

Expected Behavior
Istio adapter to be reachable

Logs

➜  meshery git:(master) kubectl logs deployments/meshery-istio -n meshery
app=istio-adaptor ts=2020-12-08T15:39:09.838376456Z level=info message="Adaptor Listening at port: 10000"
app=istio-adaptor ts=2020-12-08T15:42:35.757084641Z level=info message="Creating instance"
app=istio-adaptor ts=2020-12-08T15:42:35.757138734Z caller=level.go:63 level=error code=1001 severity=1 short-description=None long-description="Error creating adapter instance.Error validating kubeconfig.current-context must exist in order to minify" probable-cause=None suggested-remediation=None

Description

README.md is the first file one should read when starting a new project. Our community launched Discussion forum for help seekers; needs to publish it officially on README.md for convenience.

Screenshots

Current behaviour:

Desired behaviour:

Note:
Need to add only last line for Community Forum

Environment:

• OS: any [e.g. Ubuntu]
• Browser: any [e.g. Chrome, Safari]
• Version: any [e.g. 22]
• Device: any [e.g. laptop, iPhone 8]

Reference:

• Take reference to this pull request

Description

no error details found for error name 'ErrApplyOperationCode' and code '1008'

Expected Behavior

There should be a detailed error code for 'ErrApplyOperationCode'

This is found here https://github.com/meshery/meshery-adapter-library/blob/master/adapter/error.go#L30, but once you look through the file, there is no section to call for this error code.

Screenshots

Environment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

[Optional] Additional Context

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Description

Currently, we are using the Logo of Layer5 instead of Meshery. This repository is under the organization Meshery, so, there should be the image of Meshery.

How to resolve this?

• Go to .github and replace this welcome image with the new one:

• Make sure to display the images conditionally, based on the theme selected by user.
  Here's the sample code:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Meshery Logo" src="">
</picture>

New images are:

• Download these images, and upload with an appropriate name. Make sure to use conditional rendering as described above.

• After uploading the image, and removing the previous image, go to .github/config.yml folder and update the reference to previous image to the new image in the following part:

firstPRMergeComment: >
  Thanks for your contribution to the Layer5 and Meshery community! :tada:
   
  ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png)
    	   	    	    	 :star: Please leave a [star on the project](../stargazers). :smile:

Here, replace ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png) with the code

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Shows a black logo in light color mode and a white one in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
</picture>

make sure to change the image sources with the path to image in the folder where you upload it.

• That's it.

Contributor Guides and Handbook

• 🛠 Meshery Build & Release Strategy
• 📚 Instructions for contributing to documentation
  • Meshery documentation site and source
• 🎨 Wireframes and designs for Meshery UI in Figma
• 🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Current Behavior
There is an if condition for every component type with their underlying logic inside.
https://github.com/layer5io/meshery-istio/blob/master/istio/oam.go#L19-L53

Desired Behavior
A config which maps the type to their underlying logic function, which removes the if loops with a a generic logic that refers to the config key.

Resources

Alternatives / Additional Context

Current Behavior

There is no code in this repository yet.

Desired Behavior

Transfer the initial version of the meshery adapter library that was created based mainly on the Kuma adapter code, with code also from the Consul adapter, to this repository. It was tested using the Kuma and Consul adapters' code it was based on.

Resources

• Meshery Adapters design and implementation guide document: https://docs.google.com/document/d/1b8JAMzr3Rntu7CudRaYv6r6ccACJONAB5t7ISCaPNuA/edit#heading=h.blih70a9hxp
• Initial version of the adapter library: https://github.com/mgfeller/common-adapter-library
• Refactored Kuma adapter code (not adapted to the latest version of the adapter library): https://github.com/mgfeller/meshery-kuma/tree/feature/mgfeller/modularisation
• Refactored Consul adapter code: https://github.com/mgfeller/meshery-consul/tree/explore/common-library-2

Current Behavior

The project's current issue templates are missing an open invitation link where new contributors can join the community's Figma team and view user interface designs and other UX projects.

Desired Behavior

Each template that has a reference to Figma in its resources section should an invite link added.

Implementation

In each issue template that refers to Figma, replace the current line referring to Figma with this line:

- 🎨 Wireframes and [designs for Meshery UI](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI) in Figma [(open invite)](https://www.figma.com/team_invite/redeem/qJy1c95qirjgWQODApilR9)

Acceptance Tests

1. All references to Figma include the "open invite" link.

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Description

Please look at here, that the security issues that we have https://github.com/meshery/meshery-adapter-library/security/dependabot

And we already fixed these issues in mesh-kit repo. And meshery-adapter-library as a common library of other adapters. It should do not have these security issues. So, there issues should be fixed.

Expected Behavior

Screenshots

Environment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

[Optional] Additional Context

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Description:

This repository should have the label commenter workflow.
It would run whenever an issue/pr is labelled with one of the targeted labels and comment down any relevant information.

Contributor Reference:

The workflow would use: https://github.com/peaceiris/actions-label-commenter

A sample workflow is defined in: https://github.com/meshery/meshery/blob/master/.github/workflows/label-commenter.yml.

It would also need a sample configuration which is defined in: https://github.com/meshery/meshery/blob/master/.github/label-commenter-config.yml

NOTE:

• In the above configuration https://github.com/meshery/meshery/blob/88d1c7c559259775ce2affab2a15a32c673c3f52/.github/label-commenter-config.yml#L26-L41 are specific to Meshery and won't be needed on every repository.
• Do comment in PR if you find any label is missing for the repo.

          We're in need of having `RegisterMeshModelComponents` changed to `RegisterMeshModelComponents` inside of the Meshery Adapter Library. Let's do what we can to get away from `MeshModel` over to `Model`.

Originally posted by @leecalcote in meshery/meshery-nighthawk#46 (comment)

It would be ideal if we did not hard code name operations like this.

Instead, adapters will encode the mechanics of the operation (i.e. kubectl) and operation type (apply) and operation media (single file, file path to a folder containing manifests, or URL to an endpoint that returns a manifest) externalizing the operation names ("BookInfo"), supported operation verbs (apply, delete) and supported versions (version of BookInfo) as config outside of the go code.

Originally posted by @leecalcote in #18 (comment)

This issue is child issue (labeled with kind/child). See meshery/meshery#9966 for additional context.

Current Behavior

Meshery Adapters capabilities have progressed well beyond that of managing service meshes. Adapters include the ability to manage any type of structure as well as perform advanced performance management of that into structure.

Desired Behavior

The meshes.proto in Meshery Server is no longer representative of the broader set of capabilities that Meshery Adapters have. The name of this protobuf file and aspects of its internals need to be updated to reflect this fact.

Implementation

1. Renaming meshes.proto to adapters.proto (and the directory name) - https://github.com/meshery/meshery-adapter-library/tree/master/meshes
2. Update and remove any service mesh specific concepts in the proto and library to be infra and capability agnostic.

Resources

• https://layer5.io/blog/meshery/introducing-meshkit-and-the-meshery-adapter-library

Description
Adapters doesn't get initialised when deployed In-Cluster

Logs
Istio:
time="2021-04-27T12:37:17Z" level=error msg="Error creating adapter instance.Error validating kubeconfig.none of the auth infos are valid either the certificate path is invalid or is inaccessible" app=istio-adaptor code=1001 probable-cause=None severity=1 short-description=None suggested-remediation=None

OSM:
time="2021-04-27T12:49:58Z" level=warning msg="unable to type cast clusters to a map array"

Description

Other repos were already updated to v1.12.x. So, in order to avoid the non-compatible issues of dependencies' version. We need to upgrade the version soon.

Expected Behavior

Screenshots

Environment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

[Optional] Additional Context

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Current Behavior

Right now, the current package for OpenTelemetry is at v1.3.0.

As of right now, the latest package is at v1.10.0 which have some major changes in the last couple years. This will require a refactor, and can also assist in the upgrading from Go 1.17 to 1.19.

Reference:

https://pkg.go.dev/go.opentelemetry.io/otel

Desired Behavior

By refactoring, we will also be able to update according to the rest of the Go projects that replies on this module.

Resources

Alternatives / Additional Context

Description
The Community section in the README says "Access the Community Drive". There is a new procedure of having this automated based on the individual filling in a community member form

Expected Behavior
Update "Access Community Drive" to "To Access Community Drive, fill Community Member Form"

Screenshots

Resources
Refer to the Contributing guide

Environment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

Description
As a project, Mistry has yet to reach that mile stone. As such, the adapter library should not have received it either.

Expected Behavior
a v0.7 version of the library should be available and no releases post v1.0

[Optional] To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

[Optional] Additional Context

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Description
See the screenshot and this comment as an example of the issue - #2 (comment)

An issue lie somewhere between this config - https://github.com/layer5io/meshery-adapter-library/blob/cdeaac08801c9f128dd88cee2b4e5d5005c2c1a0/.github/config.yml#L20 and the location of the image in the .github/welcome folder

Expected Behavior
See this as an example of what should happen - layer5io/layer5#691 (comment)

Screenshots

Desired Behaviour

Need to update Go to 1.21 in go.mod and in Dockerfile, and also Makefile

• Minor chore on updating meshkit and meshery-adapter-library

Current Behavior
Currently the slack.yml is outdated. Also there is no automated way of notifying the slack channel when a "good first issue" has been created.

Desired Behavior
Update slack.yml and add newcomer-alert.yml to the Github workflow.

Resources
Add the updated slack.yml file and the newcomer-alert.yml file to the .github/workflow folder.

Files needed:
https://github.com/meshery/meshery-istio/blob/master/.github/workflows/slack.yml
https://github.com/layer5io/layer5/blob/master/.github/workflows/newcomers-alert.yml

Current Behavior

Meshery Server has an events API for receiving events from Meshery Adapters. The message format is defined in the meshes protobuf.

Desired Behavior

1. Update Meshery Adapters to use new library event features. Reminder: all events are relayed to the Remote Provider via Meshery Server.

Related to meshery/meshery#8560

Resources

Alternatives / Additional Context

Current Behavior

Currently, layer5/gokit is used as dependency and imported.

Desired Behavior

As layer5/gokit has been renamed to layer5/meshkit, all references to layer5/gokit should be replaced with layer5/meshkit.