mertceyhan / bitcoin-market-android Goto Github PK

A small bug came with dark theme support. Currently, chart prices don't seem on the dark theme.

When I click on the backpress button in MarketScreen, I see SplashScreen again. It should exit from the application.

https://developer.android.com/guide/topics/appwidgets/overview

RoomDb version should be upgraded. With current version "2.3.0" it can not compile on M1 MacBooks
following exception occurred on m1 Macs Caused by: java.lang.Exception: No native library is found for os.name=Mac and os.arch=aarch64.

current room version : 2.3.0
expected room version: 2.4.2

https://developer.android.com/jetpack/compose/testing

Implement Jetpack Compose and make the UI composable

• Remove the shared preferences and keep the expired information in the entity
• Return the data always from the database

I'm not sure Is there any particular reason to show a full screen while pulling to refresh or fetching data from API ?

I guess user experience can be improved by showing a dialog instead of showing whole full screen composable

https://developer.android.com/training/wearables/compose-setup

As a User,
I want to get a notification of the current price at 12:00 every day,
so that I can track the price easily

https://developer.android.com/reference/android/app/AlarmManager

As an improvement point, we can add a memory cache mechanism to the project. Return the data from the memory if it is not expired. The expiry time can be one minute.

I can make the darktheme🌚

I think it would be nice to have a code analysis tool to keep the syntax. Detekt is a nice solution but of course, I'm open to discussing your idea.

https://developer.android.com/jetpack/compose/navigation

https://google.github.io/accompanist/swiperefresh/

Create a Github Action and run unit tests and build the project

I think it will be a good idea to add recyclerview inside a fragment to show multiple currencies, in this case we will cover multiple android topics, we can also cache them with room

Hi, it is my first time working on open source
so i am going to change the file structure and move the core to new module

First the default splash screen (https://developer.android.com/guide/topics/ui/splash-screen) plays and then the additional one implemented in the app. Is this intentional? It seems a bit weird. I think it would be an improvement if the default one was disabled.

Replace the mpchart with compose