mergemypullrequest / order-splitter Goto Github PK

Seems like we were trying to mimic the Java builder pattern but only went half way and ended up with a stateful API that leaves a lot of room for bugs. If we actually implemented the builder pattern, we'd have a OrderBuilder type (where orderBuilder.build() returns the actual Order object). Instead that functionality is just baked into Order. So now Order has a lot of potential illegal states.

I don't think the Builder pattern is necessary or helpful in javascript. I think the Order constructor should just accept a JSON object with all the properties once and for all. You won't even need to call order.split() because that will be performed implicitly in the constructor.

Stateless FTW.

Actual

Dawn   $$13.07
Larry  $$13.07
Austin $$13.07

https://jonsmithers.github.io/order-splitter/?tax=1.86&fee=4.98&tip=5.39&Dawn=8.99&Larry=8.99&Austin=8.99

expected:

Dawn   $13.07
Larry  $13.07
Austin $13.07

https://jonsmithers.github.io/order-splitter/?tax=1.86&fee=4.98&tip=5.39&Dawn=8.99&Larry=8.99&Austin=8.99

Example:

• zip file containing html that caused this
• result: https://mergemypullrequest.github.io/order-splitter/?tax=2.5&fee=4.98&tip=5.75&Oliver=8.99&Dillion=5.29&Tony=1.99&Whole-=12.49&Ryan=8.99

input

html	screencap
html.zip

result

https://jonsmithers.github.io/order-splitter/?tax=2.91&fee=4.78&tip=8.91&Larry=11.60&Benjamin=11.49&Smithers=8.50&Daniel=9.99

We are definitely doing something wrong with our caching. I just deployed a new version, reloaded the page, and now I'm out of sync with myself:

Some people seem to think that the totals should be on the bottom row and rightmost column, as opposed to the topmost row and leftmost column which is what we have currently. This is more like Excel.

https://www.polymer-project.org/blog/2017-08-23-hands-on-30-preview

Why are fees split evenly instead of prorated? If I buy a $2 side item, I shouldn't have to pay $4 for it. Instead, I will just not order it and everyone else will pay more.

It's Garret's idea. We can provide a link for people to drag to their bookmark bar. That link is a script that extracts details from the orderup.com DOM and then opens the order splitter website with the details filled in. So they just click that bookmark when they make their order.

I think the input/parser design is fundamentally limiting. When the user copies the orderup receipt and pastes it into our textarea, it gets transformed from html into plaintext, so we lose lots of useful information. Consequently, we're make the user enter sales tax, processing fee, and delivery fee manually.

We can just let the user paste html instead of plain text by using the contenteditable attribute on on a <div>. Then we'd have the html to work with. (Also, we could re-use the same parser in a "live preview" in the chrome-extension.)

tl;dr The parser should be html-based, not text-based.

In the following example (taken from my personal history):

...the chrome extension's html parser uses "Can you please add onions in replacement for 1 of my cucumbers" instead of "Fredric".

This only happens on the chrome extension. Not the website. Aren't they supposed to be using the same parser?

Would be nice to have a UI framework to help with development and aesthetics. React seems cool.

There's a section in the docs entitled Adding React to an Existing Application.

The installation docs say that we can try out react without having to set up a whole build pipeline. Maybe, for starters, we shouldn't worry about getting JSX to work just yet.

We could structure the code to allow for order parsers to be added more easily

The following syntax causes browserify to explode:

Object.entries({a:1,b:2}).forEach(([key, value]) => { });

We're using gulp-browserify which is no longer maintained and several years out of date. It seems to me this syntax bug is long gone in current versions.

Workarounds:

• use function instead of =>
• assign function to a variable first

I think it would be preferable to using the drab user agent stylesheet.

#3 will help a lot with helping us create a sleek look and feel.

Note "7.5" and "10.5" in the screencap below:

https://jonsmithers.github.io/order-splitter/?tax=3.37&fee=4.78&tip=10.44&Keenan=7.5&Josh=7.99&Yolanda=3.99&Garrett=10.5&Kruz=7.25&Austin=6.99&Benjamin=7.99