Comments (4)
Those check were a whole batch of fixes with #2086.
We need to establish:
- Does THN132N possibly report temperature > 70, < -50?
- Does THGR81, THGR810a possibly report temperature > 70, < -50?
- Does THGR81, THGR810a possibly report humidity < 0, humidity > 99? (99 already confirmed now)
- Does WGR800 WGR800a possibly report gust windspeed < 0, > 56,| avg windspeed < 0, > 56
- Does WGR800 WGR800a possibly report quadrant < 0, > 337.5 (e.g. as error codes)
from rtl_433.
You're not going to see temperatures on planet earth of 70 deg. You might get this temperature if you boiled the thermometer but I think it won't send anymore... :-)
This is a slippery slope of validating data. You might find, for example, that another THGR810 cannot send more than 98% humidity. Why? Because the manufacturer only rates it as the range 5% to 95% with a guaranteed error rate +/-. Once it exceeds these limits, its own display consoles only display HH or LL.
It is totally up to yourselves what to do in these circumstance, but my suggestion would be, if you really want to validate the sensors, then use the DATA_COND state to just not send the "bad" reading, rather than disabling the entire sensor.
WGR800
I still have that sensor on a pole, and I know from past usage it never exceeded around 30 m/s. Ever. I have validation software running off an Arduino that reports these if they occur. It has been used for years.
But, is it possible? Who knows? A bad sensor, perhaps? I do know it has sent wrong readings.
Does WGR800 WGR800a possibly report quadrant < 0, > 337.5 (e.g. as error codes)
Looking at my Arduino code, it's byte [4 ] >> 4, so no, it's only ever going to send 0 to 15.
I think validation should be left to the sink of this data. Problem solved.
from rtl_433.
Yes. As a general policy rtl_433 tries to never limit the values with checks unless it's really needed to verify transmission integrity. We should get rid of those checks unless we get false positive otherwise.
Extreme values might be a valueable error code or give more insight to the sensor state than just valid readings.
from rtl_433.
Great job, thank you for that!
I agree, extreme values might give an insight into the sensor state. More often than not, in my experience, they often just fail outright; especially these cheap sensors. YMMV.
But, once again, thank you for your work!
from rtl_433.
Related Issues (20)
- Test results HOT 1
- Dickert MAHS433-01 garage/gate remote decoding HOT 1
- Unknown Chinese TPMS external sensor support HOT 22
- Support for Bresser soil moisture sensor? HOT 88
- Switching between software using Plutosdr HOT 9
- MQTT Connect error: Unknown Error HOT 6
- no messages when -F is log or influx HOT 4
- Badger Orion Endpoint GIF2014W-OSE not working with -R 223 HOT 4
- Device Support - Ecowitt WS85 HOT 2
- WH46 sensor readings. How can incorporate it into rtl_433?. HOT 3
- Frequency hopping issues HOT 2
- Support for Inkbird IBS-P03R Pool Thermometer HOT 7
- JSONL is printed in multiple chunks of data. HOT 4
- Support for Apator Metra E-RM 30 water meter HOT 20
- repo has random branches, for which it is not clear there is a reason to remain HOT 3
- Formally deprecate python2.7, enabling gcing support HOT 2
- Support for VEVOR Wireless Weather Station 7-in-1 HOT 25
- Add documentation for `-F http` rxui web user-interface on port `localhost:8443` HOT 3
- rtl-433 can't find librtl.sdr.so.0 or libSoapySDR.so.0.7 after upgrading from Linux Mint 20.3 to Linux Mint 22 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rtl_433.