Compiling with flat namespace causes build for Homebrew to fail about readpe HOT 6 CLOSED

Some background about this flag and why it's a good idea to remove it can be found here: ocaml/ocaml#10723

Though, the TL;DR is: you only need this if you support very old Macs (pre-10.5 running PPC, so about 15 years old).

from readpe.

Hi @n-thumann. Thanks for raising this issue, however, I am not familiar with the concept of flat namespaces. Is it something we should add to the Makefile for macOS? Could you help?

Thanks!

from readpe.

Unfortunately me neither 😬 But I've found out that omitting -flat_namespace here
https://github.com/merces/pev/blob/master/src/plugins/Makefile#L69 and https://github.com/merces/libpe/blob/master/Makefile#L105 solves the issue. TBH, I cannot evaluate if or how this affects your application.

from readpe.

Oh, I see. I didn't know we were explicitly asking for it. It was probably added by whoever worked on the macOS build (it wasn't me). I'll run a few tests without it to see how the application behaves. Thanks!

from readpe.

@jweyrich do you have any objection to it?

from readpe.

Thanks. It should be fixed now.

from readpe.