Git Product home page Git Product logo

Comments (12)

petterreinholdtsen avatar petterreinholdtsen commented on May 29, 2024 1

from readpe.

petterreinholdtsen avatar petterreinholdtsen commented on May 29, 2024 1

from readpe.

petterreinholdtsen avatar petterreinholdtsen commented on May 29, 2024 1

from readpe.

merces avatar merces commented on May 29, 2024

These files are only used by git so it's ok to remove them from the tarball. I just updated it. Here's a list with all files and directories in the updated tarball:

$ tar -cvzf pev-0.81.tar.gz pev-0.81/
a pev-0.81
a pev-0.81/pev.conf
a pev-0.81/LICENSE
a pev-0.81/LICENSE.OpenSSL
a pev-0.81/Makefile
a pev-0.81/include
a pev-0.81/tests
a pev-0.81/README.md
a pev-0.81/pev.spec
a pev-0.81/lib
a pev-0.81/doc
a pev-0.81/src
a pev-0.81/src/pev.conf
a pev-0.81/src/dylib.c
a pev-0.81/src/compat
a pev-0.81/src/pepack.c
a pev-0.81/src/peldd.c
a pev-0.81/src/peres.c
a pev-0.81/src/plugins
a pev-0.81/src/Makefile
a pev-0.81/src/ofs2rva.c
a pev-0.81/src/pestr.c
a pev-0.81/src/plugins.c
a pev-0.81/src/output_plugin.c
a pev-0.81/src/malloc_s.c
a pev-0.81/src/dylib.h
a pev-0.81/src/pesec.c
a pev-0.81/src/config.c
a pev-0.81/src/pev_api.c
a pev-0.81/src/pedis.c
a pev-0.81/src/pehash.c
a pev-0.81/src/readpe.c
a pev-0.81/src/windows
a pev-0.81/src/userdb.txt
a pev-0.81/src/pescan.c
a pev-0.81/src/rva2ofs.c
a pev-0.81/src/output.c
a pev-0.81/src/windows/run.bat
a pev-0.81/src/windows/Makefile
a pev-0.81/src/windows/cpload.c
a pev-0.81/src/plugins/json.c
a pev-0.81/src/plugins/xml.c
a pev-0.81/src/plugins/Makefile
a pev-0.81/src/plugins/csv.c
a pev-0.81/src/plugins/text.c
a pev-0.81/src/plugins/html.c
a pev-0.81/src/compat/strlcat.c
a pev-0.81/doc/tutorial
a pev-0.81/doc/fdl-1.3.xml
a pev-0.81/doc/manpages
a pev-0.81/doc/manual
a pev-0.81/doc/pev-icon.png
a pev-0.81/doc/manual/en_us
a pev-0.81/doc/manual/en_us/basic-usage.docbook
a pev-0.81/doc/manual/en_us/install.docbook
a pev-0.81/doc/manual/en_us/advanced-features.docbook
a pev-0.81/doc/manual/en_us/manual.docbook
a pev-0.81/doc/manual/en_us/Makefile
a pev-0.81/doc/manual/en_us/info.docbook
a pev-0.81/doc/manual/en_us/pev.docbook
a pev-0.81/doc/manual/en_us/figures
a pev-0.81/doc/manual/en_us/configuration.docbook
a pev-0.81/doc/manual/en_us/faq.docbook
a pev-0.81/doc/manual/en_us/tools.docbook
a pev-0.81/doc/manual/en_us/figures/cygwin-warning.png
a pev-0.81/doc/manual/en_us/figures/runbat.png
a pev-0.81/doc/manpages/pesec.1
a pev-0.81/doc/manpages/pedis.1
a pev-0.81/doc/manpages/pescan.1
a pev-0.81/doc/manpages/readpe.1
a pev-0.81/doc/manpages/pehash.1
a pev-0.81/doc/manpages/rva2ofs.1
a pev-0.81/doc/manpages/pepack.1
a pev-0.81/doc/manpages/peres.1
a pev-0.81/doc/manpages/peldd.1
a pev-0.81/doc/manpages/ofs2rva.1
a pev-0.81/doc/manpages/pestr.1
a pev-0.81/doc/tutorial/pt_BR
a pev-0.81/doc/tutorial/pt_BR/tutorial.docbook
a pev-0.81/doc/tutorial/pt_BR/Makefile
a pev-0.81/doc/tutorial/pt_BR/info.docbook
a pev-0.81/doc/tutorial/pt_BR/pe.docbook
a pev-0.81/lib/libpe
a pev-0.81/lib/libudis86
a pev-0.81/lib/libudis86/udis86.h
a pev-0.81/lib/libudis86/libudis86
a pev-0.81/lib/libudis86/libudis86/itab.c
a pev-0.81/lib/libudis86/libudis86/udint.h
a pev-0.81/lib/libudis86/libudis86/types.h
a pev-0.81/lib/libudis86/libudis86/syn.h
a pev-0.81/lib/libudis86/libudis86/udis86.c
a pev-0.81/lib/libudis86/libudis86/decode.c
a pev-0.81/lib/libudis86/libudis86/syn-att.c
a pev-0.81/lib/libudis86/libudis86/itab.h
a pev-0.81/lib/libudis86/libudis86/Makefile.am
a pev-0.81/lib/libudis86/libudis86/syn-intel.c
a pev-0.81/lib/libudis86/libudis86/extern.h
a pev-0.81/lib/libudis86/libudis86/syn.c
a pev-0.81/lib/libudis86/libudis86/Makefile.in
a pev-0.81/lib/libudis86/libudis86/decode.h
a pev-0.81/lib/libpe/pe.c
a pev-0.81/lib/libpe/LICENSE
a pev-0.81/lib/libpe/Makefile
a pev-0.81/lib/libpe/include
a pev-0.81/lib/libpe/libfuzzy
a pev-0.81/lib/libpe/docs
a pev-0.81/lib/libpe/README.md
a pev-0.81/lib/libpe/utils.c
a pev-0.81/lib/libpe/error.c
a pev-0.81/lib/libpe/exports.c
a pev-0.81/lib/libpe/resources.c
a pev-0.81/lib/libpe/libudis86
a pev-0.81/lib/libpe/misc.c
a pev-0.81/lib/libpe/hashes.c
a pev-0.81/lib/libpe/imports.c
a pev-0.81/lib/libpe/libudis86/itab.c
a pev-0.81/lib/libpe/libudis86/udint.h
a pev-0.81/lib/libpe/libudis86/types.h
a pev-0.81/lib/libpe/libudis86/syn.h
a pev-0.81/lib/libpe/libudis86/udis86.c
a pev-0.81/lib/libpe/libudis86/decode.c
a pev-0.81/lib/libpe/libudis86/syn-att.c
a pev-0.81/lib/libpe/libudis86/itab.h
a pev-0.81/lib/libpe/libudis86/Makefile.am
a pev-0.81/lib/libpe/libudis86/syn-intel.c
a pev-0.81/lib/libpe/libudis86/udis86.h
a pev-0.81/lib/libpe/libudis86/extern.h
a pev-0.81/lib/libpe/libudis86/syn.c
a pev-0.81/lib/libpe/libudis86/Makefile.in
a pev-0.81/lib/libpe/libudis86/decode.h
a pev-0.81/lib/libpe/docs/sphinx
a pev-0.81/lib/libpe/docs/sphinx/source
a pev-0.81/lib/libpe/docs/sphinx/docs
a pev-0.81/lib/libpe/docs/sphinx/docs/_themes
a pev-0.81/lib/libpe/docs/sphinx/docs/_themes/sphinx_rtd_theme
a pev-0.81/lib/libpe/docs/sphinx/source/index.rst
a pev-0.81/lib/libpe/docs/sphinx/source/conf.py
a pev-0.81/lib/libpe/libfuzzy/fuzzy.c
a pev-0.81/lib/libpe/libfuzzy/fuzzy.h
a pev-0.81/lib/libpe/libfuzzy/edit_dist.c
a pev-0.81/lib/libpe/include/libpe
a pev-0.81/lib/libpe/include/libpe/error.h
a pev-0.81/lib/libpe/include/libpe/utils.h
a pev-0.81/lib/libpe/include/libpe/utlist.h
a pev-0.81/lib/libpe/include/libpe/hdr_coff.h
a pev-0.81/lib/libpe/include/libpe/resources.h
a pev-0.81/lib/libpe/include/libpe/hdr_optional.h
a pev-0.81/lib/libpe/include/libpe/sections.h
a pev-0.81/lib/libpe/include/libpe/exports.h
a pev-0.81/lib/libpe/include/libpe/dir_import.h
a pev-0.81/lib/libpe/include/libpe/hdr_dos.h
a pev-0.81/lib/libpe/include/libpe/hashes.h
a pev-0.81/lib/libpe/include/libpe/imports.h
a pev-0.81/lib/libpe/include/libpe/ordlookup.h
a pev-0.81/lib/libpe/include/libpe/pe.h
a pev-0.81/lib/libpe/include/libpe/dir_resources.h
a pev-0.81/lib/libpe/include/libpe/macros.h
a pev-0.81/lib/libpe/include/libpe/directories.h
a pev-0.81/lib/libpe/include/libpe/dir_security.h
a pev-0.81/tests/test_build.sh
a pev-0.81/tests/valgrind_pedis.sh
a pev-0.81/tests/valgrind_readpe.sh
a pev-0.81/tests/valgrind_pepack.sh
a pev-0.81/tests/run.sh
a pev-0.81/tests/valgrind_pesec.sh
a pev-0.81/include/compat
a pev-0.81/include/plugin.h
a pev-0.81/include/pev_api.h
a pev-0.81/include/config.h
a pev-0.81/include/output.h
a pev-0.81/include/common.h
a pev-0.81/include/stack.h
a pev-0.81/include/output_plugin.h
a pev-0.81/include/plugins.h
a pev-0.81/include/compat/strlcat.h
a pev-0.81/include/compat/sys
a pev-0.81/include/compat/sys/queue.h

Could you let us know if that helps?

Thanks,
Fernando

from readpe.

merces avatar merces commented on May 29, 2024

Wow. I really thought this underscore character was a typo or something. I have no idea on what's this. These files do not exist in my folder, neither in the tarball (according to my filesystem and default tools such as find and ls). Does the MD5 hash shown in SourceForge bb3498012134a2bed02cc28b94bc7754 match the downloaded file for you?

from readpe.

petterreinholdtsen avatar petterreinholdtsen commented on May 29, 2024

from readpe.

merces avatar merces commented on May 29, 2024

Perhaps try on a Linux machine?

Good idea. Just did that and updated the tarball. It should be normal now (MD5: 9800200f26adadf4812919ae02971476). Could you check please?

I'll investigate why macOS tar is doing this. :(

Thanks,
Fernando

from readpe.

merces avatar merces commented on May 29, 2024

Thanks, @petterreinholdtsen. By the way, we sent you an email regarding #136 (we believe it can be fixed at the package level). I appreciate if you can take a look.

from readpe.

petterreinholdtsen avatar petterreinholdtsen commented on May 29, 2024

from readpe.

merces avatar merces commented on May 29, 2024

I did not notice any email about #136, but took a look.

Thanks! We sent it to pere at hungry.com about 13h ago (I got it from a patch in pev package). Could you send me an email on nandu88 at gmail.com please? I'll delete this message afterwards. ;-)

from readpe.

merces avatar merces commented on May 29, 2024

Here's what we sent anyway:

Hi Petter,

We were working on issue #136 [1] of pev and I suspect we can fix this at the package level.

In the past we had set a fixed DEFAULT_PLUGINS_PATH to "/usr/local/lib/pev/plugins" and you correctly patched it changing it to /usr/lib/pev/plugins instead. This correctly fixes the problem of loading plugins but there is one more thing that depends on $prefix (set to /usr/local by default [2]) that is the SHAREDIR definition used by pepack.c [2]. As this was not patched, pepack still tries to read /usr/local/lib/pev/userdb.txt but it fails as the file is installed at /usr/lib/pev/userdb.txt instead.

In v0.81 we fixed config.c and it now uses the prefix set in $prefix, so we believe the following patch is not needed anymore:

$ cat 01-plugins-path.patch
Description: Correct path to plugins.
Author: Petter Reinholdtsen 
Forwarded: no
Reviewed-By: Petter Reinholdtsen 
Last-Update: 2017-07-04

--- pev-0.80.orig/src/config.c
+++ pev-0.80/src/config.c
@@ -55,7 +55,7 @@
 #define DEFAULT_PLUGINS_PATH "plugins"
 #else
 #define DEFAULT_CONFIG_PATH ".config/pev" DEFAULT_CONFIG_FILENAME
-#define DEFAULT_PLUGINS_PATH "/usr/local/lib/pev/plugins"
+#define DEFAULT_PLUGINS_PATH "/usr/lib/pev/plugins"
 #endif

 static bool _load_config_cb(pev_config_t * const config, const char *name, const char *value) {

If we remove it and your package set the $prefix to /usr, we believe everything will be fine. Would you give your opinion - and possibly help - here?

Thanks in advance.
Fernando

[1] https://github.com/merces/pev/issues/136
[2] https://www.gnu.org/prep/standards/html_node/Directory-Variables.html
[3] https://github.com/merces/pev/blob/master/src/pepack.c#L159

from readpe.

merces avatar merces commented on May 29, 2024

That's definitely a week of discoveries. Yeah, I used a gmail account. Thanks for everything, Peter!

from readpe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.