mearashadowfax / screwfast Goto Github PK

I'm currently working on adding automatic Open Graph image generation for collection pages, inspired by the approach detailed in this post.

My progress can be seen in the branch: feat/docs-og:

I would greatly appreciate any feedback or suggestions on this implementation. If this aligns with our project goals, I'm eager to continue refining this feature.

Issues:

• Sometime image aren't showing on every page. even on the screwfast.co.uk it self.
• Sharp installation are struggling (solved after i update node version to 20+)
• Learn more link on /guides/getting-started not going to right path/url.
  

Suggestion from me as newbie,

• Is this awesome Astro theme still working even without Sharp package? if it still running, can it removed from the code? because it impact on user experience when images wont to load.
• fix Learn more link / script.

I noticed the project's config is quite extensive, largely due to Starlight settings. What are your thoughts on extracting these into a separate starlight.config.mjs file for better readability and maintainability? If you're on board, I'd be happy to work on this adjustment.

.

Theme looks promising. Cloned repo (on Ubuntu 20.04 recently updated) and did npm install and got:

victor@victorpc:ScrewFast$ npm i

added 777 packages, and audited 778 packages in 6s

253 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
victor@victorpc:ScrewFast$ npm audit
# npm audit report

html-minifier  *
Severity: high
kangax html-minifier REDoS vulnerability - https://github.com/advisories/GHSA-pfq8-rq6v-vf5m
No fix available
node_modules/html-minifier

1 high severity vulnerability

Some issues need review, and may require choosing
a different dependency.

It says "no fix available" which is disconcerting.

First of all congrats and thank you for making such a beautiful theme. I am quite critical of everything and rarely praise but this is really good theme both in terms of looks and basic features(SEO) that are generally ignored by other themes.

Please list this theme in astro website, i accidentally discovered it.

Here are some enhancement suggestions to make it perfect for small business

• Add support for internationalization i18n is already supported in latest astro. This is not only for enabling this theme for people wanting to use it in other languages but also because adding internationalization at a later stage becomes difficult if support is not there.
• Add support to share blog articles on social media. This helps readers to share the content on other channels.
• Add support for toc on the side in blog article. For long articles navigating becomes difficult if toc is not present.
• Add support for docs. Docs and blog articles have slightly different navigation and features(search) and almost every saas requires docs page. Integrating it to this theme would make it one stop solution for all the things home/blog/docs.

I have to say this is a very beautiful theme, it almost meets all my needs. I would like to make a small suggestion, it would be better if the navbar's functions could be further enriched, such as supporting the display of this kind of panel. You might want to consider this.