mdole / combat-master Goto Github PK

Stop scrolling to top of the ActionScreen after selecting a new action. Likely caused by rerendering on select

Right now, our sizing is pretty hardcoded, which results in some things being cut off on some devices (e.g. the Finished button on the movement screen on Matt's phone)

We talked it over and we think it would make more sense to have a little popup that tells the user they might lose data if they navigate away

• Back icon is white on Android
• On the InputBonusAction screen, adding a new action and clicking "add" results in a TypeError: Invalid attempt to spread non-iterable instance. In order to be iterable, non-array objects must have a [Symbol.iterator]() method this appears to be fixed?? we can no longer replicate. Might have been solved by #40
• Some elements are moved around up/resized when the keyboard is onscreen:
  • "Save & return" on the profile screen
  • "Saved bonus actions" list on the input bonus actions screen
• Some buttons are semi-transparent and should be opaque:
  • "Enter a new bonus action" button on both profile & bonus action page
  • Diagonal/Orthogonal buttons on the move screen
  • Buttons on the action screen
  • "Add" button on input bonus action screen
• We have different strategies for the "Save & return" button on the input bonus action & profile screens. On the former, it hovers just below the content. On the latter, it's near the bottom of the screen.

woo styles wooo

One idea for increasing the usability of movement without increasing complexity too much: allow users to tap an arrow in one of 8 directions (orthogonal/diagonal) and show that direction in the list.

Seems like a good step towards an eventual grid-based, visual movement system

moar styles

When the movement log gets really full, things bleed past the edge and there's no way to view them. We should fix that!

APIs we looked at:
https://www.dnd5eapi.co/
https://open5e.com/

pick an icon for app

After reading https://www.nngroup.com/articles/form-design-placeholders/, seems like it would be prudent to have labels in our character settings form instead of just using placeholders

• fixing the top and bottom bumps on the action screen
• change load screen photo

Types for navigation!! This is probably what we want but it was p overwhelming right now https://reactnavigation.org/docs/typescript

When updated to Expo SDK 39, back arrow button no longer appears. The update also updated react-native-svg to v12.1.0: https://github.com/react-native-svg/react-native-svg/releases

We rolled the version back to previous (v11.0.1) in order to still have it work, but need to look into having this work in the newer react-native-svg.

(can we find/make a cool arrow, like the kind you shoot from a bow??)