mdmurbach / impedanceanalyzer Goto Github PK

1. Parameter names for Randles' w/ CPE need to be subscripted.
2. Fix units of the fit parameter in the explore physics modal

This looks fantastic. I was testing the install and I noticed in the README.md you have back ticks around an already reformatted string.

Selecting a fitting procedure requires user input to determine best guesses (equivalent circuit fitting) or additional parameters like cell capacity (physics-based fitting). Currently there is no checking on these inputs and the fitting will simply fail if a parameter is not provided or an aphysical choice is made.

Tests should be added and the user either warned or the analysis stopped with a useful error message.