mdirkse / i3ipc-go Goto Github PK

Currently Events only contain the "change" field, which is sometimes insufficient or inefficient to use.

For example, the window title change event already contains the new title of the current window, so it would make sense to expose that in the event directly. Otherwise we need extract the focussed window from the entire tree, which could be costly and also potentially add a race condition.

Or in the case of workspace change events, there is no way to get the previously selected workspace without keeping track of the current workspace by hand, which is error-prone and duplicate effort since the workspace change event already includes the "old" workspace.

It would be nice if the Event struct was expanded to add support for these other events (even as just a map[string]interface{}). Thoughts?

While it is nice to have a good test coverage, decreasing the coverage shouldn't fail the build.
It is an annotation but not a failure (the code still runs)

Only actual failures in the test suite should be considered a build failure.

Hi,

I also maintain a fork of the original proxypoke repo with a handful of my own updates plus a number of the original's never-accepted pull-requests that I merged in manually -- especially the tree_utils update from Anon1234.

I'd love to be able to drop my fork altogether and move to a more committed version but I have some dependencies on a few of those never-accepted PRs.

Is there a plan to merge those into this repo?