Git Product home page Git Product logo

areashop's Introduction

Hi there 👋

  • Computer Science student at Monash University
  • Football ("Soccer") | Chelsea
  • Currently learning JS/TS and C++
  • He/him

My GitHub stats
Languages

areashop's People

Contributors

androkai avatar austindart avatar cleonyc avatar dependabot[bot] avatar evilolaf avatar jewome62 avatar lenicdev avatar md5sha256 avatar nlthijs48 avatar o0sh4d0w0o avatar olzie-12 avatar pmme avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

areashop's Issues

PlaceholderAPI

Hello,
I want you to add PlaceholderAPI Support
So i can use something like %AreaShop_Player_Shop%, that gives the name of a player shop

Please add it :)

Please update into the future

Current behavior

The plugin does not start in MC 1.18.2

New behavior

That the plugin works under 1.18.2

Steps to reproduce (for bugs)

  1. Not a bug
  2. Fails to start during server restart under Paper

Your environment (for bugs)

  • Server platform (Bukkit, Spigot, etc.): Paper
  • Server version: [13:17:55 INFO]: This server is running Paper version git-Paper-258 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) (Git: 8897cea)
    You are running the latest version
    Previous version: git-Paper-241 (MC: 1.18.2)
  • AreaShop version: Version: 2.7.5-SNAPSHOT
    [13:16:52 INFO]: - Author(s): NLThijs48
    [13:16:52 INFO]: - Status: Disabled
  • WorldEdit version: - Version: 7.2.10-SNAPSHOT+6120-f50a81f
  • WorldGuard version: - Version: 7.0.6+1cff55f
  • Vault version: - Version: 1.7.3-b131

Your config files (for bugs)

config.zip

Minecraft sign edit overrides right click of a sign

Current behavior
When a player right clicks an areashop sign, the sign opens, since minecraft added the signedit directly into minecraft. This only happens, when an area is not owned. So if I own a region I can still right click the sign and e.g. expand the rent. I tried to disable signedit via script or plugin, but then still areashop doesn't recognize the click of the player.
Shift + rightclick still works fine, so I assume the signedit feature interrupts the functionality of areashop.

Expected behavior
Areashop should recognize the clicked sign and override the signedit function of minecraft.

Steps to reproduce

  1. Set a region, create an AS-region and link a sign
  2. Right click the sign
  3. The sign opens and you can edit the content
  4. No action of areashop is triggered, so the region can't be rented or bought.

Your environment

  • Server platform (Bukkit, Spigot, etc.): Paper
  • Server version: git-Paper-447 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 0052e2d)
  • AreaShop version: 2.7.17
  • WorldEdit version: FAWE 2.9.1;84f661d
  • WorldGuard version: 7.0.9+5934e49
  • Vault version: 1.7.3-b131

Your config files
https://www.dropbox.com/scl/fi/4061jnahzq6p8jvv6dbw3/PluginConfigs.zip?rlkey=9m5tih4kb9f01zu5rcudr6a0t&dl=0

Unknown WE Version: 2.0.0-SNAPSHOT-57;64442a8

Current behavior

Most likely because i'm using FAWE, when you go to download it, hes got another 2.0 build for 1.18;
https://ci.athion.net/view/%20%20FastAsyncWorldEdit/job/FastAsyncWorldEdit/

[22:10:35] [Server thread/INFO]: [AreaShop] Enabling AreaShop v2.7.1
[22:10:35] [Server thread/ERROR]: Error occurred while enabling AreaShop v2.7.1 (Is it up to date?)
java.lang.IllegalStateException: Unknown WE Version: 2.0.0-SNAPSHOT-57;64442a8
	at me.wiefferink.areashop.AreaShop.onEnable(AreaShop.java:210) ~[AreaShop-2.7.2.jar:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[purpur-api-1.18.1-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:370) ~[purpur-api-1.18.1-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:500) ~[purpur-api-1.18.1-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.v1_18_R1.CraftServer.enablePlugin(CraftServer.java:564) ~[purpur-1.18.1.jar:git-Purpur-1497]
	at org.bukkit.craftbukkit.v1_18_R1.CraftServer.enablePlugins(CraftServer.java:478) ~[purpur-1.18.1.jar:git-Purpur-1497]
	at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:732) ~[purpur-1.18.1.jar:git-Purpur-1497]
	at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:508) ~[purpur-1.18.1.jar:git-Purpur-1497]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:349) ~[purpur-1.18.1.jar:git-Purpur-1497]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1218) ~[purpur-1.18.1.jar:git-Purpur-1497]
	at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:322) ~[purpur-1.18.1.jar:git-Purpur-1497]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]
[22:10:35] [Server thread/INFO]: [AreaShop] Disabling AreaShop v2.7.1

Your environment

  • Server platform (Bukkit, Spigot, etc.): PurPur
  • Server version: PurPur 1.18.1
  • AreaShop version: AreaShop-2.7.2.jar
  • WorldEdit version: FAWE 2.0.0-SNAPSHOT-57;64442a8
  • WorldGuard version: 7.0.6
  • Vault version: 1.7.3-b131

Not able to implement AreaShop API inside my plugin

Current behavior
I want to add AreaShop as dependency to using the API using maven

I tried using jitpack but it failed

Here is my pom.xml implementation

    <repositories>
        <repository>
            <id>jitpack.io</id>
            <url>https://jitpack.io</url>
        </repository>
    </repositories>

    <dependencies>
        <dependency>
            <groupId>com.github.md5sha256</groupId>
            <artifactId>AreaShop</artifactId>
            <version>2.7.15</version>
            <scope>provided</scope>
        </dependency>
    </dependencies>

Here is what's happened :

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project {projectName}: Compilation failure: Compilation failure:
[ERROR] {projectPath}/src/main/java/fr/{pluginDir}.java:[12,41] package me.wiefferink.areashop.events.ask does not exist
[ERROR] {projectPath}/src/main/java/fr/{pluginDir}.java:[13,44] package me.wiefferink.areashop.events.notify does not exist
[ERROR] {projectPath}/src/main/java/fr/{pluginDir}.java:[14,44] package me.wiefferink.areashop.events.notify does not exist
[ERROR] {projectPath}/src/main/java/fr/{pluginDir}.java:[15,44] package me.wiefferink.areashop.events.notify does not exist
[ERROR] {projectPath}/src/main/java/fr/{pluginDir}.java:[224,30] cannot find symbol
[ERROR]   symbol:   class SoldRegionEvent
[ERROR]   location: class {pluginNamespace}.{pluginName}.{PluginName}
[ERROR] {projectPath}/src/main/java/fr/{pluginDir}.java:[252,32] cannot find symbol
[ERROR]   symbol:   class ResoldRegionEvent
[ERROR]   location: class {pluginNamespace}.{pluginName}.{PluginName}
[ERROR] {projectPath}/src/main/java/fr/{pluginDir}.java:[280,29] cannot find symbol
[ERROR]   symbol:   class BuyingRegionEvent
[ERROR]   location: class {pluginNamespace}.{pluginName}.{PluginName}
[ERROR] {projectPath}/src/main/java/fr/{pluginDir}.java:[309,33] cannot find symbol
[ERROR]   symbol:   class DeletedRegionEvent
[ERROR]   location: class {pluginNamespace}.{pluginName}.{PluginName}
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

I tried a second time by changing dependency by :

        <dependency>
            <groupId>com.github.md5sha256.AreaShop</groupId>
            <artifactId>areashop</artifactId>
            <version>2.7.15</version>
            <scope>provided</scope>
        </dependency>

But got this :

[ERROR] Failed to execute goal on project {projectName}: Could not resolve dependencies for project {pluginNamespace}:{pluginName}:jar:1.0.1: The following artifacts could not be resolved: com.github.md5sha256.AreaShop:areashop:jar:2.7.15 (absent), com.sk89q.worldedit:worldedit-core:jar:7.2.15 (absent), com.sk89q.worldedit:worldedit-bukkit:jar:7.2.15 (absent), com.sk89q.worldguard:worldguard-core:jar:7.0.9 (absent), com.sk89q.worldguard:worldguard-bukkit:jar:7.0.9 (absent), me.wiefferink:platform-interface:jar:2.7.15 (absent), me.wiefferink:paper:jar:2.7.15 (absent), me.wiefferink:bukkit-modern:jar:2.7.15 (absent): Could not find artifact com.github.md5sha256.AreaShop:areashop:jar:2.7.15 in jitpack.io (https://jitpack.io) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException

I tried by building it myself and storing it in my mavenLocalRepo it works fine

My plugin will not being executed on my own machine so i need to import it from a public repository to make my plugin usable outside a local environment without having to build a local maven repo.

Desired behavior
I would like have a solution to using the AreaShop api through a public repo.

Your environment

  • Server platform (Bukkit, Spigot, etc.): Paper
  • Server version: 1.20.2
  • AreaShop version: 2.7.15

Your config files
x

Problem with use

Current behavior
Been offgrid since NLThijs left the scene and incompatibility forced us to take this plugin down, finding your fork, it works as far as possible, but there are some things I don't understand:
Renting an area, kinda works, sometimes the OP has to go in and look at the specs from AS and WG.
The player rents an area and according to WG it can not do anything inside that area, what is going on here? Should AS not give permission to the rentee to construct what the player wants, and after that the restore functions resets everything?
Even if clicking on the sign to rent and then click to unrent, the area is restored to a previous build, not the beautiful nice work that was done aparently afterwards. The OP tried to change it in WG, by redefine the area, but that does not seem to work. Making the restore function to ' false' does not undo the rentee has done so, what is the right action here....

Desired behavior
Renting an area should give total permission to do everything within the given(rented or bought) area, it does not.
Simpler instructions needed to alter a 'to rent' and/or 'to buy' area to change so that restore does not revert to only the first makup.

Your environment

  • Server platform (Bukkit, Spigot, etc.):
  • Server version: [13:36:56 INFO]: Checking version, please wait...
    [13:36:56 INFO]: This server is running Paper version git-Paper-175 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 9490475)
    You are running the latest version
    Previous version: git-Paper-170 (MC: 1.18.1)
  • AreaShop version: [13:38:00 INFO]: AreaShop version 2.7.4
    [13:38:00 INFO]: Selling and renting WorldGuard regions to your players, highly configurable.
    [13:38:00 INFO]: Website: https://github.com/md5s256/AreaShop
    [13:38:00 INFO]: Author: NLThijs48
  • WorldEdit version: [13:38:54 INFO]: WorldEdit version 7.2.9-SNAPSHOT+6034-92dfe5e
  • WorldGuard version: [13:39:18 INFO]: WorldGuard version 7.0.6+1cff55f
  • Vault version: [13:39:50 INFO]: Vault version 1.7.3-b131
    [13:39:50 INFO]: Vault is a Permissions & Economy API to allow plugins to more easily hook into these systems without needing to hook each individual system themselves.
    [13:39:50 INFO]: Website: https://dev.bukkit.org/projects/vault
    [13:39:50 INFO]: Authors: cereal, Sleaker and mung3r

Your config files

AS-WG.zip

Bug with the signs

Current behavior
Somebody already reported this bug a while back, but its still seems to be persistent in the new version (2.7.13).
After server restart, areashop 'looses' all assigned region signs.

Also areashop send warnings while server shutdown for regions not having a owner, but that seems to be a diffrent issue.

Steps to reproduce

  1. Create a region in WG
  2. Register the region in areashop as [buy]
  3. Save and restart the server.

Your environment

  • Paper 1.20.1-169
  • Java 17
  • AreaShop-2.7.13
  • WorldEdit 7.2.15
    * WorldGuard 7.0.9
  • Vault 1.7.3-b131

Your config files

  • used the default setup, no config changes

Small question regarding the plugin

I hate to leave this as an issue but I couldn't find a way to contact the developers.

Let's say I have a large world guard region over a city, and I want a small building in the city to be rentable. I set a region inside the bigger region of the city around the small building, and I make that rentable. Will the player who rents it still be able to build inside that small region despite the rules of the larger region?

Bug with the oak_signs

Current behavior

When configuring a sign with /as addsign or sign ( [asbuy] ...) it is configured correctly and the commands work but when the server is restarted the signs stop working, I have noticed that only those for sale, the signs for rent work well and are not deconfigured
No error occurs

Expected behavior

don't misconfigure the signs jaja

Steps to reproduce

  1. set the dungeon region with worldguard
  2. I put up a sign and place to sell ([asbuy])
  3. I see that it was configured correctly buying and selling the region
  4. I restart the server
  5. the sign magically deconfigures and no longer lets me buy the region

Your environment

  • Server platform (Bukkit, Spigot, etc.): Paper
  • Server version: git-Paper-545 (MC: 1.19.4)
  • AreaShop version: 2.7.12
  • WorldEdit version: 7.2.14+6360-094b734
  • WorldGuard version: 7.0.8+33cdb4a
  • Vault version: 1.7.3-b131

Your config files

archive-2023-06-22T022223-0400.zip

PurPur 1.18.1 - java.lang.ClassNotFoundException: me.wiefferink.areashop.nms.v1_18_R1.NMSImpl

Current behaviour

Ahoy, currently does not boot on PurPur 1.18.1.

[09:55:49] [Server thread/INFO]: [AreaShop] Enabling AreaShop v2.7.0-SNAPSHOT
[09:55:49] [Server thread/WARN]: java.lang.ClassNotFoundException: me.wiefferink.areashop.nms.v1_18_R1.NMSImpl
[09:55:49] [Server thread/WARN]: 	at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:153)
[09:55:49] [Server thread/WARN]: 	at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:105)
[09:55:49] [Server thread/WARN]: 	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
[09:55:49] [Server thread/WARN]: 	at java.base/java.lang.Class.forName0(Native Method)
[09:55:49] [Server thread/WARN]: 	at java.base/java.lang.Class.forName(Class.java:375)
[09:55:49] [Server thread/WARN]: 	at AreaShop-2.7.0-SNAPSHOT.jar//me.wiefferink.areashop.AreaShop.onEnable(AreaShop.java:177)
[09:55:49] [Server thread/WARN]: 	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264)
[09:55:49] [Server thread/WARN]: 	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:370)
[09:55:49] [Server thread/WARN]: 	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:500)
[09:55:49] [Server thread/WARN]: 	at org.bukkit.craftbukkit.v1_18_R1.CraftServer.enablePlugin(CraftServer.java:564)
[09:55:49] [Server thread/WARN]: 	at org.bukkit.craftbukkit.v1_18_R1.CraftServer.enablePlugins(CraftServer.java:478)
[09:55:49] [Server thread/WARN]: 	at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:732)
[09:55:49] [Server thread/WARN]: 	at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:508)
[09:55:49] [Server thread/WARN]: 	at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:349)
[09:55:49] [Server thread/WARN]: 	at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1218)
[09:55:49] [Server thread/WARN]: 	at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:322)
[09:55:49] [Server thread/WARN]: 	at java.base/java.lang.Thread.run(Thread.java:833)
[09:55:49] [Server thread/ERROR]: [AreaShop] Failed to initialize NMS implementation!
[09:55:49] [Server thread/INFO]: [AreaShop] Disabling AreaShop v2.7.0-SNAPSHOT

Your environment

  • Server platform (Bukkit, Spigot, etc.):
  • Server version:
  • AreaShop version: AreaShop-2.7.0-SNAPSHOT.
  • WorldEdit version: FastAsyncWorldEdit version 2.0.0-SNAPSHOT-57;64442a8
  • WorldGuard version: WorldGuard version 7.0.6+1cff55f
  • Vault version: Vault version 1.7.3-b131

schematic creation fails

Hey there,

Current behavior

[10:03:26 INFO]: Olaf issued server command: /as add rent shop2
[10:03:26 WARN]: [FastAsyncWorldEdit] Plugin FastAsyncWorldEdit v2.0.2-SNAPSHOT-116;fb66ba6 generated an exception while executing task 4957
com.fastasyncworldedit.core.internal.exception.FaweException: Too many block checks

Expected behavior
It should create the schematic I guess.

Steps to reproduce

  1. enableRestore: true
  2. start server
  3. Create a WorldGuard region
  4. try adding it as rented
  5. check console for error

Your environment

  • Server platform (Bukkit, Spigot, etc.): Paper
  • Server version: Paper snapshot 235, implementing 1.18.2
  • AreaShop version: dev/bleeding including e64e884
  • WorldEdit version: FAWE snapshot 116
  • WorldGuard version: snapshot 2185
  • Vault version: https://github.com/danielk42/Vault

Your config files
Unchanged except enableRestore: true in default.yml

Cheers

unrented event not returning placeholders

Current behavior

When I unrent an area, the placeholders (player/uuid) set in the event for unrented return the text < UNKOWN>
NOTE: I have had to add a space in front of the Text UNKOWN

Expected behavior

it would work like the Rented Event or Extended event.

if I have the command line
"Say Hi %player%"
server message would be
Hi 1Namor

Steps to reproduce

  1. edit the default.yml lines
    unrented:
    before:
    after:
    - "say Hi %player%"
  2. In game unrent the area

server message will be

"Hi < UNKOWN>"

The Rent and Extended events will both return
"Hi Namor"

Your environment

  • Server platform (Bukkit, Spigot, etc.): Paper
  • Server version: 386
  • AreaShop version: 2.7.7 (bug also exists in 2.76)
  • WorldEdit version: 7.2.10
  • WorldGuard version: 7.0.6
  • Vault version: 1.7.3--b131

Your config files

Config.zip

chat formatting bugs.

chatPrefix:

  • '&f&lMoti&a&lMaa'
    Will bee MotiMaa ingame. The second part wont be bold

Server is crashing while adding offline players to a region

Current behavior

We have like 300 regions with AreaShop implemented and if i add a offline player to my region, the server is lagging. Same if i set a offline player as owner for a shop.

Crash log: https://pastebin.com/raw/1wHHaPMy

Expected behavior

Server is not lagging

Steps to reproduce

  • /as addfriend (Offline Player)
  • /as setowner (Offline Player)

Your environment

  • Server platform (Bukkit, Spigot, etc.): Paper
  • Server version: MC 1.19 (git-Paper-81)
  • AreaShop version: 2.7.8
  • WorldEdit version: 7.2.11
  • WorldGuard version: 7.0.8
  • Vault version: 1.7.3

Your config files

https://workupload.com/file/r2WDMA3Pk8w (for security reasons only 1 download possible)

Paper 1.20 compatibility

Hi there friend, can you add compatibility with Paper 1.20.2 please?

I have migrated from Spigot 1.20.1 and AreaShop doesnt work.
Greetings friend!

/as transfer <region> <player>

Describe the problem you are trying to solve with this feature request

Players have no way to transfer plots directly beyond /as resell 0, which opens the possibility for someone to snipe and buy plots

Describe the solution you'd like

Introduction of a transfer command

/as unrent FAWE crashes server, breaks bootup and duplicates money.

Current behavior
With FAWE 2.0.1 when a player uses /as unrent it crashes the server, this is a snippet of about 100 occurrences.
https://gist.github.com/TomLewis/b89c644c77dba52dc32b04e5247b88a2

Which in turn restarts the server, and it also breaks boot startup!
https://gist.github.com/TomLewis/f4658c4a9cb7fff788b2caf06096340a

It also paid the user the FULL amount of money for unrenting even tho its suppose to be a percent, so there's 2 issues here too:

  1. Its not paying a percentage back
  2. the payment back is happening before the regions been restored/unrented.

Another issue I saw is that you havent updated the /ver areashop
I have 2.7.3 jar on the server but /ver areashop shows 2.7.2

I backdatedto normal WorldEdit and it resolved the bootup issue.

Your environment

  • Server version: PurPur 1.18.1 1506
  • AreaShop version: 2.7.3
  • WorldEdit version: FastAsyncWorldEdit-Bukkit-2.0.1-SNAPSHOT-68
  • WorldGuard version: 7.0.6
  • Vault version: 1.7.3

Make notice of update redirect path

Describe the problem you are trying to solve with this feature request

I got a message from the plugin saying that I needed to update Areashop v.2.7.5 snapshot to v.2.7.5, I would like to, but on github there is only the snapshot version, and the message tells us to go to NLThijs' Spigot page, and as I do remember you telling me that is not your goal to put the plugin on.

Describe the solution you'd like

Maybe a message from the plugin to a direct link on github then?

That's all. Thanks...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.