mclear-tools / citar-capf Goto Github PK

I'm not sure how you want to clarify this, or I would submit a tiny PR, but note:

1. As I use it in citar, parsebib parses bibtex, biblatex and csl json files.
2. It can be multiple files.

Picking up where we earlier left off, in the hopes I can get this working, or it might help with the README instructions.

I do plan to test it with emacs -Q; I just need more time (maybe tomorrow).

If I add your use-package example, suitably modified for doom ...

Org

Value of completion-at-point-functions:

Its value is (pcomplete-completions-at-point t)
Local in buffer test.org; global value is 
(tags-completion-at-point-function citar-capf)

I do get corfu to activate with the citar completion. But if I hit RET on a candidate, it does not insert the key, but instead adds a newline to the buffer.

Aside: with the private doom corfu module I'm using, for other capfs (for example, in lisp buffers), when I highlight a candidate, it presents a preview, and when I hit RET it behaves as expected (inserts the candidate).

LaTeX

Its value is (TeX--completion-at-point t)
Local in buffer test.tex; global value is 
(tags-completion-at-point-function citar-capf)

Here I get no matches.

Markdown

No matches.

Its value is (citar-capf t)
Local in buffer test.md; global value is 
(tags-completion-at-point-function citar-capf)

Any suggestions? Is that setup as you expect with the variable?

The advantage of the Capf API is that it doesn't incur dependencies, so it could go directly into Citar. Is the provided functionality controversial such that @bdarcus prefers to have it in a separate package? If not, having this inside Citar will be advantageous:

• User friendliness.
• Less work for the MELPA/ELPA maintainers.
• Easier to maintain for the Citar maintainers and you, since everything will be updated in sync.
• Better coordination with other Citar features.

Generally I am all for a modularized package ecosystem where it makes sense. But sometimes packages are too fine grained as it seems to be the case here.