mclear-tools / bespoke-themes Goto Github PK

Currently, isearch face only sets the foreground to #bc85cf. I find this hard to spot visually, especially because that color is already used for font-lock-string-face. I suggest adding a background.

Just thought I'd ask if you could include these, to match the ivy ones.

Modus has support for both:

https://github.com/protesilaos/modus-themes/blob/main/modus-themes.el

Also, more generally, though I'm unfamiliar with the details, see the modus-themes-completions defcustom, which seems like it might be useful:

https://github.com/protesilaos/modus-themes/blob/main/modus-themes.el#L2466

Hi there, thanks for the great theme. Whenever I use helm, the highlighted selection is clear gray hence barely visible in 'light. Any idea how to change that ? The blue color that is used for the highlighted in smex would be fine.

Also, how can we add a gray background to org-block equation ? Sorry if those are basic question, I still new to theming in emacs.

Hey guys, is there a way to use the bespoke modeline with my config? I do like the style, its very minimal and cool -> good job on the theme.

Cannot load manually with use-package

(use-package bespoke-themes
    :load-path "~/.emacs.d/themes/bespoke-themes"
    :init (add-to-list 'custom-theme-load-path "~/.emacs.d/themes/bespoke-themes")
    :config
    (setq bespoke-set-mode-line 'header)
    ;; Set mode line height
    (setq bespoke-set-mode-line-height 3)
    ;; Set evil cursor colors
    (setq bespoke-set-evil-cursors t)
    ;; Use mode line visual bell
    (setq bespoke-set-visual-bell t)
    ;; Set use of italics
    (setq bespoke-set-italic-comments t
          bespoke-set-italic-keywords t)
    ;; Set variable pitch
    (setq bespoke-set-variable-pitch t)
    ;; Set initial theme variant
    (setq bespoke-set-theme 'light)
    ;; Load theme
    (load-theme 'bespoke t))

It complains

Error (use-package): bespoke-themes/:config: Wrong type argument: stringp, bespoke-faded Disable showing Disable logging

I already posted this under your reddit thread.
I got a little bit confused which is why held up reporting, since I introduced a fix myself but still got other problems.
The first thing that actually happens when I load bespoke-themes with the declaration in the manual is this

Warning (comp): bespoke-themes.el:67:11: Warning: Package cl is deprecated Disable showing Disable logging
Warning (comp): /home/flo/.emacs.d/straight/build/bespoke-themes/bespoke-themes.el: Error: Symbol's value as variable is void for 
Warning (comp): bespoke-light-theme.el:43:36: Warning: Package cl is deprecated 
Warning (comp): /home/flo/.emacs.d/straight/build/bespoke-themes/bespoke-light-theme.el: Error: Symbol's value as variable is void for 
Warning (comp): bespoke-dark-theme.el:43:36: Warning: Package cl is deprecated 
Warning (comp): /home/flo/.emacs.d/straight/build/bespoke-themes/bespoke-dark-theme.el: Error: Symbol's value as variable is void for 

Afterwards any input will just repeat Symbol's value as variable is void for .
I don't know if this is anyhow related with issue #4, but just adding (eval-when-compile (require 'cl-lib)) at the top of bespoke-themes.el will resolve the problem.

Right now mode line themeing isn't loading properly for footer position. I need to make some changes to the way faces are loading in the mode-line compose function.

Hello, I tried to fix some issues in the code while I was trying out this theme.

This repository is relatively large (~ several mega bytes) because of screenshots in the repository. I'd recommend compressing the images using optipng or taking SVG screenshots instead.

By compressing the entire screenshots directory using optipng (-o5), you can reduce the size from 5.4M to 3.3M:

optipng -o5 dark-agenda.png

It is also possible to take SVG screenshots using x-export-frames function (see this reddit thread).

Even if you replace the images with a compressed version, the older version will still remain in the history, so it won't save bandwidth of normal clones (and actually increases the entire repository size). However, shallow clones (--depth=1) and partial clones (--filter=blob:none) will take advantage of the change, which will be important once you publish these themes to MELPA or somewhere. I hope you will consider it.