mcci-catena / mcci_tweetnacl Goto Github PK

Although it's "elegant" to switch to bool for results, it's also confusing when looking at other code that uses tweetnacl or nacl. So... sadly, we want to just use the return values, for reliability.

However, we'll add a symbolic type mcci_tweetnacl_result_t to be used instead of raw int; and we'll add a new API mcci_tweetnacl_result_is_success() which effectively will convert a mcci_tweetnacl_result_t to boolean. It's verbose, but arguably better for casual users.

For hashing in multiple steps, we provide wrapper functions. The _finish() function, however, depends on the input pointer being such that msg + n - (n % 128) will point to the last few bytes; and requires that n be the initial length of the message. This is really awkward to arrange if you don't have the message sitting in a buffer. The solution is to require the user to pass in the overall length when finishing.