maxrodrigo / tumblr-html5-blank-theme Goto Github PK

The chat posts in this theme are made of <dialog> elements, which according to the HTML spec represent modal UI components (not conversations!). Using <dt> and <dd> also stretches the semantics as these usually represent glossary terms. A list or a table is probably a better idea, like this:

{block:Chat}
<article class="post chat">
  {block:Title}
  <header>
    <h2>{Title}</h2>
  </header>
  {/block:Title}
  <table>
    {block:Lines}
    <tr>
      <th class="{Alt} {UserNumber}">{block:Label}{Label}{/block:Label}</th>
      <td>{Line}</td>
    </tr>
    {/block:Lines}
  </table>
{/block:Chat}

The code currently wraps site description and text post content in paragraphs.

<p>
  {Body}
</p>

However, both of these can contain html elements that are not allowed within paragraphs. Text posts are usually already separated in paragraphs. The HTML specification states that a paragraph automatically ends when another one starts, which means nested paragraphs will be interpreted as this:

<p>
  </p><p>Lorem ipsum dolor sit amet.</p><p>Morbi non sapien dictum</p>
</p>

Which adds a useless whitespace paragraph before the content. It is also invalid HTML as there is an unmatched closing tag at the end, which Chrome turns into an empty paragraph. The paragraphs should simply be removed, or replaced with divs for styling purposes.