Git Product home page Git Product logo

Comments (5)

maxmx avatar maxmx commented on May 24, 2024

We merged a breaking change in bootstrap stylus before releasing 4.0.0. Version was upgraded to 4.0.0 to support semver as not to break the implementation of all existing codebases that were using bs-stylus.

It also happenned numerous times in the past where we would release a matching version of Bootstrap, then it would contain bugs, this meant deleting the release and re-releasing it, which is bad practices as in theory it could mean that two different computers that run a project using BS Stylus, could have two different version of the library is one has npm-installed after a breaking-tag delete and re-release.

Hopefully that makes enough sense.

You can see the discussion in #72 if you are curious.

from bootstrap-stylus.

gastonelhordoy avatar gastonelhordoy commented on May 24, 2024

Thanks for the clarification! What if you add a VERY short changelog file and link it from the README? in that way these things stay documented for everyone to easily see them.

from bootstrap-stylus.

gastonelhordoy avatar gastonelhordoy commented on May 24, 2024

BTW, why not creating 3.1.1.1 and 3.1.1.2 releases like in previous cases as well? I'm just wondering what are you gonna do when BS 4 comes out?

from bootstrap-stylus.

maxmx avatar maxmx commented on May 24, 2024

Right makes sense.

as for x.x.x.x versions I stoped doing it because of:

#53

For the second part of you question, you can see this repo as : Boostrap 3.3.1 for Stylus, then someday it will be Bootstrap 4.0.0 for Stylus, the internal version is not important.

The release version is hard to match with the official version as explained in the example scenario I gave.

Lets say you are working and using 3.3.1 on your computer at the office.
Then we do a breaking change on 3.3.1 while trying to fix a bug.
We re-release 3.3.1 because we want to be on the version version as Bootstrap official.

When you get home a few days later and you did not realize that 3.3.1 was re-released, and you checkout your project on your home computer and then do npm install and for some reason nothing works because the release is currently bugged because it managed to pass our code-reviewing eyes, you wont be really happy.

Same goes for why I ended up bumping the version from 3.3.1 to 4 because I realized that if I re-released version 3.3.1 with the included breaking changes (a folder was moved/renamed) every user out there using the library would have had some work, however minor it is to do to make their project work again.

The semver system, if followed guarantees that no breaking changes will be introduced in a minor or patch version. Hence why I bumped the major version.

Hope this answers everything!

from bootstrap-stylus.

gastonelhordoy avatar gastonelhordoy commented on May 24, 2024

Gotcha, I didn't understand why semver would be broken adding a fourth digit. I get now it is just because of the idea behind major, minor and patch version numbers.
Thanks for the clarification!

from bootstrap-stylus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.