Conflicting module names about bootstrap-stylus HOT 9 CLOSED

@maxmx and @kane-c: any thoughts here?

from bootstrap-stylus.

This isn't like in sass where the root directory would have been added to the path. Unless I'm mistaken I think all the imports in the index.styl are relative no?

from bootstrap-stylus.

I believe that to be partially incorrect.

Assume the following example path:
somePath/mixins.styl

somePath is included or set as a "paths" value via the JS API (https://learnboost.github.io/stylus/docs/js.html#includepath). When bootstrap-stylus index.styl imports mixins, it would instead import somePath/mixins.styl.

If somePath directory was not included or set as a "paths" value then the mixins.styl relative to index.styl would load.

from bootstrap-stylus.

Right, makes sense.

You can submit a PR, I'll bump the major version since that kind of change would break all current usage of the library.

from bootstrap-stylus.

@maxmx I've already submitted a PR. :D #106

from bootstrap-stylus.

@maxmx Anything I can do to move this along?

from bootstrap-stylus.

Done, just had to test it locally first.

from bootstrap-stylus.

Thank for the PR!

from bootstrap-stylus.

@maxmx no no, thank you!

from bootstrap-stylus.