maxmarsc / audeye Goto Github PK

error[E0283]: type annotations needed
  --> src/render/renderer.rs:84:10
   |
84 |         .constraints(constraints.as_ref())
   |          ^^^^^^^^^^^             ------ type must be known at this point
   |          |
   |          cannot infer type of the type parameter `C` declared on the method `constraints`
   |
   = note: multiple `impl`s satisfying `Vec<Constraint>: AsRef<_>` found in the `alloc` crate:
           - impl<T, A> AsRef<Vec<T, A>> for Vec<T, A>
             where A: Allocator;
           - impl<T, A> AsRef<[T]> for Vec<T, A>
             where A: Allocator;
help: consider specifying the generic argument
   |
84 |         .constraints::<&T>(constraints.as_ref())
   |                     ++++++

On rustc 1.70.0 it builds

Hello,

First off, incredible project; this is just what i wanted; a simple cli waveform viewer. i get tired of opening and closing audacity over and over just to see what a waveform looks like, etc.

One minor issue is that this is harder to build on e.g., macos, etc., due to dependency on libsoundfile.

While not as robust, symphonia (https://github.com/pdeljanov/Symphonia/blob/master/symphonia/examples/getting-started.rs) may get you to a most of the way there pure to a rust solution. I suspect they will do a new release soon, which has even more codecs and containers, etc.

Anyway, thanks for the great project! also, one last thing, you're missing 4 channel containers, and there is a minor typo; simple patch is here:

--- a/src/render/metadata.rs
+++ b/src/render/metadata.rs
@@ -80,7 +80,8 @@ fn channel_layout_to_string(channels: usize) -> String {
     match channels {
         1 => "mono",
         2 => "stereo",
-        3 => "ambinosic 2.1",
+        3 => "ambisonic 2.1",
+        4 => "quadrophonic",
         5 => "ambisonic 5",
         6 => "ambisonic 5.1",
         7 => "ambisonic 7",

Hiya @maxmarsc just a heads up that we've bumped to 0.4 track in audiotags :)

Cheers