Git Product home page Git Product logo

gemuo's People

Contributors

maxkellermann avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

gemuo's Issues

Error on login on ServUO

Hi, first of all really nice project! is what i looking for!

I'm trying to connect to my RunUO local instance, but the client doesn't go on after have selected the server (i this is the RelayPacket) and i don't understand why.

You can help me?

Login doesn't work

Python 3.8.5, twisted 21.2.0, twisted installed in virtualenv

2021-04-30 18:48:37,971 -   File "/home/jack/projects/GemUO/src/gemuo/client.py", line 160, in on_connect
2021-04-30 18:48:37,971 -     e = AccountLogin(client, username, password, character, connect).deferred
2021-04-30 18:48:37,972 -   File "/home/jack/projects/GemUO/src/gemuo/client.py", line 127, in __init__
2021-04-30 18:48:37,972 -     client.send(p.AccountLogin(username, password))
2021-04-30 18:48:37,972 -   File "/home/jack/projects/GemUO/src/gemuo/client.py", line 84, in send
2021-04-30 18:48:37,972 -     self._client.send(data)
2021-04-30 18:48:37,973 -   File "/home/jack/projects/GemUO/src/uo/client.py", line 81, in send
2021-04-30 18:48:37,973 -     self.transport.write(data)
2021-04-30 18:48:37,974 -   File "/home/jack/.virtualenvs/gemuo/lib/python3.8/site-packages/twisted/internet/abstract.py", line 355, in write
2021-04-30 18:48:37,974 -     _dataMustBeBytes(data)
2021-04-30 18:48:37,975 -   File "/home/jack/.virtualenvs/gemuo/lib/python3.8/site-packages/twisted/internet/abstract.py", line 23, in _dataMustBeBytes
2021-04-30 18:48:37,975 -     raise TypeError("Data must be bytes")
2021-04-30 18:48:37,975 - builtins.TypeError: Data must be bytes

The result of the packet.finish() is returning a bytearray in this case and not bytes. Simplest solution (though I have no idea if there are any caveats) is to simply add to the return value of packet.finish()

        if isinstance(data, bytearray):
            return bytes(data)
        return data

This seems to work without issue, but I haven't really begun to look into much else except your example of running GemUO with the hiding script. Also had a fix a syntax error in src/gemuo/engine/training.py on line 255 in the on_system_message method.

I may make a PR later, still just having a gander at the project and considering if I can get much use out of it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.