maximeh / script.myepisodes Goto Github PK

View Code? Open in Web Editor NEW

10.0 10.0 5.0 225 KB

Kodi plugin for MyEpisodes.com

License: GNU General Public License v2.0

Python 100.00%

script.myepisodes's People

Contributors

Stargazers

Watchers

Forkers

huwylphi g-mos 1100101 djraw yoyoost

script.myepisodes's Issues

Make adding shows optional

Its better to give the user more control over what this addon does. Not everyone would like shows to be added to their account. It might be the wrong one (see #2) or simply just one episode and not a show you'd continue with.

Adding a switch "Automatically add shows" would be appreciated and probably not very hard to implement either.

Memory leak

Hello.

I just installed the 1.0.12 version on a fresh OpenELEC 3.2.4 RPi version.

I watched an entire episode and checked the MyEpisodes website but nothing was updated.

I checked the log and got two errors (one at the start of the episode and one at the end).

ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.AttributeError'>
                                            Error Contents: 'Player' object has no attribute '_playbackLock'
                                            Traceback (most recent call last):
                                              File "/storage/.xbmc/addons/script.myepisodes/default.py", line 109, in onPlayBackStarted
                                                self._setUp()
                                              File "/storage/.xbmc/addons/script.myepisodes/default.py", line 63, in _setUp
                                                self._playbackLock.set()
                                            AttributeError: 'Player' object has no attribute '_playbackLock'
                                            -->End of Python script error report<--

and

ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.AttributeError'>
                                            Error Contents: 'Player' object has no attribute '_lastPos'
                                            Traceback (most recent call last):
                                              File "/storage/.xbmc/addons/script.myepisodes/default.py", line 152, in onPlayBackEnded
                                                actual_percent = (self._lastPos/self._totalTime)*100
                                            AttributeError: 'Player' object has no attribute '_lastPos'
                                            -->End of Python script error report<--

Thanks for you help.
Thibault

TV show marked as seen when using YouTube

Watch a TV show, then use YouTube addons, at the end of that video, it will try to mark the previous TV show as seen.

Exception thrown in XBMC log

While looking at the logs to resolve a different problem I've found one with this addon/script:

17:14:40 T:4044   ERROR: EXCEPTION: access_voilation
17:14:40 T:4044   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.RuntimeError'>
                                            Error Contents: access_voilation
                                            Traceback (most recent call last):
                                              File "C:\Users\username\AppData\Roaming\XBMC\addons\script.myepisodes\default.py", line 10, in <module>
                                                __addon__         = xbmcaddon.Addon()
                                            RuntimeError: access_voilation
                                            -->End of Python script error report<--

Shows still auto-adding when setting disabled

Script v.1.0.9 from XBMC addon repo on Frodo v12.2

Setting to auto-add shows unchecked in plugin settings.

New/un-recognized shows still auto-add to MyEpisodes list.

Not changing watched status.

I installed the addon yesterday and it works partly; it does add shows to my account but it does not change the 'watched' status of any shows after I have watched them. Either new ones just added to the account or ones recognized and already there.

Not setting Watched status on first playthrough.

I'm afraid I'm back with an issue...

I've opened a new one cause I am not sure if it is related to the other one.

What's happening is that when I watch any show, the script runs and shows the title of the show if it recognizes it. But at the end, whether I use the stop button, let it run its course, or use seek to go to the end, it will just not update the Watched status. If I then open the same file again, use seek to go a number of minutes forward and then end it by any of the three ways above, it will correctly update the Watched status.

This has been happening with all shows I have been watching with the new version.

I've uploaded a Kodi log where I watch a show normally and then go through it fast: https://raw.githubusercontent.com/Laurvin/Temp/main/Log

Hope you can make sense of this.

Thanks!

Names with parentheses not marked

Shows that have parentheses in their name on Myepisodes but not in the show/filename on XMBC (e.g. Blabla (US) vs Blabla US) are not getting marked on MyEpisodes.

Not synchronising with myepisodes.com

Perhaps the website has changed since the last release, but when I run myepisodes 1.2.8 in Kodi 17.3 under Mac OS, or myepisodes 1.2.6 in Kodi 15.2 on Android (Amazon Firestick), neither version successfully creates shows nor marks episodes as being watched when they should.

There's a pop-up message saying the show was not found when watching a new episode.

Updates not submitting to MyEpisodes

Just downloaded & installed the 1.07 zip from github page, but it doesn't seem to be working. I'm getting the following error in xbmc.log :-

ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.AttributeError'>
                                            Error Contents: 'Player' object has no attribute '_playbackLock'
                                            Traceback (most recent call last):
                                              File "/storage/.xbmc/addons/script.myepisodes/default.py", line 150, in onPlayBackEnded
                                                self._tearDown()
                                              File "/storage/.xbmc/addons/script.myepisodes/default.py", line 67, in _tearDown
                                                if self._playbackLock:
                                            AttributeError: 'Player' object has no attribute '_playbackLock'

That was with standard "basic" logging - would a higher "debug" loglevel tell you anything more helpful ?

(XBMC Version 12.2 - Frodo)

"Marked as watched" stopped working some time ago

I've noticed that my shows are not marked as watched anymore.
I was running the latest version that could be installed via Kodi.
Now I've tried out the new 3.0.2 version but no difference.

Is that a known issue? At least one other person I know has the same issue.

Some shows with year parentheses not properly updated.

There are some seriels (eg. Scandal, Hawaii Five-0) that have a year value in only one of the two sides (Scandal in my side, HF0 in the myepisode side). Is it acceptable to completely discard the year value in the searches? If needed I can provide a code patch.

Not compatible with Kodi 19

Kodi 19 now use only Python 3. Maybe it's the source of the problem

URL format at myepisode.com

It seems that there are a few changes happening at myepisodes.com, including some URL format alterations that I suspect are now causing (my) installs of this add-on to fail. Everything was working fine till sometime during the past 24 hrs.

In a recent post (http://www.myepisodes.com/forum/viewtopic.php?p=9047#9047), myepisode.com founder "IceMan" makes mention of new "Pritty URLs".

I see the following error in Kodi's log file:

ERROR: EXCEPTION Thrown (PythonToCppException) : 
-->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.KeyError'>
Error Contents: ('showid',)
Traceback (most recent call last):
    File "C:\Users\ipott\AppData\Roaming\Kodi\addons\script.myepisodes\default.py", line 185, in <module>
        player = Player()
    File "C:\Users\ipott\AppData\Roaming\Kodi\addons\script.myepisodes\default.py", line 36, in __init__
        self.mye = self._loginMyEpisodes()
    File "C:\Users\ipott\AppData\Roaming\Kodi\addons\script.myepisodes\default.py", line 93, in _loginMyEpisodes
        if mye.is_logged and (not mye.get_show_list()):
    File "C:\Users\ipott\AppData\Roaming\Kodi\addons\script.myepisodes\resources\lib\myepisodes.py", line 82, in get_show_list
        showid = urlparse.parse_qs(link_url)['showid'][0]
KeyError: ('showid',)
-->End of Python script error report<--

From the traceback, it looks like the last call to urlparse.parse_qs(link_url)['showid'][0] fails because 'showid' does not appear in the URLs. I did not take note of the format of the URLs before now so I can't be certain that this is the reason, but it is my best guess. I filed a bug report on myepisode.com at http://www.myepisodes.com/forum/viewtopic.php?t=2917.

Thanks for the fantastic add-on. I greatly appreciate the time and effort you've chosen to graciously share.

Myepisodes addon conflicts with XBMC Subtitles addon

When I enable Myepisodes, the XBMC subtitles addon does not work. On a fresh XBMC setup, after enabling XBMC subtitles:

Enable and configure myepisodes addon.
Restart XBMC, myepisodes connects.
Play a movie or TV show.
Request the movie subtitle, subtitles screen doesn't show up
Stop the movie and a XBMC subtitles alert says movie must be playing for the addon to work, meaning that the subtitles addon is still running, not working though.
Disable Myepisodes addon.
Play a movie.
Request subtitle, subtitle addon shows its popup and works normally.

Regards

Updates not commiting to myepisodes

I have raspbian with XBMC. I installed the official addon but it doesn't work. Updated the default.py from here but also in vain. The error message in the log is the following:

ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.IndexError'>
                                            Error Contents: list index out of range
                                            Traceback (most recent call last):
                                              File "/home/gerassimos/.xbmc/addons/script.myepisodes/default.py", line 129, in onPlayBackStarted
                                                self.title, self.season, self.episode = self.mye.get_info(filename)
                                              File "/home/gerassimos/.xbmc/addons/script.myepisodes/resources/lib/myepisodes.py", line 134, in get_info
                                                return title, int(response_file[0][0]), int(response_file[0][1])
                                            IndexError: list index out of range
                                            -->End of Python script error report<--

and

ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.TypeError'>
                                            Error Contents: %d format: a number is required, not NoneType
                                            Traceback (most recent call last):
                                              File "/home/gerassimos/.xbmc/addons/script.myepisodes/default.py", line 151, in onPlayBackStopped
                                                self.onPlayBackEnded()
                                              File "/home/gerassimos/.xbmc/addons/script.myepisodes/default.py", line 164, in onPlayBackEnded
                                                if self.mye.set_episode_watched(self.showid, self.season, self.episode):
                                              File "/home/gerassimos/.xbmc/addons/script.myepisodes/resources/lib/myepisodes.py", line 149, in set_episode_watched
                                                show_id, season, episode)
                                            TypeError: %d format: a number is required, not NoneType
                                            -->End of Python script error report<--

Script Error in a Log File

Hi,

Wasn't sure the best way to raise this - I noticed that there was a script error in the Kodi log for an issue reported on the VideoExtras thread:

http://forum.kodi.tv/showthread.php?tid=214289&pid=1899185#pid1899185

I guess it is from this addon - so thought I'd just quickly post so you were aware of it

Thanks, Rob

Error with kodi

Hi, when I start Kodi (15) I get an error in log file:

08:30:00 T:5600 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.UnicodeDecodeError'>
Error Contents: 'ascii' codec can't decode byte 0xc5 in position 9: ordinal not in range(128)
Traceback (most recent call last):
File "C:\Users\£ukasz\AppData\Roaming\Kodi\addons\script.myepisodes\default.py", line 185, in
player = Player()
File "C:\Users\£ukasz\AppData\Roaming\Kodi\addons\script.myepisodes\default.py", line 36, in init
self.mye = self._loginMyEpisodes()
File "C:\Users\£ukasz\AppData\Roaming\Kodi\addons\script.myepisodes\default.py", line 91, in _loginMyEpisodes
notif(login_notif, time=2500)
File "C:\Users\£ukasz\AppData\Roaming\Kodi\addons\script.myepisodes\default.py", line 172, in notif
notif_msg = "%s, %s, %i, %s" % ('MyEpisodes', msg, time, icon)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc5 in position 9: ordinal not in range(128)
-->End of Python script error report<--

MyEpisodes picking up all videos played

Can you make this filter to only respond to tv-shows? Now when watching movies, or even videos under files, it scobbles the names, and tries to add it as a serie. Which is not good at all.
Edit, if you need logs I can provide it, but this should be simple enough to recreate.