maxgrosshandler / steak-knight Goto Github PK

Fairly self explanatory, sequelizePlayerDescription doesn't work that well for other items

server.js

• env vars should be all uppercase (process.env.WOLKE not process.env.wolke)
• fix bad formatting (ex https://github.com/MaxGrosshandler/Steak-Knight/blob/master/server.js#L50-L63 https://github.com/MaxGrosshandler/Steak-Knight/blob/master/server.js#L76-L114 etc)
• what the fuck is this shit https://github.com/MaxGrosshandler/Steak-Knight/blob/master/server.js#L118-L223 If you just wanted autoresponse you could do much better than this
• should connect to pg BEFORE starting the bot https://github.com/MaxGrosshandler/Steak-Knight/blob/master/server.js#L262
• should have consistent symbol case for exports https://github.com/MaxGrosshandler/Steak-Knight/blob/master/server.js#L286

bottle.js

• shouldn't do raw SQL queries if at all possible; use sequelize or knex or something
• fix formatting https://github.com/MaxGrosshandler/Steak-Knight/blob/master/commands/bottle.js#L5-L8 https://github.com/MaxGrosshandler/Steak-Knight/blob/master/commands/bottle.js#L96-L101 etc
• should probably use switch instead of a ton of if

clean.js

• may make more sense to check for manage messages than ban members
• should actually use {} on if/else/etc

currency.js

• same formatting and SQL wtfs as before

donate.js

• can avoid using {} on single-line functions like that since the => already makes it obvious

help.js

• why suddenly switch to 4-space indents?????
• check things like array length, not if undefined https://github.com/MaxGrosshandler/Steak-Knight/blob/master/commands/help.js#L18-L26

prefix.js

• formatting https://github.com/MaxGrosshandler/Steak-Knight/blob/master/commands/prefix.js#L22-L27

recipe.js

• may not want to embed app id https://github.com/MaxGrosshandler/Steak-Knight/blob/master/commands/recipe.js#L10

role.js

• make sure bot can't do things like add admin perms roles if someone does a bad hierarchy maybe?

steak.js

• why switch to 4-space indents???

support.js

• formatting aaaaaaaaaaaaaaaaaa

weeb.js

• formatting aaaaaaaaaaaaaaaaaaa