The airzoneclouddaikin from max13fr

feature - Add Mode 0 to constants

We have a Daikin Heat Reclaim Ventilation VAM unit, which is causing an error with the library. It has a mode of "0", which isn't in the constants /AirzoneCloudDaikin/contants.py

Error:

Traceback (most recent call last):
  File "./watch.py", line 14, in <module>
    api = AirzoneCloudDaikin(USER, PASS)
  File "/home/baylyj/.local/lib/python3.6/site-packages/AirzoneCloudDaikin/AirzoneCloudDaikin.py", line 45, in __init__
    self._load_installations()
  File "/home/baylyj/.local/lib/python3.6/site-packages/AirzoneCloudDaikin/AirzoneCloudDaikin.py", line 111, in _load_installations
    installation = Installation(self, installation_data)
  File "/home/baylyj/.local/lib/python3.6/site-packages/AirzoneCloudDaikin/Installation.py", line 24, in __init__
    self._load_devices()
  File "/home/baylyj/.local/lib/python3.6/site-packages/AirzoneCloudDaikin/Installation.py", line 115, in _load_devices
    device = Device(self._api, self, device_data)
  File "/home/baylyj/.local/lib/python3.6/site-packages/AirzoneCloudDaikin/Device.py", line 20, in __init__
    _LOGGER.info("Init {}".format(self.str_complete))
  File "/home/baylyj/.local/lib/python3.6/site-packages/AirzoneCloudDaikin/Device.py", line 37, in str_complete
    self.mode,
  File "/home/baylyj/.local/lib/python3.6/site-packages/AirzoneCloudDaikin/Device.py", line 80, in mode
    return MODES_CONVERTER[self.mode_raw]["name"]
KeyError: '0'

A simple solution would be to add a "None" mode:

 # 2020-05-23: extracted from website and saved copy in reverse/application.js
 
 MODES_CONVERTER = {
+    "0": {"name": "none", "type": "none", "description": "None"},
     "1": {"name": "cool", "type": "cold", "description": "Cooling mode"},
     "2": {"name": "heat", "type": "heat", "description": "Heating mode"},
     "3": {

warning in Home Assistant

Hi Max, could you fix this warning ? Thanks

Logger: homeassistant.loader
Source: loader.py:802
First occurred: 22:52:17 (1 occurrences)
Last logged: 22:52:17

No 'version' key in the manifest file for custom integration 'airzoneclouddaikin'. This will not be allowed in a future version of Home Assistant. Please report this to the maintainer of 'airzoneclouddaikin'

Version on pypi.org is not up-to-date

When installing from Python Package Index, the fix for #2 isn't included. I've also tried manually downloading the tar.gz file and confirmed that it doesn't include the changes made to constants.py, even though the source zip/tar.gz files available here on github do.

Could you bump the version on pypi.org please.

max13fr / airzoneclouddaikin Goto Github PK

airzoneclouddaikin's People

Contributors

Stargazers

Watchers

Forkers

airzoneclouddaikin's Issues

feature - Add Mode 0 to constants

warning in Home Assistant

Version on pypi.org is not up-to-date

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent