mattwyskiel / licenseskit Goto Github PK

What's the reason this pod is iOS8 only? Would it be a lot of work to enable iOS7 compatibilty?

Rob

Hi!
The library is really handy however I noticed that urls specified in the JSON result in links which open in Safari on iOS. If I am correct, this is not permitted by the App Store Guidelines (you can only use SafariViewController). Can you provide a solution to this?

Hello,

First of all, thanks a lot for this idea and your work on this lib. I'm really sure that it will help me a lot in a near future in order to centralize all the third party libs I use in my apps.

I'm just posting an issue here because I couldn't try your sample. When building I've got an error saying this: NoticesHtmlBuilder.swift:10:8: No such module 'StringBuilder'

I checked and indeed, there is no trace of StringBuilder in the archive.

Since my apps still need to manage iOS 7, I couldn't install it with cocoapods. Do you have any idea regarding this issue? (for your sample app, but also when including headers in iOS 7 projects)

Thanks a lot for your help!

Best regards,

K

Hello, I updated my Xcode to 10.2 and then try to run my Objective C project. And this error comes up:
SWIFT_VERSION '3.0' is unsupported, supported versions are: 4.0, 4.2, 5.0. (in target 'LicensesKit')

Did you fix it, or do you have workaround for this issue? Thanks a lot for your help!

Best regards,

Hi,

i figured out, that I'm not able to use the function "registerLicense" because there's no @obj in front it.

I guess it should be:

@objc public func registerLicense(license: License) {
    licenses.updateValue(license, forKey: license.name)
}

instead of

public func registerLicense(license: License) {
    licenses.updateValue(license, forKey: license.name)
}

I would really appreciate it, if you could fix this bug. Unfortunately I can't create an own Pull-Request because of the missing permissions.

Also the protocol "License" should have the @objc attribute I guess.

Thank you.

Sincerely yours,
Jens

Hey,
Apple seems to have deprecated UIWebView, because I received this email for my app submission:

Dear Developer,

We identified one or more issues with a recent delivery for your app, "ABCDE" 1.2.3 (456). Your delivery was successful, but you may wish to correct the following issues in your next delivery:

ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs starting from December 2020 . See https://developer.apple.com/documentation/uikit/uiwebview for more information.

After you’ve corrected the issues, you can upload a new binary to App Store Connect.

I searched my whole project and couldn't find any reference to UIWebView. The only location where I could find usage of "UIWebView" is in the sourcekitten docs of this project that I am using via Cocoapods. Can that be easily removed?

Hi! I would like to use your pod via CocoaPods but the last published version is 1.2.1 which is still in Swift 2. Please publish the latest version which is compatible with Swift 3. Thanks!

In License.swift method getContent is not able to access bundle as default argument.