Add option to rotation3dToEulerAngles to check if rotation matrix contains scaling or reflection? about matgeom HOT 4 CLOSED

Done in
240e9b4

from matgeom.

Hi,

I'm mitigated...
One problem is that one need to take care about rounding effect, and have some tolerance on the test.
Also it is the responsability of the programmer who call the function to ensure the call is valid.

Throwing a warning instead of an error sounds better to me.

from matgeom.

Ok, then I would add two parameter pairs in rotation3dToEulerAngles:
'IsRotation' - true by default: checks if it is pure rotation and throws a warning if not. If set to false, the test is omited.
'Tolerance' - what default value would you propose? eps*1e8 is used at the moment in isTransform3d. Should maybe depend on the class?

Kind regards

from matgeom.

yes, looks fine!
for the tolerance, I used to use a fixed value, usually 1e-8 or 1e-10. eps * 1e8 is fine as well.

from matgeom.