mattkrick / react-githubish-mentions Goto Github PK

can not click the item to selected

I noticed a problem with this component in combination with the react-portal-hoc. It seems that touch events are caught by react-portal-hoc which closes the menu before the click event handler on the menu item has a chance to fire.

Changing the portal invocation wrapping MentionMenu to not close on click fixes the behaviour on mobile devices. It obviously introduces other problems such as the menu not closing when the textarea loses focus.

export default portal({ clickToClose: false, escToClose: true })(MentionMenu);

I could try to fix this, but will probably also need to touch the portal-hoc code in order to do so.
That and the release of react 16 with the portal functionality makes me wonder if it is worth the effort.

In the README, passing in a custom component is labeled as a TODO item.

The weird thing is that the demo works fine 🤔

There is a demo link ?

https://github.com/Axosoft/react-githubish-mentions

Instead of following the cursor we'd like the mentions list to appear in a given div. Is there any way to do this?

Demo failed to run with error message:

Failed to compile
./src/examples/simple.js
Module not found: Can't resolve 'react-githubish-mentions' in '/Users/matthewchang/Documents/workspace_git/react-githubish-mentions/demo/src/examples'

I can fix adding the self-dependency but I have no right to pull request.