In function proxy_autoconfig_type() the logic of check bits is wrong causing detecting of proxy type to fail.

Was:

if (bytes[8] & (1 << 2)) == bytes[8]

Should be:

if (bytes[8] & (1 << 2)) == (1 << 2)

Same for the line where the 3rd bit is checked:

} else if (bytes[8] & (1 << 3)) == bytes[8] {

to

} else if (bytes[8] & (1 << 3)) == (1 << 3)

Used by RHEL-alikes it seems.

https://www.novell.com/support/kb/doc.php?id=7006845

This is tricky. Have to do DNS stuff, download and execute JS, etc. Some platforms may do this for us.

Some ideas looking at https://github.com/inejge/env_proxy:

• Improve tests
  • Synchronize env var access
  • Clear env vars between tests
  • More tests
• Add support for NO_PROXY=*
• Support space-separated domains
• Add support for ALL_PROXY
• Fall back to HTTP_PROXY, then ALL_PROXY, if value not found in <scheme>_PROXY

Hi I discovered something with library it doesn't support websocket protocol as valid scheme even I've filled all protocols and selected "Use same proxy server for all protocols" option in windows proxy settings menu. Url library parses the following wss address correctly but proxy_config library throws error for the Url

Reproduce code is like following

extern crate proxy_config;
extern crate url;


use url::Url;
use proxy_config::ProxyConfigError;


fn main() {
//    app::bootstrap::startup();
    let resolved_url = Url::parse(&"wss://echo.websocket.org").unwrap();
    println!("{}", resolved_url);
    match proxy_config::get_proxy_for_url(Url::parse(&"wss://echo.websocket.org").unwrap()) {
        Ok(proxy) => {
            println!("{}", proxy);
        }
        Err(ProxyConfigError::NoProxyNeededError) => {
            println!("No proxy needed for described URL");
        }

        Err(e) => {
            println!("Error getting proxy for  described URL {}", e);
        }
    }
}

Output:

wss://echo.websocket.org/
Error getting proxy for described URL no proxy found for scheme: 'wss'

Something like HTTP_PROXY=... FTP_PROXY=... NO_PROXY=...
May want to look at the kind of variables already in use for this.

Version 2 and 3 have different settings stuff. Could also maybe use https://developer.gnome.org/gio/stable/GProxyResolver.html

Read from config or use KProtocolManager::proxyForUrl()

Things that need improving:

• Expand readme with installation instructions, examples.
• Add examples of using this library with other libraries
  • Reqwest
  • Hyper
• Expand API docs

• Appveyor
• Travis

Have to use Java FFI, probably: https://developer.android.com/reference/android/net/Proxy.html

https://developer.apple.com/documentation/systemconfiguration/1517088-scdynamicstorecopyproxies

Most systems will have at least two ways of getting proxy info: Environment Variables and something else. We need to decide on a ranking for these methods. Probably also want to provide a mechanism for ignoring input from one source or another. A decent solution would just have each mechanism as a separate cargo feature. A user that wants to disable env config can just disable that feature. I don't think there's a need to do this at runtime.