mattiash / docker-pino-sample Goto Github PK

This is not necessarily an issue, just looking for some clarification on a few things based on my specific setup.

I'm using the node:12.18.0-alpine image and noticed that the entrypoint.sh script doesn't work, it produces the following error: "env: can't execute 'bash': No such file or directory"

Changing the header of the script to #!/bin/sh get it to execute the script, but it errors on L18: "bin/sh syntax error: unexpected redirection". Seems like the redirection on L18 of entrypoint.sh is a feature specifically available in bash and not in sh.

I'm curious what the > > is doing in this command - I've used single > in commands before when sending output of a script to a file for example, but haven't seen double with a space like this before...

node build/index.js > >(./node_modules/.bin/pino-pretty -t) &

I noticed that pino recommends here in their docs to use pipe | to offload the transport to a separate process from the main node app. Does < < redirection have the same effect, but additionally allow for catching of the SIGTERM and ability to pass it along to the node process?

I.e. i'm wondering if there would be any performance difference between this command:

node build/app.js | node build/utils/logTransport.js

and:

node build/app.js > >(node build/utils/logTransport.js) &
worker="$!"

Note: in the example above logTransport.js is a custom log formatter, doing a similar job to pino-pretty in the example in this repo.

@albertkang wrote in pinojs/pino#350 (comment)

@mattiash, using your solution if my node process exits, i.e., process.exit(1) - the entrypoint shell does not exit and I'm left with a container is still running. How can I change your script to exit the shell as well?