Git Product home page Git Product logo

Comments (7)

MatthieuDartiailh avatar MatthieuDartiailh commented on July 19, 2024

Thanks for pointing this issue. I will try to think about it. I would prefer a solution that would allow to treat all EXTENDED_ARG on the same footing. Ping me if I do not answer in a week.

from bytecode.

serhiy-storchaka avatar serhiy-storchaka commented on July 19, 2024

Not all EXTENDED_ARG 0 are useless. For example LOAD_CONST referring to the constant number 0x10000 has two EXTENDED_ARG prefixes, one of them with argument 0.

from bytecode.

MatthieuDartiailh avatar MatthieuDartiailh commented on July 19, 2024

Thanks for pointing this out @serhiy-storchaka. I will keep this in mind.

from bytecode.

MatthieuDartiailh avatar MatthieuDartiailh commented on July 19, 2024

@serhiy-storchaka I noticed that in some cases CPython can emit EXTENDED_ARG 0 for arguments that actually are not too large to fit in the following opcode argument. Could you point me at where this might be happening in CPython source ? To me it looks like a bug.

from bytecode.

serhiy-storchaka avatar serhiy-storchaka commented on July 19, 2024

The only place I have found in peephole.c. And it is even mentioned in a comment. This is not a bug, but just the lack of optimization of this rare case.

from bytecode.

MatthieuDartiailh avatar MatthieuDartiailh commented on July 19, 2024

OK, I wish I had known this could happen. Thanks for looking this up @serhiy-storchaka.

from bytecode.

SnoopyLane avatar SnoopyLane commented on July 19, 2024

@serhiy-storchaka yes but in this case it is a leading EXTENDED_ARG 0. The example you point out of EXTENDED_ARG 0 following an initial non-0 is already property handled.

from bytecode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.