matthewearl / kpirc Goto Github PK

The Settings window (IRC Client -> Settings) should reject invalid values. When an invalid value is entered (triggered by a text box modify, for example) a message should appear at the bottom of the window explaining why the value is invalid and for which field. The Apply and OK buttons should become greyed out.

To implement this the Input and Page nested classes should be moved into their own (public) classes. Input should have a validateValue(SettingValue) method which by default approves all values. The idea being that whoever extends SettingsEditor can also extend Input for settings that can take invalid values. Instantiations of this subclass should be used as Inputs in the SettingsEditor. The addPage() and add addInput() methods of SettingsEditor should be changed to just take a Page or Input respectively and add it to the appropriate list.

validateValue() should return a ValidationResult() (a new class) which either indicates failure with an error string (to be displayed in the Settings window) or success without an error string.

Verifiers for colour values shouldn't be necessary (the picker control cannot return invalid values). The current string settings (nick, user, real name) need verifiers to make sure that they conform to RFC 1459.

For example, when the "default background colour" setting is changed (IRC Client -> Settings -> Colours -> (Change) -> Ok) all text controls that use this variable should redraw.

Interested controls (in the above case text controls which use the default background colour) should register a setting path (e.g. "Irc.defaultBG") with a static method on Settings. They will be called back with a SettingValue when the value is changed.

The text box is given a large computed minimum width which can be greater than the window width, meaning part of the window is invisible.