Hi,
First off, Great plugin
have a question, hebrew is not supported, all i get when i try to put hebrew characters, the pic comes blank
is that something that can work?

• #56
• #50
• #49
• #46
• #53

When I execute the following command, only the first two words are inserted into the image.

/meme aliens first line. second line

However, if I execute /meme memes. memes everywhere, the result is as in read me. It also works with other or more words, but not with defined memes.

It would be nice to have the meme images collapsable like media embedded via a link in mattermost.

This is a feature request to make the plugin code and meme resources modular. Then server admins could add or edit memes any time without having to have them officially included via a PR, or set up a dev environment to recompile from a fork. The plugin could scan files on (re)activation, include valid ones, and log errors for invalid ones.

I also thought JSON metadata might be friendlier for this. Golang projects seem to use it fairly universally, it's more widely known, and has fewer pitfalls than YAML.

From 5.24 MM server has a slash command autocomplete functionality feature. An API can be found here
To implement the feature add AutocompleteData struct to the Command when registering a slash command.

Similar PRs:
For Todo plugin mattermost-community/mattermost-plugin-todo#69
For Agenda plugin mattermost-community/mattermost-plugin-agenda#40

when trying to create a meme in iOS using the standard keyboard, one would get this caracter: “, in stead of " caracter, causing the script to interprete /meme brian “some text“ as a text string ' “some text“ ', and thereby corresponding to /meme brian "“some" "text“" not creating the correct meme.
Suggestion : auto replace “ with " in all strings

Instead of having to remember all meme names, the user should be able to select the meme via a dropdown list in an interactive dialog. The dropdown list should only contain the "main" meme names, not the aliases. It's opened via /meme.

Everything is in the title, just did a fresh install (Mattermost & mattermost-plugin-memes) works like a charm on desktop & web, but I get blank posts from the mobile version.

Is not working in latest 5.10 version.

I am running Mattermost with the bridgebot Matterbridge. When I post gifs from Discord for example the show up fine on Mattermost. But this plugin sends only a text like this:

[success-kid](/plugins/memes/templates/success-kid.jpg?text=enables+memes+plugin&text=gets+all+the+people+to+switch+to+Mattermost)

Would it be possible to (also?) post a functional URL and let Mattermost handle the display of the image? That way people on bridged channels also get to see the memes. Thanks!

Hi,

Could you please add the trollface as a meme?
Ive made a branch here but i dont want to sign a CLA:
https://github.com/aconitumnapellus/mattermost-plugin-memes/tree/add_trollface

The picture i used is this one:
https://i.kym-cdn.com/entries/icons/original/000/000/091/TrollFace.jpg

Feel free to steal this one commit i made.

I am experiencing an issue with this plugin on the Desktop App for Mac and through the browser. On the iOS app, this plugin works as expected.

In the interfaces that are not working, a blank message is posted and the following logs are printed to the Server Logs (this is in debug mode already):

{"level":"warn","ts":1553089421.5354636,"caller":"app/post_metadata.go:465","msg":"Failed to write link metadata","request_url":"https://<mattermost_server>/plugins/memes/templates/brace-yourselves.jpg","error":"SqlLinkMetadataStore.Save: store.sql_link_metadata.save.app_error, url=https://<mattermost_server>/plugins/memes/templates/brace-yourselves.jpg, Error 1062: Duplicate entry '2412853382' for key 'PRIMARY'"}
{"level":"error","ts":1553089421.671403,"caller":"log/log.go:289","msg":"forbidden content-type: \"text/html\"","source":"stdlog"}

Update 3/22/2019:

The error is the image proxy complaining that whatever link is being posted by the meme plugin is not an image. It looks like the meme plugin needs the user to log in or else it just returns an error page. Perhaps we need some way for plugins to verify that a request is coming from the image proxy since the current method of checking for the Mattermost-User-Id header doesn't work if the request comes from the server (either the image proxy or the post metadata logic).

I have removed the image proxy for now, and the memes display!

With Mattermost Version 7.0.0 and the Memes plugin 1.4.0 only part of the text displays.

Using the example from the README: /meme everywhere "memes." "memes everywhere" results in:

Similarly the example from everywhere.yaml used as /meme geese. geese everywhere also displays just:

Some folks have expressed concerns with whether the images are actually licensed under https://github.com/mattermost/mattermost-plugin-memes/blob/master/LICENSE because of the "underlying intellectual property rights within each image". Is there an agreement that these images are fair use or public domain?

When the plugin starts up, it tries to access the SiteURL, but this results in a nil pointer panic if the SiteURL is not set. We should instead ensure it is set, and return/log an error during OnActivate to make the error more visible.

Working:
/meme brace-yourselves Its Sunday

Not working:
/meme brace-yourselves It's Sunday

Result:
"Internal Server Error" and the following log entry

{"level":"error","ts":1618726829.0428991,"caller":"mlog/log.go:232","msg":"error resolving meme","path":"/api/v4/commands/execute","request_id":"warwwuchztb978swhjfp7jey7e","ip_addr":"93.218.248.222","user_id":"f3c6mis46byi8mhj3bmfswbmrc","method":"POST","err_where":"ExecuteCommand","http_code":500,"err_details":"Unterminated single-quoted string"}

Mattermost 5.34.2 with NGINX

Mattermost is currently in the process of using golangci-lint as the default linter for all go projects. mattermost-community/mattermost-plugin-autolink#108 serves as an example of how the migration should look like:

1. Copy .golangci.yml from https://github.com/mattermost/mattermost-plugin-autolink/ into this repository.
2. Copy Makefile from https://github.com/mattermost/mattermost-plugin-autolink/ into this repository.
3. Copy build/ from https://github.com/mattermost/mattermost-plugin-autolink/ into this repository.
4. Run go mod tidy and make dist to ensure the build system works fine.
5. Update linters-settings.goimports.local-prefixes to the go module path i.e. to github.com/mattermost/mattermost-plugin-aws-SNS.
6. Run make golangci-lint and fix all issues that arise.

Fixing an linter issue is sometimes trivial but can also be quite complicated. There might be cases, where ignoring an issue using issues.exclude-rules is needed. If you don't know how to resolve an error, please reach out to @hanzei on the Mattermost Community Server or ask the question here.

Hi, I've been experimenting in a local fork and added support for additional metadata options in the yaml files, namely horizontal and vertical alignment, outlineWidth, outlineColor. These already had the core features present, so it was relatively simple to add in the yaml options.

I wanted to rotate text for the change-my-mind meme template, so I experimented with using the fogleman/gg library instead of the current image library. I managed to do it and thus the metadata can now accept text slots with a rotation value in degrees.

Lastly, I modified the font support to accept OTF fonts as well.

I'm mentioning all these as I understand that there is a Contribution checklist. These are features that do not yet have a ticket and they are definitely changes of more than 20 lines of code, so I was hoping that this could become the ticket.

Hello,

Would it be possible to convert the hard coded list of images and slots into a modular one ?
A folder with

• The images
• A yaml file for each image, with the same name, containing slots (as actually),
  And a script that build automatically the list with what it find in the library.
  (I think it is the file "assets.go" but I'm not sure)

According to this PR:
https://github.com/mattermost/mattermost-plugin-memes/pull/46/files
the difficult thing seems to be the line of bytes, is it the file hard coded ?

It can be manually launched (no need to rebuild every morning) and it could return errors in command line, as it would be only done by the admin and not the users.

(sorry I'm no dev)

In any case, thank you for the plugin so far !

Let's get a release for #39 out

After upgrading to Mattermost 5.37 we are missing some emojis (e.g. :trollface:). I believe we had this emoji because of this plugin

Could it be, that the emojis were custom emojis? Because there is a note in the changelog of Mattermost.

v5.37 adds support for emoji standard v13.0. If you have added a custom emoji in the past that uses one of the new system names, then that custom emoji is going to get overwritten by the system emoji. The workaround is to change the custom emoji name.

Or any other idea why we don't have these emojis anymore?

I'd like to create memes using russian, but cyrillic symbols are displayed incorrectly (any symbol is replaced by square with a cross inside it) or don't displayed at all.

Is there any way to add cyrillic symbols support?

This is my problem right now, it's a fresh install of mattermost, and I have installed and reinstalled the plugin several times and I still have the same problem. There is also nothing on the logs.

Can someone help?

As discussed in https://mattermost.atlassian.net/browse/MM-22610, this plugin should to the Marketplace. Let's cut a new release for it.

I would like to test it.

I'm an idiot, please resolve this ticket.

Dunno why. In Windows Desktop App.

Running make memelibrary and then make check-style does report linter issues in server/memelibrary/assets.go. The generated file should be correctly formatted.

Let's get the fix #9 released.

This plugin is awesome!

Could your please add this one: https://knowyourmeme.com/memes/distracted-boyfriend

Thanks ! 🙏

Will try to open a PR

Hello,

I've just installed a new Mattermost server in my school and I want to configure this plugin to make funnier to my students ... ;-)

I've cloned the git repo and follow the installation steps, but I've got this error:

make: *** No rule to make target 'vendor'. Stop.

I've no idea of programming, so sorry if my question is obvious. I think that the problem is that the file vendor doesn't exist in the folder of the plugin, but I clone it from the official source.

Any idea to help us?

Thanks,

Would be nice for the plugin to support gif files, tried adding one to the assets/images folder with the corresponding .yaml file but got an error when i updated the Plugin on the Server.

{"level":"error","ts":1568314153.4204962,"caller":"mlog/log.go:172","msg":"error resolving meme","path":"/api/v4/commands/execute","request_id":"iq4rghosbjra5ececu1zg9ic4h","ip_addr":"98.2.226.53","user_id":"t6hzpmdfytgmunhrcy8bgzx5br","method":"POST","err_where":"ExecuteCommand","http_code":500,"err_details":"Unterminated single-quoted string"}
{"level":"error","ts":1568314538.1719606,"caller":"plugin/hclog_adapter.go:60","msg":"reading plugin stderr","plugin_id":"memes","wrapped_extras":"errorread |0: file already closed"}

I've just uninstall 1.0.0 and installed 1.1.1. I was seeing this behavior in 1.0.0 and so upgraded to try and fix. So I now have the latest release, BUT I am seeing this error in the logs. I also am seeing a broken image and the token for the meme when I press enter.

then

Any thoughts?

Currently, the memes are ordered in the autocomplete feature, but not in the list of meme when /meme is called.

It would be handy if they were sorted.

If we implement this change, can we implement the sort directly in getAvailableMemes() (plugin.go) as we always want them sorted ?

@hanzei I figure we should have a CI step that verifies that any new images added indeed match up with the binary array also submitted. I'm not sure what the risks are if these don't match, but it seems like we should sure that they do match.