Git Product home page Git Product logo

Comments (8)

mattbanks avatar mattbanks commented on July 17, 2024

Any chance you can put an example in Codepen or something? If if doesn't work, I can roll back to 1.5.2, but I just want to make sure. It works in the example page, so I just want to verify with something else.

from jquery.equalheights.

fheider avatar fheider commented on July 17, 2024

http://codepen.io/anon/pen/bEdebv

FF42 failed
Chrome48DEV success
Opera31 success
Safari5 success
Edge20 success

from jquery.equalheights.

mattbanks avatar mattbanks commented on July 17, 2024

Interesting that it works everywhere except Firefox. I'm in the middle of a project submission and am giving a talk Thursday evening, so I'll try to look at this on Friday or over the weekend for a possible fix.

from jquery.equalheights.

janjaap avatar janjaap commented on July 17, 2024

Having the same problem here in Firefox. Where before $('.elements-selector').equalHeights() would render the desired result on 1.5.2, the same call doesn't do anything in 1.5.3.
Only in Firefox. Using the latest; 42.

from jquery.equalheights.

mattbanks avatar mattbanks commented on July 17, 2024

I just rolled back to v1.5.2 in master. Everything from v1.5.3 is now in the develop branch and I'll work on it as soon as I have time. If anyone has a chance to take a look, please do and submit a pull request against develop :)

Tagging @osartun for possibly taking a look.

from jquery.equalheights.

osartun avatar osartun commented on July 17, 2024

Oh! 😳 I'll try looking into this asap, but probably won't have time before next week.

from jquery.equalheights.

stefangrund avatar stefangrund commented on July 17, 2024

Same problem here: Firefox v49.

from jquery.equalheights.

osartun avatar osartun commented on July 17, 2024

Oh dear, I remember this.
Unfortunately we don't use equalHeights anymore in our projects as we switched to flexbox-based approaches or to fixed heights.
That's why it passed completely out of my mind. I'm not sure how soon I'd be able to look into this. Maybe you have to revert my changes altogether.

from jquery.equalheights.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.