Unexpected matches in the resulting RegExp about regenerate HOT 3 CLOSED

OK, found the gotcha ...

var list = ["9⃣", "8⃣", "7⃣", "6⃣", "5⃣", "4⃣", "3⃣", "2⃣", "1⃣", "0⃣", "#⃣"];
var regenerate = require('regenerate');
var regenerated = regenerate.apply(null, list);
console.log(list.filter(function (chr) {
  return (0 <= chr && chr <= 9) || chr == '#';
}).length ?
  'There should be #0-9 in the RegExp' :
  'There should be NO #0-9 in the RegExp'
);
console.log(regenerated.toRegExp());

from regenerate.

Regenerate only deals with individual code points or symbols (by design). The problem is list contains strings that contain multiple code points, i.e. the first 21 entries:

"🇨🇳", "🇺🇸", "🇷🇺", "🇰🇷", "🇯🇵", "🇮🇹", "🇬🇧", "🇫🇷", "🇪🇸", "🇩🇪", "9⃣", "8⃣", "7⃣", "6⃣", "5⃣", "4⃣", "3⃣", "2⃣", "1⃣", "0⃣", "#⃣",

I’d suggest you manually create the regexp for those 21 emoji, and have the rest of the regex generated by Regenerate.

from regenerate.

so I guess I should convert those chars upfront and then reparse, right? Thanks. I knew it was me, although a warning or something like "you are doing it wrong with these strings" would have been nicer than a silent success with potentially broken RegExp.

Talking from a parsing security point of view. Will close this anyway.

from regenerate.