Git Product home page Git Product logo

jquery-custom-data-attributes's People

Contributors

mathiasbynens avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

jquery-custom-data-attributes's Issues

jQuery .data() does not render this plugin redundant!

In the README.md you state that jQuerys .data() method renders your plugin redundant. This is not the case as .data() will not access the data-attribute. Instead, jQuery has an internal data store that holds the "data" assigned to each DOM element.

For convenience jQuery will initially fill that data store with the values of the data-attributes when you first select it using jQuery.

That means, that you can't change the value of the data-attribute using .data(). You also will not receive any changes to the data attributes value using .data().

Example:

<div id="test" data-hello="world"></div>
var $test = $('#test');

// You can get the value of the data attribute using .data() after the element has
// been selected for the first time:
$test.data('hello');      //=> 'world'
$test.attr('data-hello'); //=> 'world'

Now lets change the data using .data():

// When you change the data using .data(), the attribute value won't change:
$test.data('hello', 'data');
$test.data('hello');      //=> 'data'
$test.attr('data-hello'); //=> 'world'
<div id="test" data-hello="world"></div>

As you can see, the attribute value has not changed. Now lets use .attr() to update the value of our data-attribute:

// Vice versa, changing the attribute value will not update the data value:
$test.attr('data-hello', 'attribute');
$test.data('hello');      //=> 'data'
$test.attr('data-hello'): //=> 'attribute'
<div id="test" data-hello="attribute"></div>

Now the attribute value has changed but .data() still returns 'data' rather than 'attribute'.

This is essential when you want to use the data-attribute with CSS:

<div id="my-elem" data-size="small">
    <!-- ... -->
</div>
[data-size="small"] {
    /* ... */
}

[data-size="large"] {
    /* ... */
}
$('#my-button').on('click', function() {
    var $myElem = $('#my-elem');

    $myElem.data('size', 'large');      // This will have no effect.
    $myElem.attr('data-size', 'large'): // Yep, that works.
    $myElem.dataAttr('size', 'large');  // Like a charm!
});

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.