mathewwi / vba-rerecording Goto Github PK

Recording GBx movies from reset (SRAM) is currently disabled as it is
believed not to function properly due to unclear problems. The problems
should be investigated and sovled before re-enabling the function.

VBA doesn't record a video in 60fps exactly. Sometimes, a frame is
duplicated, or over 1/60 seconds of audio samples are generated per frame.
As a result, a video/audio length becomes somewhat longer than vbm length.

I think I've understood why this happens now, the problem comes from the
sound emulation code.

VBA sometimes generates over 1/60 seconds of audio samples per frame (it's
a sort of emulation error, I assume). That causes an audio desync with
video frames. To prevent the desync, VBA needs to duplicate a frame to
match the video length to audio length.

To fix the problem, we need to modify the sound emulation code, and let VBA
generate 1/60 seconds of samples always. That may change movie timings, though.

What steps will reproduce the problem?
1. Play the game with auto-fire/hold on.
2. Perform a reset or start a TAS.
3. Watch it auto-fire/hold like you had not reset.

What is the expected output? What do you see instead?
It should not press anything, except it auto-fires/holds the buttons you 
specified before you reset.

What version of the product are you using? On what operating system?
V.21 with Windows XP.

Please provide any additional information below.
Simple fix: tell it to reset auto-fire/hold
upon reset.

What steps will reproduce the problem?
1. compile (will attach patches later)
2. open ROM and play vbm file
3. watch it fail

What is the expected output? What do you see instead?
VBA is expected to play back the vbm file, yet it fails and quits with a
SegFault. Both those Segfaults occur on different parts of the code.
Playing a ROM reguarly runs fine, even sound works magically. Nonetheless,
it's still way too fast (>=200% speed).


What version of the product are you using? On what operating system?
SVN r9

Please provide any additional information below.
Will attach detailed gdb reports this evening.

newAviRecordMethod option prevents duplicating a frame and making the video
length redundantly longer. But the output AVI has wrong dwTotalFrames value
and user may need to rebuild the file by using a video editor like
VirtualDubMod (Direct Stream Copy fixes the file).

I'm not sure if the corrupt header causes audio desync or not, but we
should fix the problem if we can, of course.

Once the lag counter is implemented, the auto-fire patterns should take it
into account.  This way, a user can rapid fire during laggy segments, or in
30 fps games.

Once the lag counter is implemented, there should be a menu toggle /
checkbox that the user can select.  If selected frame advance will skip
over lag frames (via the lag counter).  This is especially helpful in 20/30
fps games.

For reference this is implemented in FCEUX and GENS10

Due to a poor resampling method, some of very high rate waves (ex. triangle
noise of the ending of LADX) sound odd. If we resample them by using
Blip_Buffer, they should be improved.

If you select a rom from the recent menu and it no longer exists, vba will
crash.

What steps will reproduce the problem?
1. Click ESC button
2.
3.

What is the expected output? What do you see instead?
It savestate to slot 9

What version of the product are you using? On what operating system?
vba-rerecording svn85

Please provide any additional information below.
-

This is the same issue as snes9x had in old days.
While movie play, reset is called by read_frame_controller_data().
While movie record, reset is called when user selects Reset from menu.
A desync possibly occurs when you try to record/play reset.

What steps will reproduce the problem?
1. Play submission 1580 from TASVideos

What is the expected output? What do you see instead?

A glitch is used that exploits properties of the RAM values E000-FDFF,
causing destructible blocks to appear instead of empty space or solid bricks.

E000-FDFF should be a mirror of C000-DDFF, however is filled with zeroes.

What version of the product are you using? On what operating system?

VBA 1.7.2 v21 for windows.

Please provide any additional information below.

This glitch is very easy to replicate, as the movie file synchs for many
users. The glitch is explained here:

http://tasvideos.org/forum/viewtopic.php?t=5583&postdays=0&postorder=asc&start=5
2

This is not a problem with any of the rerecording fatures, so don't feel
pressured to do anything if you don't think this is your specific area of
expertise.

avi.framecount() should return total video frame count when avi is segmented.

Similar to the lag-frame reset, make on for the frames executed counter.  I
know I'd find it useful

What steps will reproduce the problem?
1.compile revision 99
2.
3.

What is the expected output? What do you see instead?
2>nafxcw.lib(afxmem.obj) : error LNK2005: "void * __cdecl operator new
(unsigned int)" (??2@YAPAXI@Z) already defined in LIBCMT.lib(new.obj)
2>nafxcw.lib(afxmem.obj) : error LNK2005: "void __cdecl operator delete
(void *)" (??3@YAXPAX@Z) already defined in LIBCMT.lib(delete.obj)
2>nafxcw.lib(afxmem.obj) : error LNK2005: "void * __cdecl operator new[]
(unsigned int)" (??_U@YAPAXI@Z) already defined in libcpmt.lib(newaop.obj)
2>nafxcw.lib(afxmem.obj) : error LNK2005: "void __cdecl operator delete[]
(void *)" (??_V@YAXPAX@Z) already defined in LIBCMT.lib(delete2.obj)
LNK1169: one or more multiply defined symbols found

What version of the product are you using? On what operating system?
Windows Vista

When replaying a .vbm movie without rerecording or appending input, the
movie file should be unmodified. As is, any replayed .vbm file is rewritten
when playback is over.

Many RAM Addresses had been written for VBAWatch before the function of 
RAM Watch was added to VBA-rr, so Loading the .txt file of VBAWatch can be 
greatly helpful.
Sorry for my poor English

This is a regression since it is only reproducible in later revisions
linked to wlib7zip.

Step to reproduce the problem:
* Open any archive file of supported types, with any non-ascii characters
in its name.

The emulator rejects such a valid file as if it was of an unsupported type.

When the emulator is doing too many things (busy; set frame skip 0, open
RAM Search and run a Lua script makes such a situation for me), and
Synchronize Emulation Speed is checked, it runs without handling messages
for a long time. (i.e. I cannot control the emulator for a while at all)

If you uncheck Synchronize Emulation Speed, the situation will be improved.

http://tasvideos.org/forum/p/192109#192109
VBA stops after emulating a few of frames.

load movie, use cheat search, close movie, open new movie, open cheat search

That sequence crashes vba

VBAWatch/VBxWatch cannot watch the shared memory using addresses generated
with "Copy Settings for VBAWatch" or "Copy Settings for VBxWatch" command
under "Tools" menu. The VBA process is detected, but neither the internal
name of the loaded ROM nor the watched items are displayed with
VBAWatch/VBxWatch. Refreshing with F5 has no effect.

I am using top-of-tree as of this post.

What steps will reproduce the problem?
1. ./configure
2. make
3. Note numerous error messages

What is the expected output? What do you see instead?
I expect it to compile.  It doesn't.

1.
There are multiple places, such as
src/proc/proc.cpp
src/sdl/debugger.cpp
that try to cast pointers to u32.
That isn't even valid and isn't a good idea to begin with.
On AMD64, pointers are 64-bit, not 32.  Are you sure
you even should be casting?

2.
There seems to be confusion over the use of bool vs. bool8 in
src/Sound.(h|cpp)
Changing all of them into plain bools seems to fix it on my machine.
Though, I don't know what it's trying to do to begin with,
especially since bool is native in C++.

3.
It depends on zutil.h which clearly states:

/* WARNING: this file should *not* be used by applications. It is
   part of the implementation of the compression library and is
   subject to change. Applications should only use zlib.h.
 */

4.
Then, it fails to link:
/home/scubed/software/vba-1.7.2-21/src/gb/gbMemory.cpp:326: undefined
reference to `VBAMovieGetFrameCounter()'
/home/scubed/software/vba-1.7.2-21/src/gb/gbMemory.cpp:325: undefined
reference to `VBAMovieLoading()'
...
I don't know the cause of this one.
It is trying to link in ../gb/libgb.a
which appears to have the symbol.

In short, the code needs massive cleaning.


What version of the product are you using? On what operating system?
Linux on AMD64

This is badly needed.

Currently I favor the list box style of GENS ramwatch window.  The
disadvantage is that it is a bit cumbersome to add watches to it (compared
to simply typing in an address in an edit box).

Since we are building this from the ground up, it needs ram change
monitoring tool.  This is would be a value that changes in response to a
ram values behavior.  For instance it could be set to "increase" and could
increment each time the ram address increases in value.

For reference, I have also described it here:
https://sourceforge.net/tracker/index.php?func=detail&aid=1959906&group_id=13536
&atid=113536

Implement the cheat search features of VBA-H (screenshot:
http://i56.photobucket.com/albums/g178/ybab321/untitled-4.png )

Download it here:
http://interdpth.arc-nova.org/PJs%20stuff/_/VisualBoyAdvance-H.exe


P.JBoy

This was brought up as a feature idea for SNES9x and I think it could work
well here to.

The idea is to take the cheat search commands such as less than, greater
than, equal, and be able to map them to the main window hotkey list.  This
would make finding RAM addresses very fast.

I think it is a neat idea, so I am adding it to our to do list.

I guess we can port it from DeSmuME.

1. Boot up the emulator and load a (GBA) ROM (from zip)
2. Open Play Movie dialog and you'll see the message
3. The message seems to be appeared when I activate the dialog window

I'm using svn r121 now.

What steps will reproduce the problem?
1. i got vba-rerecording-19.4-src package
1.5. installed libglademm-2.4-dev and libgtkmm
2. run sh ./configure
3. make[2]: Leaving directory
`/home/fuxter/tmp/vba-rerecording-19.4-src/src/i386'
Making all in sdl
make[2]: Entering directory `/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl'
g++ -fno-exceptions -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -g -O2
-DPROFILING -DMMX -DDEV_VERSION   -o VisualBoyAdvance  SDL.o debugger.o
2xSaI.o Cheats.o EEprom.o Flash.o GBA.o Gfx.o Globals.o Mode0.o Mode1.o
Mode2.o Mode3.o Mode4.o Mode5.o RTC.o Sound.o Sram.o Text.o Util.o admame.o
agbprint.o armdis.o bilinear.o bios.o elf.o expr-lex.o expr.o exprNode.o
getopt.o getopt1.o hq2x.o interframe.o memgzio.o motionblur.o pixel.o
remote.o scanline.o simple2x.o unzip.o ../gb/libgb.a ../prof/libprof.a
../i386/lib386.a -L/usr/lib -lSDL -lpthread -lpng -lz 
SDL.o: In function `main':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/SDL.cpp:2600: undefined
reference to `VBAMovieOpen(char const*, signed char)'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/SDL.cpp:2597: undefined
reference to `VBAMovieCreate(char const*, char const*, unsigned char,
unsigned char, unsigned char)'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/SDL.cpp:2603: undefined
reference to `VBAMovieOpen(char const*, signed char)'
GBA.o: In function `CPUWriteStateToStream(void*)':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../GBA.cpp:688: undefined
reference to `VBAMovieActive()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../GBA.cpp:695: undefined
reference to `VBAMovieFreeze(unsigned char**, unsigned long*)'
GBA.o: In function `CPUReadStateFromStream(void*)':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../GBA.cpp:998: undefined
reference to `VBAUpdateFrameCountDisplay()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../GBA.cpp:923: undefined
reference to `VBAMovieActive()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../GBA.cpp:944: undefined
reference to `VBAMovieUnfreeze(unsigned char const*, unsigned long)'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../GBA.cpp:946: undefined
reference to `VBAMovieActive()'
GBA.o: In function `CPUReset()':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../GBA.cpp:3243:
undefined reference to `VBAMovieSignalReset()'
GBA.o: In function `CPULoop(int)':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../GBA.cpp:3758:
undefined reference to `systemFrame(int)'
RTC.o: In function `rtcWrite(unsigned int, unsigned short)':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../RTC.cpp:155: undefined
reference to `VBAMovieActive()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../RTC.cpp:157: undefined
reference to `VBAMovieGetId()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../RTC.cpp:157: undefined
reference to `VBAMovieGetFrameCounter()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../RTC.cpp:128: undefined
reference to `VBAMovieActive()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../RTC.cpp:130: undefined
reference to `VBAMovieGetId()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../RTC.cpp:130: undefined
reference to `VBAMovieGetFrameCounter()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../RTC.cpp:155: undefined
reference to `VBAMovieLoading()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl/../RTC.cpp:128: undefined
reference to `VBAMovieLoading()'
../gb/libgb.a(GB.o): In function `gbWriteSaveStateToStream(void*)':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2421: undefined
reference to `VBAMovieActive()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2428: undefined
reference to `VBAMovieFreeze(unsigned char**, unsigned long*)'
../gb/libgb.a(GB.o): In function `gbReadSaveStateFromStream(void*)':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2698: undefined
reference to `VBAMovieActive()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2750: undefined
reference to `VBAUpdateFrameCountDisplay()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2719: undefined
reference to `VBAMovieUnfreeze(unsigned char const*, unsigned long)'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2721: undefined
reference to `VBAMovieActive()'
../gb/libgb.a(GB.o): In function `gbReadBatteryFile(char const*)':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2151: undefined
reference to `VBAMovieActive()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2153: undefined
reference to `VBAMovieGetId()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2153: undefined
reference to `VBAMovieGetFrameCounter()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:2151: undefined
reference to `VBAMovieLoading()'
../gb/libgb.a(GB.o): In function `gbEmulate(int)':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:3244: undefined
reference to `systemFrame(int)'
../gb/libgb.a(GB.o): In function `gbReset()':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/GB.cpp:1629: undefined
reference to `VBAMovieSignalReset()'
../gb/libgb.a(gbMemory.o): In function `memoryUpdateMBC3Clock()':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/gbMemory.cpp:212:
undefined reference to `VBAMovieActive()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/gbMemory.cpp:213:
undefined reference to `VBAMovieGetId()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/gbMemory.cpp:213:
undefined reference to `VBAMovieGetFrameCounter()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/gbMemory.cpp:212:
undefined reference to `VBAMovieLoading()'
../gb/libgb.a(gbMemory.o): In function `mapperMBC3RAM(unsigned short,
unsigned char)':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/gbMemory.cpp:325:
undefined reference to `VBAMovieActive()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/gbMemory.cpp:326:
undefined reference to `VBAMovieGetId()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/gbMemory.cpp:326:
undefined reference to `VBAMovieGetFrameCounter()'
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/gbMemory.cpp:325:
undefined reference to `VBAMovieLoading()'
../gb/libgb.a(gbSGB.o): In function `gbSgbPicture()':
/home/fuxter/tmp/vba-rerecording-19.4-src/src/gb/gbSGB.cpp:319: undefined
reference to `VBAMovieSignalIgnoreNextReset()'
collect2: ld returned 1 exit status
make[2]: *** [VisualBoyAdvance] Error 1
make[2]: Leaving directory `/home/fuxter/tmp/vba-rerecording-19.4-src/src/sdl'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/fuxter/tmp/vba-rerecording-19.4-src/src'
make: *** [all-recursive] Error 1

My system is Ubuntu 8.10 32 bit.

Please, let me know if i can provide any other information.
Pardon my english.

Currently there is a different command for stopping a movie in playback
mode, vs recording mode.  This is annoying since you either have to
remember which mode you are in, or take the time to map both to the same
hotkey.  Instead, mapping one should automatically map the other by
default, or simply make it one command.  Why do they need to be distinguished?

Once a memory watch dialog is set in place this can be implemented.

If the user double clicks an address in the cheat search list, it should be
sent into the memory watch dialog.  The other alternative is to have a
"watch" button added to the cheat search dialog box.

Savestates should have a separate directory override (as of now I think
they default to the movies folder).

When selecting .avi capture while paused, it should prompt the user for all
settings _before_ the user un-pauses.  As is, it waits until the user
un-pauses before opening the Codec selection dialog box.

This feature has been very successful in GENS and FCEUX.  It is a counter
variable that increments anytime the input is not polled by the game.  The
counter can be manually reset by the user, and ideally the value is stored
in movie savestates.

* The numbering of screenshot doesn't care what is in the output directory.
It often overwrites an existing file.
* It doesn't allow to capture the each of continuous 2 frames, due to poor
implementation of hotkey handling.

Currently Directory overrides are not directly editable.

What steps will reproduce the problem?
1. Connect without my joy.
2.
3.

What is the expected output? What do you see instead?
I already config my joy pad but i remove my joy pad and then open
vba-rerecord. All my setting just disappear. It just back to default setting.

What version of the product are you using? On what operating system?
vba-rerecording svn r85 win32. Windows XP

Please provide any additional information below.
...

Lua scripting should be implemented as similar as possible to SNES9x, GENS,
and FCEUX.

the windows version VBA will have the following commandline options:
-rom
-play 
-loadstate
-pause
-readwrite

and possibly:
-capture

At present, the frame timing of GBA games is incorrect:

1) Generally, the length of one frame oscillates around 280896 cycles. The
average length is exactly 280896 cycles by excluding the first frame right
after the game starts (see below). 

2) The first frame is sometimes shorter than the 280896 cycles even with
the fix in r87, and the deviation will not be balanced out with following
frames.

Aside from being inaccurate, this issue may prevent implementing
deterministical GBA multiplayer emulation that will not dead-lock with
multipe processes.

Fixing this issue may result in desynchronization of GBA movies recorded
with old versions of VBA.

When selecting record AVI , it should attempt to make a default avi name
(using game name or movie name).

Trying to slow down or speed up isn't being completely ineffective. 
Fast-forward still works

It would be nice to be able to disable the automatic ROM close and restart 
after the emulator encounters an invalid opcode (for example, treating it 
as a NOP (i.e. nothing)).

As it is if the ROM crashes you have to reopen it and hope you have a 
savestate. Possibly output a message like "Encountered invalid opcode at 
$address" to a message log or something.

[deleted issue]

Cheats window should be a modeless dialog box so that it can stay open
while playing the game.

The Cheat Search dialog should remember its window position.

VBA crashed at the following line in CPULoop in GBA.cpp (I was playing a
GBA game, of course)

 *dest++ = systemColorMap32[lineMix[x++] & 0xFFFF];

What steps will reproduce the problem?
1. Run a gameboy game on Linux on a fast computer
2. It's choppy, as if it does 10 frames at once.
3.

What is the expected output? What do you see instead?
Smooth, as in 1 frame every 60th of a second,
instead of 10 frames, every 6th of a second.

What version of the product are you using? On what operating system?
Linux on a fast computer.

I've traced down the bug.
In src/sdl/SDL.cpp:
void systemFrame(int)
{
}

That's the per frame delay loop.
Note how it doesn't wait at all.
To fix it, I altered src/gb/GB.cpp and
src/GBA.cpp to call system10Frames every frame,
and changed the throttle by 1/10.

Also, I noticed FCEU had better timing logic,
so I copied and pasted that in to make it a
bit smoother.

Add a an entry in the directory overrides for the default directory to save
.avi files.

joypad.read seems to return the input of previous frame :'(