mastani / laravel-google-static-map Goto Github PK

https://maps.googleapis.com/maps/api/staticmap?key={myapikey}¢er=Tehran&zoom=14&scale=1&size=600x600&maptype=roadmap&format=jpg&visual_refresh=true&markers=size:tiny%7Ccolor:red%7Clabel:1%7CTehran&markers=size:tiny%7Ccolor:red%7Clabel:1%7C35.6907488,51.3919293

why?

It's not possible to install this package on a Laravel v6.0 project, as the Composer dependencies require "illuminate/contracts": "5.*" and "illuminate/support": "5.*".

The package seems works perfectly in Laravel 11. It just needs support in composer.json.

    "require": {
        "illuminate/contracts": "5.*|6.*|7.*|8.*|^9.0|^10.0|^11",
        "illuminate/support": "5.*|6.*|7.*|8.*|^9.0|^10.0|^11"
    },

Thanks for releasing this package!

To support security best practices and exceed certain usage restrictions, the package should allow for generating signed URLs: https://developers.google.com/maps/documentation/maps-static/get-api-key?hl=en_GB#detailed-guides-to-generating-a-digital-signature

Upon recent upgrade to composer stable channel 2, I started to get errors about missing classes;

Class 'mastani\GoogleStaticMap\GoogleStaticMap' not found
Class 'mastani\GoogleStaticMap\Format' not found

When downgraded to composer stable channel 1 (composer self --1) the errors went away.

Suggestion: update vendor prefix to TitleCase.
Do you want me to open a PR, @mastani ?

When a API Secret is passed to the setter, should it be a string or an array?

Shouldn't this ☝️ check strlen rather than count?

Relates to #1

I would like to be able to draw a polygon or line on the map which is possible with the standard static maps API.

I'm happy to write the method into the class and do a PR if you would accept. Would rather contribute than just fork and forget.

Essentially the consuming dev would feed in a GeoJSON array of lat,long pairs which correspond to the points of the polygon. We could also allow for the insertion using WKT strings like POLYGON.

If you are happy, say the word and i'll PR.

Will it be possible to add support for Laravel 8?