massivedisaster / adal Goto Github PK

The goal here is to cover the existing modules with unit tests.
I will update this with the added unit tests:

• adal-accounts
• adal-adapters
• adal-alarm
• adal-analytics
• adal-application-state
• adal-bus
• adal-fragments
• adal-location
• adal-network
• adal-permissions
• adal-utils

• Unregister not working properly.
• Replace current call process to builder pattern.

We have to update and replace the "compile" to avoid conflits between libraries.

@Andrer757 can you look on that?

source: https://medium.com/mindorks/implementation-vs-api-in-gradle-3-0-494c817a6fa

Add a sample project to use and test the library.

Wiki needs some more explanation about the code and how to use things.

Add animation module with animation utilities

Add android arsenal badge

https://github.com/massivedisaster/ADAL/blob/master/adal-accounts/src/main/java/com/massivedisaster/adal/account/AccountHelper.java#L45

https://github.com/massivedisaster/ADAL/blob/master/adal-accounts/src/main/java/com/massivedisaster/adal/account/AccountHelper.java#L136

@extmkv @PedroOkawa @NunoSSilva Guys, I've created a milestone called Release 0.2.0.

I hope we can achieve all the issues for that milestone.

If you have something that would like to be added to the milestone please, discuss here.

Just want to know your opinion.

Add documentation in readme/wiki on how to build, deploy and distribute artifacts to jfrog.

Move module managers to single module.

Move def supportVersion = '25.1.1' from each .gradle to project properties

source: https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html

Replace location with fused location.

Lets prepare for that release.

• Solve travis.

• Update needed libraries

Review all method name and logic.

I've a pending commit witch adds a license header to every file.

The header looks like:

ADAL - A set of Android libraries to help speed up Android development.
Copyright (C) 2017 ADAL.

ADAL is free software; you can redistribute it and/or modify it under
the terms of the GNU Lesser General Public License as published by the Free
Software Foundation; either version 3 of the License, or any later version.

ADAL is distributed in the hope that it will be useful, but WITHOUT
ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
details.

You should have received a copy of the GNU Lesser General Public License along
with ADAL. If not, see http://www.gnu.org/licenses/.

• This will imply that EVERY developer should configure the header for this project in Android Studio (I also have done this, with some screenshots.)
• We could check for this headers being added when some one PR's.

After understanding this implications, what do you think? Should we proceed or leave it without any headers?

Organize wiki and check if it possible to view it in "tree" mode.

In the sample when denying on permissions and accepting other, the neverAskMeAgain is true, and it should be false.

We need to update these dependencies:

• Android Support to 25.3.1
• Google Play Services to 10.2.6
• Retrofit to 2.3.0
• OkHTTP to 3.8.0

At this moment we have abortLintOnError to false.
We need to attack the core of the problem.

Apparently some Account tests are failing in Travis, but we can't replicate in our local machines.

Here is one of the reports.

https://travis-ci.org/massivedisaster/ADAL/builds/239879073?utm_source=github_status&utm_medium=notification

Can you guys help solve it?

Merge release with develop and master and create a new tag 0.1.17

The readme update was made by deploy automator, witch is a responsibility that should't be there.
Moving this logic from deploy automator forces us to put that logic somewhere.

1. A gradle task could be a option but if we do that we can't re-use that code (only by copy).
2. Another tool, will be overkill, IMO, because then we will have to run 2 tools when releasing a version.

What do you guys think?
@massivedisaster/adal-team

I was thinking in, adding documentation and GIF for every module.
That documentation could be done individually for each module.

I suggest something like a table in the readme that points for the specific module documentation inside a docs folder.

What do you guys think? @massivedisaster/adal-team

@massivedisaster/adal-team #add checkstyle to build process.

Run ./gradlew adal-bus:check for the project you want.

• Empty overrided methods must have in its body the following comment: "//Intended"
• Instead of e.printStackTrace() use LogUtils.LogErrorException(BangBus.class, e); from Utils module.

• adal-accounts
• adal-adapters
• adal-alarm
• adal-analytics
• adal-application-state
• adal-bus
• adal-fragments
• adal-location
• adal-network
• adal-permissions
• adal-utils

Add more samples and use cases in sample project

@massivedisaster/adal-dev What do you guys think about moving from trello to https://github.com/orgs/massivedisaster/projects/2 ?

@massivedisaster/adal-dev remove headers with bad strings.

Throw an exception with a message warning when user tries to send a band message with a primitive without any action defined

The packages were transferred to the organization in bintray and the link with JCenter was lost, so
I sent a message to JFrog support to help us with the issue.

@massivedisaster/adal-dev What do you guys think about it?

What would be the caveats or implications in current java projects?

Based on #23, add contributing.md with contribution notes.
This issue will serve to aggregate some notes before creating the file.

Add util to resolve intent before start it.

@Andrer757 has reported a problem with accounts that seem to happen when calling getCurrentAccount.

getCurrentAccount return a new instance of Account[] for each call. This behavior leads to problems when getting the account.

The use case:

Calling hasAccount return true.
Calling getAccount result in Exception.

Fixed in #131

Create a task that builds and deploy every module when build succeeds.

The task must be called via external .sh/bat/ps1.

Add CI with running tests, code check, and more useful features.

• Add checkstyle rules and how to.

Improve .gradle with variables from .properties.

@NunoSSilva would be good to have that in the template too.

We need to remove play-services-base dependency from adal-utils because is not used at this moment.

The location package name must be changed to com.massivedisaster.adal.location

If someone need to use the "old" module(Google Analytics) can use ADAL Version 0.2.0 and below.

I've PR'd it in #98 but still missing the header files.