The optimizely-gem from martijnsch

Make compatible with json >= 2.

A new json rubygem was released (2.0.1).

Failing test test_retrieve_projects_forbidden

Using ruby 2.3 on a freshly checked out git repo.

thomas@optimizely-gem git:(master) 1≡$ bundle _1.13.6_ exec rake
Loaded suite /Users/thomas/.rvm/gems/ruby-2.3.3@global/gems/rake-10.4.2/lib/rake/rake_test_loader
Started
.......F
==============================================================================================================================================================================================================================================================================================
Failure: test_retrieve_projects_forbidden(OptimizelyTest)
/Users/thomas/work/optimizely-gem/test/test_optimizely.rb:65:in `test_retrieve_projects_forbidden'
     62:
     63:   def test_retrieve_projects_forbidden
     64:     optimizely = Optimizely.new({ api_token: '1234567890:xxxxx' })
  => 65:     assert_raise OptimizelyError::Forbidden do
     66:       optimizely.projects
     67:     end
     68:   end

<OptimizelyError::Forbidden> expected but was
<OptimizelyError::Unauthorized(<Your API token was missing or included in the body rather than the header (status code: 401).>)>

diff:
? OptimizelyError::F     orbi  d                                     de   n
?                  Unauth    ze (<Your API token was missing or inclu  d i  the body rather than the header (status code: 401).>)
==============================================================================================================================================================================================================================================================================================
..

Finished in 0.468807 seconds.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
10 tests, 10 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
90% passed
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
21.33 tests/s, 21.33 assertions/s
rake aborted!
Command failed with status (1): [ruby -I"lib:test" -I"/Users/thomas/.rvm/gems/ruby-2.3.3@global/gems/rake-10.4.2/lib" "/Users/thomas/.rvm/gems/ruby-2.3.3@global/gems/rake-10.4.2/lib/rake/rake_test_loader.rb" "test/test*.rb" ]
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/cli/exec.rb:74:in `load'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/cli/exec.rb:74:in `kernel_load'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/cli/exec.rb:27:in `run'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/cli.rb:332:in `exec'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/cli.rb:20:in `dispatch'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/cli.rb:11:in `start'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/exe/bundle:34:in `block in <top (required)>'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/lib/bundler/friendly_errors.rb:100:in `with_friendly_errors'
/Users/thomas/.rvm/gems/ruby-2.3.3/gems/bundler-1.13.6/exe/bundle:26:in `<top (required)>'
/Users/thomas/.rvm/gems/ruby-2.3.3/bin/bundle:22:in `load'
/Users/thomas/.rvm/gems/ruby-2.3.3/bin/bundle:22:in `<main>'
/Users/thomas/.rvm/gems/ruby-2.3.3/bin/ruby_executable_hooks:15:in `eval'
/Users/thomas/.rvm/gems/ruby-2.3.3/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)

Should this gem be deprecated in favor of official optimizely ruby gem?

I was investigating an api issue with optimizely and I just learned about Optimizely X which is basically the optimizely api v2. This gem uses the classic optimizely api v1.

I also found that optimizely has an official ruby gem at https://github.com/optimizely/ruby-sdk and this is available as a ruby gem called optimizely-sdk.

Maybe this gem should be deprecated in favor of the official one?

Please add release tags.

Please add release tags for 1.2.2 & 1.2.3.
This would help me do a diff and understand the differences between these 2 gems.

Please release new version of optimizely on rubygems

Also, please tag the release.

There have been enough changes imo to justify a new release.

Enable travis runs for pull requests.

I opened #10 and I expected travis to run automatically. It did not.

martijnsch / optimizely-gem Goto Github PK

optimizely-gem's People

Contributors

Stargazers

Watchers

Forkers

optimizely-gem's Issues

Make compatible with json >= 2.

Failing test test_retrieve_projects_forbidden

Should this gem be deprecated in favor of official optimizely ruby gem?

Please add release tags.

Please release new version of optimizely on rubygems

Enable travis runs for pull requests.

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent