markusbordihn / bos-daily-rewards Goto Github PK

Is your feature request related to a problem? Please describe.
It is not, just something that could be very useful for servers with donator rank(s); Enabling a player or a group to have different rewards or allowing only them to claim some days. We'd like to use the system to both give out items for everyone to use and also unobtainable things only for the donators as a perk.

Describe the solution you'd like
A way to differentiate who gets/can claim what reward, maybe through a permissions mod like Luck Perms? If that is possible lol

Describe alternatives you've considered
/

Additional context
Nothing really, it's a very nice and simple concept otherwise!

My feature request/suggestion is exactly as stated in the title. I'm wondering if it's possible to set loot tables as the rewards to increase variance to the lists each month due to the way some of my custom mod loot conditions are set up to check for mod seasons, which don't necessarily coincide with calendar dates. It would be nice to have the daily rewards seamlessly fit in with the in-server events going on without needing to edit files weekly.

Describe the bug
This feels like a Bug considering you can access all the Proper Config Options for Daily Rewards, yet you can't hit apply after adding a new reward.

I've tested without any success with the TWO most Popular "n-Game Config Editor" MODS

1. Configured: https://www.curseforge.com/minecraft/mc-mods/configured

2. https://www.curseforge.com/minecraft/mc-mods/gamemenumodoption

To Reproduce
Steps to reproduce the behavior:

1. Download the Configured MOD, Game Menu Mod Option, or both along with the "Daily Rewards" MOD.

2. Click on the 'MODS' option in Minecraft's Main Menu and on the left hand side choose the Daily Rewards MOD which will show another screen called "Client Configurations" for Daily Rewards. Then click "Modify>Fill Items" and then try to add a new Daily reward.

3. For example you can try "minecraft:diamond" and then try to click "Apply" and it won't allow you to add the item which is the issue

Expected behavior
It should allow you to hit apply and successfully add the item you want to add. Out of HUNDREDS of MODS that I've edited configs for this is the first time that I've never been able to edit one.

Screenshots

Debugging
I went through comments on the CurseForge Page, checked other issues here on Github, and also tried to Google it. I wasn't able to find anything.

Is the issue happening in combination with other mods? (If yes, please provide a full list)

Example 1:

• Daily Rewards
• Configured: https://www.curseforge.com/minecraft/mc-mods/configured

Example 2:

• Daily Rewards
• Game Menu Mod Option: https://www.curseforge.com/minecraft/mc-mods/gamemenumodoption

NOTE: Only test with one "In-Game Config Editor Mods" installed at a time.

MC 1.20.1
Forge 47.2.1
Daily Rewards 5.2.0

Describe the bug
Hi I'm back. Thanks for the help last time. I can confirm that the settings work fine and the daily rewards are taking the correct monthly rewards. However, occasionally, and I don't know why, the monthly reward items will reset to the default values. Oddly, the fill items are fine and are unchanged.

To Reproduce
Honestly I am not sure how to reproduce it, it seems to happen every once in a while.

Expected behavior
Config save should persist.

Additional context
I've attached my config file for reference.
https://pastebin.com/cqRA2eWb

Is your feature request related to a problem? Please describe.

The problem that I see is more of a balance problem in any server/pack that decides that new players could join any month but still wanted to reward longer playtime with increasing tiers of items without breaking balance for new players or giving old players now redundant items. If the mod had a way of instead shifting from the month's items to just a list of consecutive items then server/pack owners would be able to increase the tier of loot with the appropriate intended gametime required.

Describe the solution you'd like

Instead of monthly lists, one singular list could be used instead with the items in that list being able to go past 31 days. So day one for everyone would be the same item no matter what month and day 32 wouldn't be a now redundant tier or inversely to a lower level player, something that should be placed 32 days away.

This would, I imagine, only be really viable in the GUI sense while using compact mode, as to not complicate the page rendering this mode would probably only be compatible with compact rendering

In this mode it could also be nice to receive the same list of items (eventually) as everyone else regardless of if you miss days/weeks etc

Describe alternatives you've considered

• no alts that come to mind

Additional context

In short, an example; day 1 on server give iron ingot for example, day 100 give a nether star instead as the player no longer cares for the iron ingot and new players would all follow the same daily rewards regardless of day they start playing

Describe the bug
I've just configurated the server file but it just doesnt works, Maybe i have an error on the file config or doing something wrong.
The readme file doesnt specify if it have a certain order, which spaces can be left blank or if it is compatible with mods.

daily_rewards-common.txt

thanks in advance if you can help me with this! It is a great mod, just i dont know how to make it work for me!

I use Luckperms, what permission do players need to use the command?
For example in Mod MKUltra the permission to use is mkultra.class
probably your Mod also has a permission

Hi,

I am trying to use Daily Rewards. I am using daily_rewards_1.16.5-1.0.0.jar
Whenever I try to join the server with the mod installed I get this:
[ERROR] Channels [daily_rewards:network] rejected their client side version number

And on the client side disconnect message:
reason: Connection closed - mismatched mod channel list

I am using 1.16.5 in server aswell.

Describe the bug
Using quarks inventory managment you can claim all the rewards.

To Reproduce
Steps to reproduce the behavior:

1. Install quark
2. Use extract button

Expected behavior
you claim all the rewards

Screenshots
https://imgur.com/a/2X9ANUM

Debugging
Before reporting a issue please check if there is anything relevant in the crash-reports, debug.log and latest.log file.

Is the issue happening in combination with other mods? (If yes, please provide a full list)
Quark as far as I know

Additional context

MC Version 1.20.1
daily_rewards_1.20.1-4.5.1.jar

Describe the bug
Hi Markus, I'm currently making a new pack and I really like the concept of the daily rewards mod. I do have an issue where after I changed the configuration for the mod, my testers would sometimes get a client-side crash. I have attached one of the crash reports to this issue.

Additionally, it seems like the actual reward scheme is not being applied. Even though I've changed the config, I'm still getting the default seeds, diamonds, etc. Oddly enough, when I preview the rewards for following months, it works. I have tried new worlds, and reset the data too as described on the wiki. I've attached the config for reference.

If it's an issue with another mod, I'd be happy to work it out.

To Reproduce
Have my config and try loading it I guess?

Expected behavior
No GUI crash, and daily rewards that were set are shown.

config
crash report

Wondering if there is a way/plan to make the daily rewards per month statics per day as we want to balance the daily reward monthly ourself and keeping it the same every month. We know that we can edit the daily reward nbt ourself but we might not be able to set it through nbt editor first thing on the first day of next month everytime. The mod is working great so far except for that it randomize our 31 item list.

Hello! I like so much this mod, but I don't really want users on my server (1.18.2) to type commands, so I tried to make the code run through a npc, but that didn't work, so I tried running it through via a command block, but that didn't work either. It can only be activated through text chat. I'm wondering if I'm making a mistake, if not, could I please consider making the commands compatible with the command block? And so they can will be activated by means of a lever, for example. Thank you very much for taking the time to read me, and congratulations on the fantastic modifications you have made!

Rewards Items not showing.
running /dailyrewards claim opens the default ui, not the items in config.

Hello,
Found a huge issue with the mod and was hoping you can fix this. With the quark mod installed you can simply press the "down" button in the inventory and collect all the items at once as well as the "checkmarks". the dailyrewards menu is treated like an inventory of a chest or something. truly wish to use this mod but players stealing all the loot in one second!

1.16.5 version

Describe the bug
Dedicated server crashed when player timed out.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Debugging
Before reporting a issue please check if there is anything relevant in the crash-reports, debug.log and latest.log file.

Is the issue happening in combination with other mods? (If yes, please provide a full list)
See crash report

Daily Rewards: 1.18.2-1.0.0
Forge: 1.18.2-40.1.73

When using numerous mods such as Enigmatic Legacy, certain mods that I've created using MCCreator, but not all which is strange and Jolly Boxes.. the config just skips over these items it seems even though I have the correct ID's in.

Would be nice if your mod just queried for all mods somehow. Idk if this is possible.

Hi bro. Can you help me to change the timer's color, I modified it in the language files but it didn't change the numbers color.

Hi there, I was just wondering if you could shed some light on how the mod works server-side. I've changed the time to 1-minute for rewards, because it didn't seem to wanna give players the option at the default 30 even after being logged in for 2 hours. When I made the change to 1 and reset the server, it gave us the option to claim, but when the day turned to December 2nd, we never got a prompt? Does the server have to reset on the day every day? I tried reconnecting without resetting the server and still did not receive a prompt after 1-min.

Also, it's worth noting that I deleted the world /data files and /player data files as I thought something might have been buggin' when the 30-min config wasn't prompting players. I did not reset the entire world. Does regenerating these files after the fact cause problems server-side?

Or is it that the player must log in after a 24-hour period from their last login? I can see that the server is reading the config files on startup and is recognizing when rewards should be given, but on resetting client and server and trying to join I'm not receiving the rewards even though it says I should get one after 1 minute?

To Reproduce
Steps to reproduce the behavior:

1. Setup configs.
2. Load a server world.
3. Join the server.
4. After the set time, I'm not receiving anything or prompt that I can claim reward.