Can't create 'any' matcher for String or Java interface about kluent HOT 9 CLOSED

Hello @fishb6nes ,

I think this is (almost) expected behavior.

If I use the following Java code:

import static org.mockito.Mockito.*;

public class Test {
    public static void main(String[] args){
        Foo mock = mock(Foo.class);
        when(mock.getText()).thenReturn(any());
        System.out.println(mock.getText());
    }
}

public interface Foo {
    String getText();
}

I get the following exception:

Exception in thread "main" org.mockito.exceptions.misusing.InvalidUseOfMatchersException: 
Invalid use of argument matchers!
0 matchers expected, 1 recorded:
-> at org.Test.main(Test.java:8)

This exception may occur if matchers are combined with raw values:
//incorrect:
someMethod(anyObject(), "raw String");
When using matchers, all arguments have to be provided by matchers.
For example:
//correct:
someMethod(anyObject(), eq("String by matcher"));

For more info see javadoc for Matchers class.

at org.Test.main(Test.java:9)

Looking at their docs it seems like you aren't supposed to return a matcher.

When trying to return anyDouble() I get the same exception.

I think we rather need a way to also trigger the "correct exception" from Mockito, because we're getting a reflection created null when Kotlin doesn't accept null (therefore IllegalStateException).

from kluent.

Another hint is in their Reporter

from kluent.

Thank you for the detailed response.

Hm, so how would we go about stubbing methods that take non-primitive parameters if any(NonPrimitiveClass::class) throws an exception?

interface Foo {
    fun test(foo: Foo): String
}

describe("Foo") {
    val mockFoo = mock(Foo::class)
    given("it returns 'Test'") {
        When calling mockFoo.test(any(Foo::class)) itReturns "Test"   // throws "java.lang.IllegalStateException: any(kClass.javaObjectType) must not be null"
    }
}

from kluent.

I just tested it and you're right, it doesn't work (we're missing tests for this)

I tested mockito-kotlin and their any() method is working. From a quick look they heavily use reflection to create an instance.

The problem seems to be that Mockito often returns null on their any() method, whereas our return type is not nullable. Catching that exception isn't possible because it occurs in the return.

I do see 2 possible solutions:

a) implement our own way to create such objects
b) depend on mockito-kotlin instead of Mockito and wrap mockito-kotlin into the fluent stuff.

I think I prefer the 2nd option because it is also a good opportunity to complete the rest of stubbing/mocking which isn't in Kluent yet :-)

from kluent.

I agree, lets not reinvent the wheel.

I'm not too familiar with this whole 'infix' function thingymebob, but let me know if there's anything I can contribute to. Otherwise I will patiently await any further developments.

from kluent.

I'll get on to this this weekend ;-) Thank you for finding this problem in the first place!

from kluent.

Could you have a look at the PR and the one reviewed commit if this would handle this case?

@fishb6nes

from kluent.

Awesome, matching classes appears to work like a charm locally 👍

from kluent.

version 1.17 has just been released and contains the fix for this issue :-)

thanks again!

from kluent.