Git Product home page Git Product logo

Comments (5)

MarkusAmshove avatar MarkusAmshove commented on July 18, 2024 1

1.72 should show up in mavencentral at any moment, you can then test again :)

from kluent.

MarkusAmshove avatar MarkusAmshove commented on July 18, 2024

I've set the target version to 1.8, because according to Google that's what Android should support on an API level.

Can you check if v1.71 of Kluent fixes this for you? I've had to rewrite/migrate some of the publishing stuff because the old maven plugin for publications was deprecated. I guess some things changed in between, as the .module files are completely new to me.
Maybe I've implicitly built against Java 11 in the past, but I'm pretty sure that would have broke Android users, at least at that time.

from kluent.

ursjoss avatar ursjoss commented on July 18, 2024

Unfortunately that doesn't do it.

I created a small reproducer. It runs the same simple test (asserting "".shouldBeEmpty() and "x".shouldNotBeEmpty() - both expected to pass) once with jdk17 and once with jdk11.

Interestigly shouldNotBeEmpty() passes in both scenarios. However, shouldBeEmpty() fails on JDK 11 but passes on JDK 17.

You can verify this in the action tab.

from kluent.

MarkusAmshove avatar MarkusAmshove commented on July 18, 2024

Thank you for the repro!
I've fiddled a bit with the build scripts and still can't figure out where the issues is. The assertions you're having the issue with is over a year old, so I must have messed something up in the gradle project.

I'll investigate further :)

from kluent.

MarkusAmshove avatar MarkusAmshove commented on July 18, 2024

The conclusion is, that how the current build project is set up, that the JVM specific APIs to compile against are just picked up from JAVA_HOME (the JVM Gradle is started with), instead of the different ways to specify the target version.

Using jvmToolchain is currently not possible, as that would need an update to the kotlin gradle plugin, which would mean that some things the build currently does break.

With #223 that should be no issue in the future anymore.

The workaround from #224 is to remind to start the build with Java 8 when publishing artifacts.

from kluent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.