hello

let's consider this config:

[css]
paths[] = ...
paths[] = ...
cachePath = ...

[tmp_local.css]
files[] = ...
files[] = ...
filters[] = CssMinFilter

[styles.css]
files[] = ...
files[] = tmp_local.css

when compiling through CLI, everything is OK
when using middleware and accessing style.css file, which is the main one, error:

Could not locate tmp_local.css for styles.css in any configured path.

middleware should check if file is a target
(or I did something wrong)

Hey,
In sass files, if, say, you @import "partial";, sass looks for both a partial.scss, or a _partial.scss. Mini-asset however only checks for a partial.scss and doesn't look for the underscored version, and so automatically skips the dependency check.

I've tried to define paths for the LessCSS filter in the following lines:

[filter_LessCss]
node = /usr/local/bin/node
node_path = /usr/local/lib/node_modules
paths[] = APP/vendor/twbs/bootstrap/less/*
paths[] = WEBROOT/css/*

I get this message:

Warning (2): strtr() expects parameter 1 to be string, array given [ROOT/vendor/markstory/mini-asset/src/AssetConfig.php, line 306]

I'm guessing that's because the settings array isn't processed recursively when constant substitution takes place, thus an array is passed instead of the elements of that array. This is the line: https://github.com/markstory/mini-asset/blob/master/src/AssetConfig.php#L443

I guess this could be an enhancement and make things easier for people using tools like nodenv to manage nodejs versions.

I've found this issue while using the Uglifyjs filter but the CoffeeScript filter does the exact same thing.

These filters call nodejs passing a file from /usr/local/bin. We're guessing the file in the bin directory isn't executable by itself (while it should) and that it will be the Javascript file, not some wrapper around it. In my case, I have links to the nodenv shims and thus the filter fails.

I think the best fix would be changing the configuration seetings so that I could just point to an executable without caring about nodejs versions and paths when I don't need it.

I could accomplish this using this config:

'node' => '/usr/local/bin/uglifyjs'
'uglify' => ''

But this could read easier as:

'uglify' => /usr/local/bin/uglifyjs'

And make it the default configuration since it should work in most cases I guess. The node and node_path settings should be seldom needed.

Hi,

I noticed that the url for CURL had changed, now it is:

https://closure-compiler.appspot.com/compile

Hi Mark,
I updated my app to CakePHP 5 and realized, that my commits for the CleanCss filter are not yet merged to the 2.x branch. Could you do that please?

2.x...master

Minor adaptions for the filter are required (argument types and return types), here you find the adapted file which is working:
https://github.com/foodcoopshop/foodcoopshop/blob/issue-917-cakephp-5-update/config/mini-asset/CleanCss.php

I can do the PR if you want as soon as you merge the commits into the branch.

Thank you,
Mario

I've just noticed mini-asset won't find dependencies declared with an import that uses a variable in LESS.

I must say I don't really need this to work since the files I'm importing are vendor files that I won't change. Touching my files is enough to rebuild it. Just noticed it and thought I would report about it.

This will be hard to fully resolve. A possible workaround would be to have an option to disable incremental building or a configurable path to check for changes on any file inside it.

Hello Mark,

Would you consider having https://github.com/postcss/autoprefixer as a default filter? there is already a library that has done most of the work https://github.com/vladkens/autoprefixer-php.

I know it's very easy to create filters but it's a very popular library, many compliers come with it built in.

Happy New Year! Thank you for everything you do.

as of commit 25f9013 (or around cant be 100% sure) asset compress ignores 'themes[] =' ie it doesnt replace theme: in path with currently set theme

ive trace it back to AssetConfig.php doesnt know how to select current theme

When I change the php-requirements of my project's composer.json to 8.2 and then run composer update i get a downgraded version of mini-asset (which then throws errors).

Downgrading markstory/mini-asset (1.11.0 => 1.9.1)

Would it be possible to change <8.2 to <=8.2?

We are currently using the 1.x release (because of asset-compress 4.x) but since we upgraded to php 8.3 the mini asset version got downgraded to 1.4.2 because of this composer constraint in recent 1.x releases: "php": ">=7.4,<8.3".

What is the reason to not allow php8.3 for the latest 1.x releases?

Hello,

what do you think about using Less and SCSS compilers written purly in PHP?

It would make the code less dependent on installing NodeJS or Ruby.

Less: https://github.com/leafo/lessphp
Scss: https://github.com/leafo/scssphp

If you agree I can send a PR.

I'm having problems using SimpleCssMin in that it doesn't resolve relative paths. For example, compiling FontAwesome (trying to get this installed and compiled via BowerPHP), I get this:

I then tried to use CssMin, as per package suggestion post-install, but I get this:

Fatal error: Call to undefined method CssMin::settings() in /home/vagrant/.composer/vendor/markstory/mini-asset/src/Factory.php on line 202

Is there something I'm doing wrong?

After upgrading to cakephp 5 I have the following error:

: file_exists(): Unable to find the wrapper "wss" - did you forget to enable it when you configured PHP? [in /var/www/acme/vendor/markstory/mini-asset/src/AssetConfig.php, line 129
I tried to search on google without luck.
I have added a "@" as workardoun on line 129.
How can I solve this problem?

Thank you

Rudy

I think glob paths don't work when resolving CSS dependencies. The function that searches the file uses file_exists directly on the path setting and the file name.

[css]
paths[] = WEBROOT/css/*
[public.css]
files[] = public/base.less

This will check for the file "WEBROOT/css/*/public/base.less".

Hi Mark,

just tried to use your new mini-asset plugin in a CakePHP 3 project to minify js assets with ClosureJs.

However, compiler.jar could not be found in vendor/closure path due to a missing DS in the _findExecutable call.

line 50
$jar = $this->_findExecutable([ROOT . 'vendor'], $this->_settings['path']);

should become
$jar = $this->_findExecutable([ROOT . DS . 'vendor'], $this->_settings['path']);

as ROOT is defined by cake without trailing slash explicitly.

I think your tests don't come up with this error because you use
define('ROOT', dirname(__DIR__) . DS);
in tests/bootstrap.php which differs from the way CakePHP defines the ROOTconstant itself.

Best regards,
Stefan

the following CSS rule breaks when using SimpleCssMin:

.hoverable :hover span {foo:bar;}

is compressed to:

.hoverable:hover span {foo:bar;}

Any rule with a pseudo-class not attached to a class or element will break.

I'm having an issue with _addConstants() when having open_basedir restrictions in effect.
When user constants are passed to this method, it will raise a warning when treating DS constant as a path if the root path is not contained in open_basedir config (https://github.com/markstory/mini-asset/blob/master/src/AssetConfig.php#L121).
Maybe having some kind of constants whitelist/blacklist to check against the value before validating if path exists?

Currently the filter LessPHP.php depends on the project https://github.com/leafo/lessphp. But this project is maintained too slowly, many issues stay open for long time.

Could you consider the project https://github.com/oyejorge/less.php as an alternative?

how to set constants from console? f.e. WEBROOT in your example

I suggest adding global installation instructions into the readme:

composer global require markstory:mini-asset --dev

and adding __DIR__ . '../../../autoload.php' as the first option into the bin file under autoload paths, in order to accommodate this (it crashes on global install otherwise).

Alternatively, consider using something like box to automate this and avoid the options array altogether.

How can you define a custom filter, e.g. in your project and add it to the stack?
I didn't see any config on this customization in the readme.

Hey, in this line the options are always prepended with a -, but why? It causes errors in my build (using UglifyJs 1.3.8 and node 4.2.6), since it treats - as a file to uglify. Am I doing something wrong, or is this an error? Thanks in advance for the reply.

@import rules with media queries are ignored when checking for changes in CSS files. Examples of such rules:

@import url("fineprint.css") print;
@import url("bluish.css") projection, tv;
@import "common.css" screen, projection;
@import url('landscape.css') screen and (orientation:landscape);

I'm testing a fix using the following modified regular expression in CssUtils:

const IMPORT_PATTERN = '/^\s*@import\s*(?:(?:([\'"])([^\'"]+)\\1)|(?:url\(([\'"])([^\'"]+)\\3\)))(\s.*)?;/m';

I guess this should be enough.

Hello,
Dependency checking now works, however, if I'm trying to import an external library (compass, for example, with @import "compass";, File\Local::__construct() throws an error, saying it can't find compass.scss.

I made a CompassFIlter for this purpose, which basically extends ScssFilter and appends '--compass' at the end of the sass executable, so it's not technically a problem with the core functionality, but perhaps a feature in the filters to exclude a dependency would be useful, or maybe just throw a warning instead of an error if a dependency is not found.