Git Product home page Git Product logo

Comments (1)

markfairbanks avatar markfairbanks commented on August 20, 2024

The beginning of your function is testing if(is.null(sel_col_x)) and that's causing the error to occur because it's trying to test if an object named "z" is null. "z" doesn't exist outside of the context of the data.table, but at this point R is still looking for it in the global environment.

So you just need to use enexpr() before you test for NULL.

overlap = function(x, y, sel_col_x=NULL, sel_col_y=NULL){
  sel_col_x <- enexpr(sel_col_x)
  sel_col_y <- enexpr(sel_col_y)
  
  if(any((class(x)) == 'data.table')){
    if(is.null(sel_col_x)){
      stop('sel_col_x cannot be NULL for data.table objects')
    }
    x = tidytable::dt_distinct(x, !!sel_col_x)
    x = tidytable::dt_pull(x, !!sel_col_x)
  }
  if(any((class(y)) == 'data.table')){
    if(is.null(sel_col_y)){
      stop('sel_col_y cannot be NULL for data.table objects')
    }
    y = tidytable::dt_distinct(y, !!sel_col_y)
    y = tidytable::dt_pull(y, !!sel_col_y)
  }
  cat('intersect(x,y):', length(intersect(x,y)), '\n')
  cat('setdiff(x,y):', length(setdiff(x,y)), '\n')
  cat('setdiff(y,x):', length(setdiff(y,x)), '\n')
  cat('union(x,y):', length(union(x,y)), '\n')
}

R can now test if the expression "sel_col_x" is NULL, which it won't be because "z" is being passed, but R no longer looks for "z" in the global environment because it is an expression.

Here's the code for dt_pull(). Notice how in dt_pull.tidytable I use enexpr() on "var" and then test for NULL? That's what you need to do as well.

Hope this makes sense! If you have any other questions let me know.

from tidytable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.