Git Product home page Git Product logo

Comments (5)

markfairbanks avatar markfairbanks commented on August 20, 2024 1

Just updated the error for the next release - thanks for catching this!

from tidytable.

markfairbanks avatar markfairbanks commented on August 20, 2024

This is actually a difference between tidytable and dplyr. You don't need pick() in functions like count() or group_by(). You can directly use tidyselect functions like contains(), where(), etc.

library(tidytable)

mtcars |>
  as_tidytable() |> 
  count(contains("mpg")) |>
  head()
#> # A tidytable: 6 × 2
#>     mpg     n
#>   <dbl> <int>
#> 1  10.4     2
#> 2  13.3     1
#> 3  14.3     1
#> 4  14.7     1
#> 5  15       1
#> 6  15.2     2


mtcars |>
  as_tidytable() |>
  group_by(contains("mpg")) |>
  count() |>
  head()
#> # A tidytable: 6 × 2
#> # Groups:      mpg
#>     mpg     n
#>   <dbl> <int>
#> 1  10.4     2
#> 2  13.3     1
#> 3  14.3     1
#> 4  14.7     1
#> 5  15       1
#> 6  15.2     2

I'll add an error message to count() - I currently do that in group_by() if you try to use pick().

library(tidytable)

mtcars |>
  as_tidytable() |>
  group_by(pick(contains("mpg")))
#> Error in `check_across()`:
#> ! `across()`/`pick()` are unnecessary in `group_by()`.
#> Please directly use tidyselect.
#> Ex: df %>% group_by(where(is.numeric))
#> Backtrace:
#>     ▆
#>  1. ├─tidytable::group_by(as_tidytable(mtcars), pick(contains("mpg")))
#>  2. └─tidytable:::group_by.tidytable(as_tidytable(mtcars), pick(contains("mpg")))
#>  3.   └─tidytable:::check_across(dots, "group_by")
#>  4.     └─rlang::abort(msg)

from tidytable.

RishavDaredevil avatar RishavDaredevil commented on August 20, 2024

thanks, I didn't know that.

from tidytable.

RishavDaredevil avatar RishavDaredevil commented on August 20, 2024

should I close the issue @markfairbanks this is my first time asking a question on GitHub so I don't know the dynamics?

from tidytable.

markfairbanks avatar markfairbanks commented on August 20, 2024

Can you keep it open? I'm going to use it so I update the error message for this case.

Typically I'll close an issue if I consider it "resolved" (which most maintainers will do the same). Sometimes if you're the user and you think it's resolved you can close it if they don't.

This is just sort of an odd case where the behavior is expected, but a better error message would still be helpful.

from tidytable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.