Comments (5)
Just updated the error for the next release - thanks for catching this!
from tidytable.
This is actually a difference between tidytable
and dplyr
. You don't need pick()
in functions like count()
or group_by()
. You can directly use tidyselect
functions like contains()
, where()
, etc.
library(tidytable)
mtcars |>
as_tidytable() |>
count(contains("mpg")) |>
head()
#> # A tidytable: 6 × 2
#> mpg n
#> <dbl> <int>
#> 1 10.4 2
#> 2 13.3 1
#> 3 14.3 1
#> 4 14.7 1
#> 5 15 1
#> 6 15.2 2
mtcars |>
as_tidytable() |>
group_by(contains("mpg")) |>
count() |>
head()
#> # A tidytable: 6 × 2
#> # Groups: mpg
#> mpg n
#> <dbl> <int>
#> 1 10.4 2
#> 2 13.3 1
#> 3 14.3 1
#> 4 14.7 1
#> 5 15 1
#> 6 15.2 2
I'll add an error message to count()
- I currently do that in group_by()
if you try to use pick()
.
library(tidytable)
mtcars |>
as_tidytable() |>
group_by(pick(contains("mpg")))
#> Error in `check_across()`:
#> ! `across()`/`pick()` are unnecessary in `group_by()`.
#> Please directly use tidyselect.
#> Ex: df %>% group_by(where(is.numeric))
#> Backtrace:
#> ▆
#> 1. ├─tidytable::group_by(as_tidytable(mtcars), pick(contains("mpg")))
#> 2. └─tidytable:::group_by.tidytable(as_tidytable(mtcars), pick(contains("mpg")))
#> 3. └─tidytable:::check_across(dots, "group_by")
#> 4. └─rlang::abort(msg)
from tidytable.
thanks, I didn't know that.
from tidytable.
should I close the issue @markfairbanks this is my first time asking a question on GitHub so I don't know the dynamics?
from tidytable.
Can you keep it open? I'm going to use it so I update the error message for this case.
Typically I'll close an issue if I consider it "resolved" (which most maintainers will do the same). Sometimes if you're the user and you think it's resolved you can close it if they don't.
This is just sort of an odd case where the behavior is expected, but a better error message would still be helpful.
from tidytable.
Related Issues (20)
- `distinct` not working with lists HOT 2
- deprecated notation HOT 1
- Bug: unnest() HOT 2
- Failure with dev glue HOT 3
- Release v0.11.0 HOT 1
- When two tidytables are subtracted, the class `tidytable` gets lost on the way. HOT 2
- weird error using testthat HOT 2
- exposing list_flatten HOT 1
- summarize with across behaves in a strange way and gives an error when I use lapply inside
- Renaming in `group_by()` can lead to grouping by nonexistent columns
- ifelse and if_else HOT 1
- pmap is not working for data frames HOT 1
- Error "mutate_rowwise()" several columns. HOT 2
- Group_by bug with purrr::reduce HOT 4
- pmap() doesn't name list elements using existing names HOT 2
- `tidytable` objects are not printed after loading `quarto` HOT 4
- `group_by` + equality `filter` on column with `NA` values introduces `NA` rows HOT 2
- Allow paged printing in `rmarkdown`
- Release v0.11.1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tidytable.