mark-friedman / app-inventor Goto Github PK

The feature will be helpful when users need to download their projects from the 
old app inventor site and upload them to the new app inventor site.

Make the svn revision number visible in the designer, so we can ask people 
reporting bugs to say what version they are using.

Here's something that might help.

http://ccollins.wordpress.com/2008/01/30/getting-subversion-revision-in-ant/

New jars are available at http://code.google.com/p/guava-libraries/

Purpose of code changes on this branch:

Add threadsafe property to appengine-web.xml file to enable concurrency in the 
app engine server.

After the review, I'll merge this branch into:
/trunk

Write some tests dealing with things like:

 In ProjectServiceTest.java: test the build() and getBuildResults methods

 Create BuildServerTest.java to test invocation of build requests and the sending of test results back to a (mocked?) AI server.

Purpose of code changes on this branch:
Add an example whitelist file.

Details of this change can be found at:
https://code.google.com/p/app-inventor/source/detail?r=13

After the review, I'll merge this branch into:
/trunk

I received yet another source zip from a user recently where the blocks file 
was corrupted (in this case, it was truncated) and therefore failed to load in 
the blocks editor. I think we should add an integrity check when we save the 
blocks file (e.g., length and checksum) and only save it if the check passes on 
the server.

Make it visible to users when the buildserver is up/down.   Probably with a 
status indicators in the designer.

The debugger shows how long the server has been waiting for the buildserver 
while packaging.  We should reflect this to the user.  Better would be to show 
a progress bar.

If you try to generate a barcode and the buildserver is down, the designer will 
just wait forever.   

The bug report link on the designer page needs to go to the new bug reporting 
system, not the old one.

The property motd.check.interval.secs in appengine-web.xml controls how often 
the browser contacts the server to check for a new message of the day. Setting 
it to 0 disables checking. We should probably set it to 0 by default for the 
distribution so that it doesn't use up resources unintentionally.

At least make sure that they are not a potential target for DOS attacks.

Add a call that checks if the builserver is up, and possibly other status info.

Probably most of these have been tested already, but it is worth checking by 
looking over the list of declared servlets.

Two test methods are commented out:
 testParseBreaksInValueResponse
 testParseTwoLineResponse

Can the tests be fixed? If not, should they be removed.

[deleted issue]

[deleted issue]

If you select a label or image component in the designer, the property box is 
missing the labels "width" and "height" over the dropdown lists.

The buildserver uses the project.properties file to get information about the 
project.
Unfortunately, the user-specified icon is never written in this file.

Check docs into source control and make servable by App Engine

Purpose of code changes on this branch:

Don't sign the blocks editor jar file as Google.

After the review, I'll merge this branch into:
/trunk

Make the links in designer to the documentation be settable via properties in 
the appengine-web.xml file.

I found 126 references in the docs (predominantly in the "My Projects" link) 
and another 17 in the code (predominantly in comments)

From Liz:

In the current open source code, the client-side code is the developer version, 
even when it is actually running in production.

This is caused by the code in the <property-provider name="ode.version"> 
section of appengine/src/com/google/appinventor/YaClient.gwt.xml.
Most of the code has been commented out and it now always returns "developer".

This is causing the following differences:
The "(Debugging)" panel is visible.
The Designer toolbar shows the "Add Screen" button.
The tab bar shows in the designer.
The "For internal use only" section of the palette is visible and contains the 
Pedometer component.
The client-side tracking (Google Analytics) is disabled.

From the TODO in YaClient.gwt.xml, I think the intention was to show developer 
messages (#1 above).

As a result of this, the power users have now seen some parts of the support 
for multi-screen apps, which is still incomplete and not really working.

Ode.getUser() has code to deal with a SID cookie. It currently doesn't do 
anything, and we should remove it for the open source code.

From talking to some people, it looks like using nginx (see 
http://wiki.nginx.org/) in front of the build server(s) would be a good 
candidate for this, using it's HttpUpstreamModule.

See the files for more info on what they are supposed to do.

Check if deployment works if you change the port number in the 
appengine-web.xml to something other than 9990.

When a person is not logged into system with gmail account then you get server 
unavailable. anyone who is logged in to gmail account can view whitelist. by 
browsing to appname.appspot.com/whitelist.

Running the test gives:

  [junit] Running com.google.appinventor.buildserver.YailEvalTest
    [junit] Exception in thread "main" java.lang.OutOfMemoryError: PermGen space
    [junit]     at com.sun.org.apache.xerces.internal.dom.CoreDocumentImpl.createCDATASection(CoreDocumentImpl.java:581)
    [junit]     at org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.formatOutput(XMLJUnitResultFormatter.java:298)
    [junit]     at org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.setSystemOutput(XMLJUnitResultFormatter.java:102)
    [junit]     at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.sendOutAndErr(JUnitTestRunner.java:712)
    [junit]     at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:547)
    [junit]     at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052)
    [junit]     at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906)
    [junit] Running com.google.appinventor.buildserver.YailEvalTest

The log says:

junit.framework.AssertionFailedError: Forked Java VM exited abnormally

I tried increasing the Perm-Gen space, both for ant and for the Kawa process 
that's started up in Compiler.java, but that
didn't change the behavior.

To match the current production ram settings we should call the Build Server 
with '-Xmx1828m' and set childProcessRamMb to 2048 (and maybe make it a 
commandline arg).

reported by Shival

One other thing i noticed this during my startup
Bad level value for property: .level

/opt/ai/appinventor-Nov-24/appinventor/war/WEB-INF/logging.properties

I'm guessing it does not like DEBUG which was the default defined in the file.
doing some googling the options are.

Make a pass over all the TODOs, removing any that are obviously obsolete and 
/or embarrassing.

The documentation shown under /learn has a link to my projects.  It need to 
go to the right place.

Rigth now, when you try to connect and you're not on the whitelist, you get a 
"server unavailable" message that makes it seem like the server is down.   It 
would be better to instead bring up a page that explains that you don't have 
access, and explains what is going on.

The whitelist file should be located in appinventor/appengine/war/whitelist.

(Note: to enable use of the whitelist file, the property use.whitelist should 
be set to true in appengine-web.xml.)

I'm running a local appengine dev server, using dev_appserver.sh.
I have a project with assets.
If I kill and restart the local dev server, then every time the server code 
tries to read a blob, ObjectifyStorageIo.getBlobstoreBytes throws an 
IOException.

If we decide not to keep APK files forever, we have to do the following:

Remove the AndroidServlet.

Delete the APK file from storage when it is retrieved, except if the request is 
from the appengine client barcode dialog.

Delete the APK file from storage when the appengine client barcode dialog is 
dismissed.

Currently, blockseditor/build.xml signs BlocksEditor.jar with 
"CN=corp.google.com, OU=Engineering, O=Google, L=Mountain View, ST=CA, C=US".

This needs to be changed so that people who build their own instance of App 
Inventor use their own information.

App Engine currently limits Datastore entries to 1M each.  Some large .blk 
files exceed that.

Purpose of code changes on this branch:
Put an example whitelist in the distribution. Leave flag that says to use the 
whitelist set to false.

Details of this change can be found at:
https://code.google.com/p/app-inventor/source/detail?r=13

After the review, I'll merge this branch into:
/trunk

Can the setup software be including in the App Engine service?  Or does MIT 
need to set up a server for that?

4 test methods are commented out:
 testListFirstBlock
 testListRestBlock
 testSpriteAndListBlock
 testLogicBlocks

Can the tests be fixed? If not, should they be removed?

I initially thought we did, per  
http://code.google.com/appengine/docs/java/backends/overview.html. However, 
Wesley Chun says in an email:

>> 1. you mentioned 100k users, but yet asked for the highest end backend
>> systems. is there a reason why you think you need a backend vs.
>> responding to standard dynamic requests?
>>
> -->You and Greg will be much better judges of what we need than we are.
> Figuring out the right level of requirements is one of the things we're
> looking for you to help with.

yes, with my question in particular, i think a standard dynamic
request will suffice. running a backend is useful only when specific
requests require more than 10-minutes to process.

Ode.onModuleLoad has an option to pop up a bug report form for uncaught 
exceptions. The current version of BugReport.java has a link to a form that 
doesn't make sense for the open source version of the system. Possibly we 
should just get rid of this feature.

The gray button that you push to connect a device, should start with the text 
"waiting to load project" or something like that.   Ir maybe the button should 
not come up until the first project is loaded.

Currently, most people think that a gray button (i.e., text gray_ means that 
there's no device connected, when in fact this is the state where a project is 
not loaded and the blocks editor isn't even looking for devices yet.

The attached project loads on appinventorbeta, but not on our appengine 
instances.  You get "server could not upload.  Please try again later (which is 
a bad error message here) and the Java console says

WARNING: /ode/upload/project/BIG_DADDY_BINGO
com.google.apphosting.api.ApiProxy$RequestTooLargeException: The request to API 
call datastore_v3.Put() was too large.
    at com.google.appengine.tools.development.ApiProxyLocalImpl$AsyncApiCall.callInternal(ApiProxyLocalImpl.java:463)
...

The project as lots of assets and a jillion blocks.  Deleting the assets wasn't 
enough to fix this, but delete about half the blocks did.

I don't know whether there's some storage limit we need to increase, but at a 
minimum, we should have a better error message in this case.

As we're starting to let people test this, it would be nice to make some kind 
of version date or number visible to users.  The build date
info in the designer page currently isn't hooked up, and I'm not sure it's 
build date that's useful anyway, at present.

This was issue #46 in the old issues list. 
http://code.google.com/p/app-inventor-for-android/issues/detail?id=46

It should be implemented in the open source code before the end of 2011.

Add version support to mite experimental service.

See 

http://code.google.com/appengine/docs/java/config/appconfig.html#About_appengine
_web_xml

and

http://code.google.com/appengine/docs/java/tools/uploadinganapp.html#Command_Lin
e_Arguments

for information

Either remove our Google Analytics references entirely or make the GA_ACCOUNT 
variable in ProjectToolbar.java be configurable (and not have a default).